From: Arnd Bergmann <arnd@kernel.org>
To: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Cc: Jose Abreu <joabreu@synopsys.com>,
punit1.agrawal@toshiba.co.jp,
Alexandre Torgue <alexandre.torgue@st.com>,
DTML <devicetree@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jakub Kicinski <kuba@kernel.org>,
yuji2.ishikawa@toshiba.co.jp,
"David S . Miller" <davem@davemloft.net>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 ethernet controller
Date: Fri, 12 Feb 2021 10:32:09 +0100 [thread overview]
Message-ID: <CAK8P3a0Wycgn=Dq8KE+-F2keWj4mKaYQ=Y5RLefYn4gc71vVFw@mail.gmail.com> (raw)
In-Reply-To: <20210212025806.556217-5-nobuhiro1.iwamatsu@toshiba.co.jp>
On Fri, Feb 12, 2021 at 4:03 AM Nobuhiro Iwamatsu
<nobuhiro1.iwamatsu@toshiba.co.jp> wrote:
> @@ -384,6 +398,16 @@ spi6: spi@28146000 {
> #size-cells = <0>;
> status = "disabled";
> };
> +
> + piether: ethernet@28000000 {
> + compatible = "toshiba,visconti-dwmac";
Shouldn't there be a more specific compatible string here, as well as the
particular version of the dwmac you use?
In the binding example, you list the device as "dma-coherent",
but in this instance, it is not marked that way. Can you find out
whether the device is in fact connected properly to a cache-coherent
bus?
Note that failing to mark it as cache-coherent will make the device
rather slow and possibly not work correctly if it is in fact coherent,
but the default is non-coherent since a lot of SoCs are lacking
that hardware support.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-12 9:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 2:58 [PATCH v2 0/4] net: stmmac: Add Toshiba Visconti SoCs glue driver Nobuhiro Iwamatsu
2021-02-12 2:58 ` [PATCH v2 1/4] dt-bindings: net: Add DT bindings for Toshiba Visconti TMPV7700 SoC Nobuhiro Iwamatsu
2021-02-12 2:58 ` [PATCH v2 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver Nobuhiro Iwamatsu
2021-02-14 6:23 ` Leon Romanovsky
2021-02-15 4:49 ` Nobuhiro Iwamatsu
2021-02-12 2:58 ` [PATCH v2 3/4] MAINTAINERS: Add entries for Toshiba Visconti ethernet controller Nobuhiro Iwamatsu
2021-02-12 2:58 ` [PATCH v2 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 " Nobuhiro Iwamatsu
2021-02-12 9:32 ` Arnd Bergmann [this message]
2021-02-12 14:59 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0Wycgn=Dq8KE+-F2keWj4mKaYQ=Y5RLefYn4gc71vVFw@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=peppe.cavallaro@st.com \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).