From: Arnd Bergmann <arnd@arndb.de>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Stephen Boyd <sboyd@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linux PM list <linux-pm@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
arm-soc <arm@kernel.org>, Mark Brown <broonie@kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>, Will Deacon <will@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] arm64: Kconfig: Fix XGENE driver dependencies
Date: Thu, 12 Sep 2019 11:23:29 +0200 [thread overview]
Message-ID: <CAK8P3a0uxZWF85+v73KtvQECErA64yPE7BT3VRZMa=oq3rFtRA@mail.gmail.com> (raw)
In-Reply-To: <f6cefef2bf6b34ec6eb82d3614054734fa5e8dd1.1568239378.git.amit.kucheria@linaro.org>
On Thu, Sep 12, 2019 at 12:19 AM Amit Kucheria <amit.kucheria@linaro.org> wrote:
>
> Push various XGENE drivers behind ARCH_XGENE dependency so that it
> doesn't get enabled by default on other platforms.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> arch/arm64/Kconfig.platforms | 3 +++
> drivers/clk/Kconfig | 2 +-
> drivers/gpio/Kconfig | 1 +
> drivers/pci/controller/Kconfig | 1 +
> drivers/phy/Kconfig | 1 +
> drivers/power/reset/Kconfig | 2 +-
> 6 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 4778c775de1b..cdf4e452e34c 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -281,6 +281,9 @@ config ARCH_VULCAN
>
> config ARCH_XGENE
> bool "AppliedMicro X-Gene SOC Family"
> + select COMMON_CLK_XGENE
> + select PCI_XGENE
> + select GPIO_XGENE
> help
> This enables support for AppliedMicro X-Gene SOC Family
I'd rather not 'select' drivers that might be optional, the 'default y'
should be sufficient as long as it's in theory possible to have
them disabled or as loadable modules.
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 801fa1cd0321..9b2790d3f18a 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -225,7 +225,7 @@ config CLK_QORIQ
>
> config COMMON_CLK_XGENE
> bool "Clock driver for APM XGene SoC"
> - default ARCH_XGENE
> + depends on ARCH_XGENE
> depends on ARM64 || COMPILE_TEST
> ---help---
> Sypport for the APM X-Gene SoC reference, PLL, and device clocks.
This breaks compile-testing, and existing defconfigs
that don't list the driver.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-12 9:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 22:18 [PATCH 0/4] Cleanup arm64 driver dependencies Amit Kucheria
2019-09-11 22:18 ` [PATCH 1/4] arm64: Kconfig: Fix XGENE " Amit Kucheria
2019-09-12 1:03 ` Stephen Boyd
2019-09-12 9:23 ` Arnd Bergmann [this message]
2019-09-11 22:18 ` [PATCH 2/4] arm64: Kconfig: Fix BRCMSTB " Amit Kucheria
2019-09-12 9:20 ` Arnd Bergmann
2019-09-11 22:18 ` [PATCH 3/4] arm64: Kconfig: Fix VEXPRESS " Amit Kucheria
2019-09-12 9:17 ` Arnd Bergmann
2019-09-13 10:12 ` Sudeep Holla
2019-09-20 20:12 ` Amit Kucheria
2019-09-11 22:18 ` [PATCH 4/4] arm64: Kconfig: Fix EXYNOS " Amit Kucheria
2019-09-12 9:19 ` Arnd Bergmann
2019-09-12 9:32 ` Mark Brown
2019-09-12 9:29 ` [PATCH 0/4] Cleanup arm64 " Arnd Bergmann
2019-09-12 9:47 ` Amit Kucheria
2019-09-12 10:03 ` Mark Brown
2019-09-12 9:46 ` Mark Brown
2019-09-12 10:03 ` Amit Kucheria
2019-09-12 10:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0uxZWF85+v73KtvQECErA64yPE7BT3VRZMa=oq3rFtRA@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=amit.kucheria@linaro.org \
--cc=arm@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kishon@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).