From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A86C2D0E8 for ; Thu, 26 Mar 2020 11:07:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0310220409 for ; Thu, 26 Mar 2020 11:07:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sCZpY0E+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0310220409 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kkudrjEjkypIZ8ikGPsb5IWls2BLKIst2ueYskHUrUY=; b=sCZpY0E+MT7wUH AjhPnov2hu1ySve8sCwRbnz+siPHl/xG3wbbMnTSaa5fiBseTptpPZ8CBQvUqHNsjkb1c2PA8N2EE Qn6mR32U+EaSYiYIlKBbQvPnWNj3I0AkrG5a4Gku6c8HJZKd8coZf8eXiTDMc5oAYho0TaJ3IU488 OltccaAt5Qhg3dlkRsz+1ZeqijSHuKk9loWZe+ZhzctMXlgPTCvxcHTTCeiPfgkU00QGjCmp4yZqW wkZA/au71fFlPjG6FpKJ20bjt+y95Xkt+mMWjS/k51fUMvxcfq8SOwCdH5ln+IjX8/lb4m0RE0jjL JoNPuh7GlpU6tMxwz0JQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHQM5-00085N-TX; Thu, 26 Mar 2020 11:07:21 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHQM1-00084K-UX for linux-arm-kernel@lists.infradead.org; Thu, 26 Mar 2020 11:07:19 +0000 Received: from mail-qt1-f176.google.com ([209.85.160.176]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MEVBc-1j2cVV1wDq-00G4q1 for ; Thu, 26 Mar 2020 12:07:15 +0100 Received: by mail-qt1-f176.google.com with SMTP id t17so4786578qtn.12 for ; Thu, 26 Mar 2020 04:07:15 -0700 (PDT) X-Gm-Message-State: ANhLgQ0piyLELFeKxCEbu2BrZ4Y0hZfNjByb+oujqHYewDMiHW/gKg0h twb2r4GT738m7/Chns8zwF5YzL6uTs1nuPqDF3U= X-Google-Smtp-Source: ADFU+vsauIMn1HANI4rLiudPV5R6gi5DYVcgBlL8wZTq3fkMCxAt4oEZzNrRjgAq/uoQkrcXg8Zjy2w1vCbkQYHHbc4= X-Received: by 2002:ac8:16b8:: with SMTP id r53mr7632032qtj.7.1585220834376; Thu, 26 Mar 2020 04:07:14 -0700 (PDT) MIME-Version: 1.0 References: <20200325113407.26996-1-ulf.hansson@linaro.org> <20200325113407.26996-2-ulf.hansson@linaro.org> In-Reply-To: <20200325113407.26996-2-ulf.hansson@linaro.org> From: Arnd Bergmann Date: Thu, 26 Mar 2020 12:06:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] driver core: platform: Initialize dma_parms for platform devices To: Ulf Hansson X-Provags-ID: V03:K1:QKiSYiaI4RzuFtFGXQvinFYIHrrLI+51hLhnJn4ioccfFicwnE4 dyZVXVm5L4CQB0GrtcAxAsLkz4Cg/uqUN3G2zVoPWp+h4FIjS17WzsZ8y/3OryjtJiVbi0b FSUUw2GAlmqY5FRL4RVpo0RBDXFQZUxJSdUoSIBrI144sIvaFsRWoDLOkyrU+Qskr4Xlvlb LjsXluphEonCMQD4UnBGQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:s8FZwwwGlfs=:z64tp4i39f5Hcz6+8QBhSg 7N0LA3dL27IsAk0JAlG9gIVYrrzKmO/LWj3tH3gCHlBUvZdEAaIu6dsGbLYi5FuQ6oJ5h77J0 pOOxpVp/kdrR9nnyVRuszU5ZbC0Jdf1S5uU/wZVlI8l1JZM3/W8ZlY7EfdeqJsBxhbSqVXCxT /t5/hW3PLq5EtLNP6hF+KzSVYFDFlkbZtLW2kEm/fx+WRUGhNJxeXeHvmhm54fUMGvoMFZEXQ WqqfCn9Rq8yGFaEuOx8Azni0+nZEmZOCh5BI70LA03f4a9Zn/rRqBHDtIGHVpLwpXWd+Yg6xY 1puGm1urkM5lgYy6paCQ+syk+M6seYIQ0mt3yHt95Vp4+opuO8kZ0BoSJgDCC4mgZXO9y5u4P kP4dO1II36OSkAx1w88+soKHVzgpI5ZkX3ZwWuY3wyAY60E6uuoYIV4nQm4j0OTX+6BLwkFoV zgUnwAxR53WSXufgavQLF5C3Egxe9kP2XMtPPb4Arpxvt+6I5Vx+9tgd5K/RziYuHR1NM6i8R 79M1PhEI+smqQtxISTJdC0zpfhf9Npy5j0GeRaQ/5VZ75/XO0icsSio098Rn6IuopkbYW7AI0 YSv6i4SREliAU6NXecLwDwN479u+eSImOrJLJdn7+HifwpydcDttWyIn0R3Tsn7BD1XqAw6Gg Jbgpv/1OAsFC03k2hVe6j8PURkoP9lRwRY3Z+jjvrIZCAxmFHPT+w3Oj3UdMyVPyMzFEhu+1q pGCEio3IaR9M292vYQNdReeK72+pHa8QITaYCWIbvFwvUqeBtrpL+Vevf0fFvgb8aURMqiH/O 9j29ouTS4I/TsDAQ+WymLVgvMvZo30BNDligKoc75J4eBvUYYI= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200326_040718_423060_B48F8E25 X-CRM114-Status: GOOD ( 13.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rafael J . Wysocki" , Greg Kroah-Hartman , Linus Walleij , Russell King , Haibo Chen , "linux-kernel@vger.kernel.org" , Vinod Koul , Linux ARM , dmaengine@vger.kernel.org, "# 3.4.x" , Christoph Hellwig , Ludovic Barre Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 25, 2020 at 12:34 PM Ulf Hansson wrote: > > It's currently the platform driver's responsibility to initialize the > pointer, dma_parms, for its corresponding struct device. The benefit with > this approach allows us to avoid the initialization and to not waste memory > for the struct device_dma_parameters, as this can be decided on a case by > case basis. > > However, it has turned out that this approach is not very practical. Not > only does it lead to open coding, but also to real errors. In principle > callers of dma_set_max_seg_size() doesn't check the error code, but just > assumes it succeeds. > > For these reasons, let's do the initialization from the common platform bus > at the device registration point. This also follows the way the PCI devices > are being managed, see pci_device_add(). > > Suggested-by: Christoph Hellwig > Cc: > Signed-off-by: Ulf Hansson Acked-by: Arnd Bergmann _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel