From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE8CC433E0 for ; Mon, 29 Jun 2020 11:42:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D3E723BA9 for ; Mon, 29 Jun 2020 11:42:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Z+JdfDAs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D3E723BA9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8A12cPLBSTRpVOsht8VIm9+Be/vtSDq7axnfBT5kgh4=; b=Z+JdfDAsP95cHq4+4XmdOVW+K dcsYUDwDYXoZbt9JLNZTVIzzhrOFZDifcboDJAiowWr/XM/YA4fzG+bVGtNNsuHT0m6w7Ncj2Voi7 d3yiKhtCr3u4qycVkgKs9GX2O/tHnOOmhs2C5HkitB0jxu8iLSnERyFlkF7t37mrycUStfqQGfstO VUohPR4OdMDqn2LipYUNPrrUCsaUU6F1mZMpuO9GeGbNC95ZySZJm6fIkmgZUNYbV5clvhBtAQZ5O IT39wH/Wwcz+62svtmFfs4RMrHJAy2L5DLheBu3pZ/2IVFqOhBqjhu0OSmer4jObuC08ix7I6k9Ml Fkt4bVGYg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jps9Z-0003Wd-1G; Mon, 29 Jun 2020 11:40:49 +0000 Received: from mout.kundenserver.de ([212.227.17.13]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jps9W-0003Vo-1A for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 11:40:47 +0000 Received: from mail-qt1-f171.google.com ([209.85.160.171]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MJEpp-1jWHlX2LCV-00Khwz for ; Mon, 29 Jun 2020 13:40:44 +0200 Received: by mail-qt1-f171.google.com with SMTP id u12so12492876qth.12 for ; Mon, 29 Jun 2020 04:40:44 -0700 (PDT) X-Gm-Message-State: AOAM532UsBjt6g4N7i87ll4TmpvUwEo4MNRNUeqX640fmYeoTegbP5qD 5bc5Q7/akl1V4sonQxrNeEv5w4Qt/ULzv0hAIv4= X-Google-Smtp-Source: ABdhPJz3molUt3XhhH/gcKqW2wmJX47FKk5O6OYBrVzFJ60Zs/j1zw8wVX5Qp6lQIudUPZgdiQLCp03/RIF2vyQgt/Q= X-Received: by 2002:ac8:2b98:: with SMTP id m24mr15453696qtm.7.1593430843466; Mon, 29 Jun 2020 04:40:43 -0700 (PDT) MIME-Version: 1.0 References: <1593410042-10598-1-git-send-email-Anson.Huang@nxp.com> <1593410042-10598-11-git-send-email-Anson.Huang@nxp.com> In-Reply-To: <1593410042-10598-11-git-send-email-Anson.Huang@nxp.com> From: Arnd Bergmann Date: Mon, 29 Jun 2020 13:40:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 10/10] clk: imx8qxp: Support module build To: Anson Huang X-Provags-ID: V03:K1:51RsZgAcBvLNr6E9+Jg6WapfTIuuMHVPOeaStf0OgKKVoTsTjMu Ybra2qB4ERLb2RewK7QthyyWXRUAXFcxincafviZEomsCOR0eDA4kvECXFK7PzF1HciPdWw gfl43BrYUgJFlMj6SgNBxh+6F4LZlZH4uhASB/8qwOB8NDFRU9carMJhni3+emXUESWGHRG 79HHuwDimJiarzlhkIvow== X-UI-Out-Filterresults: notjunk:1;V03:K0:dGvef4Aa6uU=:q4XB4zBOCm1Hwd7+TzJzkU PWBLCjgZ3bAYqOi2N5JOCTGafdDnnBnD/cv3MqFuRsB+8ghFN6XUK5q4gW8EKumu/qinlHvaW MlIW7ITo8MF3KrKgzx7zK9knot+ey8E9GdAn3qBtOM7t9qw77tsrBhdlhmL+1gVK5mNOw9wEk Lq/V7hDjlASBgH9sCfhtFaTLiMxwjRl1MN51mTpXTqGaK64CuX+yFCeZLswJDBoXKfvDUi9O5 QXmNLZLdRwxokIXEZAj5OE0+YJpxRVfVia+ItLtnc+BDZCRSdHNGHX5dalIBxpmIGd2BOtMz0 HfI37znpL2sLPJ+sjQheOwMsnNdZNq15ld7Dmk4e86+duBLmIhb3rkwNSOyygl143C5HM77tX 930fGZv2KScN/45SPizOQ/4LI/I26n0b0PvVwGge19WC80lTx/c1IQhsTbLJ1tEXRv4zzfO0e phvks8bOFH4aw3uYfTqPjHcW2mUWDs0h4L1POgdDJL8FNAuzzFuxHRqdIlroQg7ClQic2pHoK wOSx3xqoGm8jDe9W5S7QU6w8IjGUn8OujaOtllUsmUMQJqmDceCr2JZUdGLG63IdEu2++vh1b xdSiIYWo7IP3n/EN0PhZ+/gKord+p/KXg4aLMEp5FRJ0Ef7bqpNxr/JLSC2qZY5F21exaOg6j NjiAdstzb73coVIT+l4n2+FnWck33q3omZBZkvoX/inNt4h6C/TXUfucwTVad3ofSvCPqBCwb 5/pW8zS9Na3TWRsdFVstF4vbxYKfvkFgBoJ7FWxrVceK1pP09hhAENzOhyBFCmssEroCIccOs Wwbx5x9YUAKIvCQqGyS0IeEJE+wEDnRASk039tP4MvRJx85ckE= X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , Stephen Rothwell , Peng Fan , linux-clk , Andy Duan , Abel Vesa , Stefan Agner , Stephen Boyd , Shawn Guo , Sascha Hauer , YueHaibing , Russell King - ARM Linux , Daniel Baluta , "linux-kernel@vger.kernel.org" , oleksandr.suvorov@toradex.com, Al Viro , Sascha Hauer , Fabio Estevam , Michael Turquette , Linux ARM , NXP Linux Team Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 8:06 AM Anson Huang wrote: > > Support building i.MX8QXP clock driver as module. > > Signed-off-by: Anson Huang I would just combine the per-soc patches into one, as they all have the same changelog text. > diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c > index 04c8ee3..8afaefc 100644 > --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c > +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c > @@ -232,3 +232,4 @@ static struct platform_driver imx8qxp_lpcg_clk_driver = { > }; > > builtin_platform_driver(imx8qxp_lpcg_clk_driver); > +MODULE_LICENSE("GPL v2"); Same thing here: please try to make it possible to unload these drivers, and add MODULE_AUTHOR/MODULE_DESCRIPTION tags in addition to MODULE_LICENSE. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel