From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08986C433DB for ; Thu, 4 Mar 2021 09:37:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82A0264E6B for ; Thu, 4 Mar 2021 09:37:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82A0264E6B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P8tDqHoGaSe/9FzqQnJmmu6i+UkLtLul+D30KHaJbyM=; b=fBpeB3O1NfWI8Se3tjJKUimBV bg0L3NDXrPaIMGI7HFfZd7Q7SmhDIojh6d4esWAqT2+/IthgHXJhaLFoNvd0ZNuWxRTaZhI+Jb30D jqAM1idYdV7Yq9Ffa7PLNm7PSphsu8uR4v1dYBfWtg7/IJpfOJTGT0f+nFSTKACfzThx1VnDz+hGA Rl14lgntNcxUsTk0tj+uWkB9YZyDie8DEfn93KVLSNIuKBP9i7uoCqMUlfnKclKWk1tjPqAdvJnrB x2QtBlwGSHuVKlt3mFaTFrQ4KU55PIqf8IZgTovHAmzOZq51KyYWkhLFwFc8c4eHKFKvd5B1vFUVY YShuwGSFA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHkNF-008HeP-Va; Thu, 04 Mar 2021 09:34:26 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHkJO-008HWv-GL for linux-arm-kernel@lists.infradead.org; Thu, 04 Mar 2021 09:31:38 +0000 Received: from mail-oi1-f179.google.com ([209.85.167.179]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N8GdE-1lmSRI0yfI-014Cwl for ; Thu, 04 Mar 2021 10:30:20 +0100 Received: by mail-oi1-f179.google.com with SMTP id a13so29407760oid.0 for ; Thu, 04 Mar 2021 01:30:15 -0800 (PST) X-Gm-Message-State: AOAM532Gts57PWu9u39WfKsPr17lv0kW1BFN1NTdp2Bk8eDbRORuV4/4 3lcdXEDTsTW0JtJUUPH3AuUBZESZTt6eZiysMvk= X-Google-Smtp-Source: ABdhPJw9uBr6qnUdYOKxaWbXMTUVBRRhs8WjTeJMLjKfrKtwZ6pHKDu0JmaPxdme0uAqtllpnrMi8LbsIwEL/vQ9FQo= X-Received: by 2002:aca:4fd3:: with SMTP id d202mr2227269oib.11.1614850214795; Thu, 04 Mar 2021 01:30:14 -0800 (PST) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-3-brad@pensando.io> In-Reply-To: <20210304034141.7062-3-brad@pensando.io> From: Arnd Bergmann Date: Thu, 4 Mar 2021 10:29:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/8] spi: cadence-quadspi: Add QSPI support for Pensando Elba SoC To: Brad Larson Cc: Linux ARM , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , DTML , "linux-kernel@vger.kernel.org" X-Provags-ID: V03:K1:s2w9CTgaTh2Ia/3IRUi/V+9OrfpqfRg1d0YT1ZzfNR9K2kOPp0d tWOyJKFOl56ZNjIxP9qlLq3yjejEaVHWSPzHJAL6v2y0HBCM1oG2Mjj4CLcVMBAi2PZDyhT sn89/69G9rzhlmL8M2QS4X6X2a7KrTllbx9zdDTH4HHmvEqgE3tDYFIV1UqNlxxcKhwhJBD u16I/ERhVOAQ5c2xiSK2g== X-UI-Out-Filterresults: notjunk:1;V03:K0:pulz9fl9XEQ=:mqjuozBCAZaEeuo4EuATau kLqroZYCM642/KcGS/x6kF/JKO67U58s3AqXA7HB/iho2RzJPf3PmazPkzQEXMCPwLM1WX8Rm hdUWLGw4aglKjeqk+gmpoJVmf4a/yhxs3C5eYjxVN6Gq/lwWynbk0mVSd4566iX27gJh7CW6o hVzIwUePmLljB4kF3rliMoU5EyURhnC2hPMCk+nmVpwICKpwudua1H+5dOpktkGZdQlgDGzlF 35tbuYkRmjWkJht/byhFITUG8mMzTWv7X3ztcpoabq+6TqNbBpxkYADL5LsBqf5d5h5W80UdV fGTXJpSZ8glqfd3epuLEzIlhiNTbiKP7jPmQ5V4fhI8zPAcmmEty5KlWse1cUMUGcTN//+PwY BOQJXQCgwu9itHDVeBAfsks6agaO9t6YC59Yoq2lh3tR+5FETJSiY56soLFTlLt2ZkhUY7KYM yGXuGx93MH0nQmSS0SPFHU81I+RxdSjmizCZn6BxbxaX34aIefpSbviZbf1f8AkGuvqSKKPiO wN8SWtZAYyBiwchGp4OU1mg+4rGEuxj6ms914a74+oZg8enyyw8q0WEuIC+/6N+fA4ZHNpXip CAiK/S6RJwdIHwzAX+cxezbs6tPnynCD9p X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 4, 2021 at 4:41 AM Brad Larson wrote: > > Add QSPI controller support fo Pensando Elba SoC. > > Signed-off-by: Brad Larson > --- > drivers/spi/spi-cadence-quadspi.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c > index 442cc7c53a47..fb0d9b0bd596 100644 > --- a/drivers/spi/spi-cadence-quadspi.c > +++ b/drivers/spi/spi-cadence-quadspi.c > @@ -1353,6 +1353,7 @@ static int cqspi_request_mmap_dma(struct cqspi_st *cqspi) > cqspi->rx_chan = dma_request_chan_by_mask(&mask); > if (IS_ERR(cqspi->rx_chan)) { > int ret = PTR_ERR(cqspi->rx_chan); > + > cqspi->rx_chan = NULL; > return dev_err_probe(&cqspi->pdev->dev, ret, "No Rx DMA available\n"); > } Please don't mix whitespace changes with code changes. > @@ -1632,6 +1633,10 @@ static const struct cqspi_driver_platdata intel_lgm_qspi = { > .quirks = CQSPI_DISABLE_DAC_MODE, > }; > > +static const struct cqspi_driver_platdata pen_cdns_qspi = { > + .quirks = CQSPI_NEEDS_WR_DELAY | CQSPI_DISABLE_DAC_MODE, > +}; > + > static const struct of_device_id cqspi_dt_ids[] = { > { > .compatible = "cdns,qspi-nor", > @@ -1649,6 +1654,10 @@ static const struct of_device_id cqspi_dt_ids[] = { > .compatible = "intel,lgm-qspi", > .data = &intel_lgm_qspi, > }, > + { > + .compatible = "pensando,cdns-qspi", > + .data = &pen_cdns_qspi, > + }, > { /* end of table */ } As mentioned in my reply to the dts file, the compatible string needs to be somewhat more specific. I also wonder if it would be better to define separate DT properties for the quirks at this point, so not every new SoC using this device needs to have its own quirks definition. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel