From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FFE5C433B4 for ; Mon, 19 Apr 2021 13:59:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E948561245 for ; Mon, 19 Apr 2021 13:59:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E948561245 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U8V9COP2DZEAgCElJNVHb7rDm5wGco6bBbVftWirkx0=; b=I/xAhdEOxYioLNVQKjgGlyXT2 tBTxA+w3nWBSZrBEOwPJdzUuUtpOsTDQXqFni6CY/UMI4I0FlEig8YekMEBLlvTjBP/dZFWR5itBd dmnTq5OpZlqXsLQmDpT61AvIw5rUFP3WslJ0rlnZhadw0Ta9hHmPD7/vvVbErTKSwBUkCkt5Rkv1k abywtZ0Az01v91+kncTOlB2YJNJS6qEzWaK791ELmFDpqh2vUekty9OSLPMCKpAIldVuPclM/GZ4O yjqIGQWmr6vq/YoM9NrMykwqypBYC4OtQxLasR9+3tevIBSxc8cqN1cY1vb0jHwajQEzQdF3UfG1n 3cWdA1i/Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYUPA-00A2MD-3C; Mon, 19 Apr 2021 13:57:36 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYUP6-00A2Ll-Hj for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 13:57:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zRh7fRHZvXudHaJ781jdHLydXBTufenFLmn52jMNO50=; b=TfZoo+kVFRW2uqzr+g2JrKZ62g d6SO3OvcoZLFy2RI8tcoVV7poitC/3fuwxxy/fYENrQW4a2A2sxdKjW6OMNicPPhcqb0jVqEwo4ee Y3RHgX8QDaOm+Y4NY6NC1b9JMN9gyqXraA6zezwB9FmaGpPUffsxAQNcs4NLXj6IPKbpLq8dOnXHC 4IUeHPczFBT4XxYA34t9/AC++ZvUuvNqzZIjdtqjrmGvV7Hd67UryGZLJ0US6MFQ23hY3dOVSEMO3 H1Gm6VyW8mRlFBGsNWspvzcwKtFg8Y89XAsF6Cj+b7NL4z7+4qlQagmBo2VPR0El23UNWLq1AmRj4 aPrBtFqg==; Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYUP3-00BQNt-Jw for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 13:57:31 +0000 Received: from mail-wr1-f43.google.com ([209.85.221.43]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M4s8v-1lXfBg0M2p-001xIn for ; Mon, 19 Apr 2021 15:57:27 +0200 Received: by mail-wr1-f43.google.com with SMTP id j5so33201651wrn.4 for ; Mon, 19 Apr 2021 06:57:27 -0700 (PDT) X-Gm-Message-State: AOAM530K9UzOUPO/nAykIwHVdTQ8z2PInKFsbnSt2WXDyHQ4bJjKw8WZ EoWfDDWZ7whWxPEFcrKHEqT9iSbPasD+nF/DRds= X-Google-Smtp-Source: ABdhPJy9unBhJAs1A1vsfAqD5VJWjn3s3JNXApCpMos5sX1l7PV8pNqCwemCX23fbcibgwHMtR1BIfEvdX4jMjdJ3E0= X-Received: by 2002:adf:db4f:: with SMTP id f15mr14806757wrj.99.1618840646771; Mon, 19 Apr 2021 06:57:26 -0700 (PDT) MIME-Version: 1.0 References: <20210415101037.1465-1-alexandre.torgue@foss.st.com> <20210415101037.1465-13-alexandre.torgue@foss.st.com> <96da49dc-f24d-aa12-e1d8-39b5a5b6fbc9@foss.st.com> In-Reply-To: <96da49dc-f24d-aa12-e1d8-39b5a5b6fbc9@foss.st.com> From: Arnd Bergmann Date: Mon, 19 Apr 2021 15:57:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 12/13] ARM: dts: stm32: fix DSI port node on STM32MP15 To: Alexandre TORGUE Cc: Ahmad Fatoum , Rob Herring , Marek Vasut , Jagan Teki , Manivannan Sadhasivam , Marcin Sloniewski , Linux ARM , DTML , linux-stm32@st-md-mailman.stormreply.com, Linux Kernel Mailing List , Lee Jones , Jakub Kicinski X-Provags-ID: V03:K1:2VfU5ccOi3ljpcbgkqRcdQo7SPUqzZb7r44257QMkhPTk00W2nq O7YOVEyp5r0WX5B0/wRR8uuH5+QjjMejD8lsdABDyCN4MnpH/5lnZih0wVNKJjrCqWZsMli 90wFvea2isn1wIib1TXgII6ipqvUXE+d/i9DELNe+b2tqFEMsg2+XUwSjrMisDLofLKqa+K GCYJTbKHXMlkf6HUBL1bQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Pc9vejOXH1E=:g6oCWp7nJey0j2AvySLYxw GVUvvEYuFB/AEd+5wXRViRldVrYmIwBYaShdwbm0vHCu6bNTVPrkfKI1QWuuJcOw23iCjqpER p6IwG7JziWkRJhkV+VL6gJfNFsR/NYgO7i7XH1jCBltIaDjiU9uZtToRS6iW2HWfN/ARxhEmP etzV7bJ2yvT9MJsZZcaDxXQ2HzmoOhC1ql7YfZ8xF5K4nuUOy5JkHepFDUWjVGwE0dJii1VMV 0K4Rt2cD1zcClUgp5b2TxdE6cp2so7V3LA9aeIMnV9tcf8SlnPuL7ZWV+U4SjyRXWXwspDri+ sUW9zZVNQQdGVbw52pdHutAp9Jig+59H6tNEBM+vw4rOShGM0yrXDEUWJGlUC6Wg+wfs1LZre FOlKgL+xmR070NdKljFRf6Qt6pUCCf91DjsueTQD8tOacz8LZdteU1CDAMJ2ReDMLNXUDsMGH edNQUH6rW49Ff2FZYek6Vj+GYUNxivmgUpRylETvvKBoSP19BroRHh5viQxOFt0GkZVLEwA97 xT7Kf9DCJrUdaF3IWHftpx7QfMLyvcJeED3JGYGVfpRnqkOoNmTnGBwLyZ2i2R8mWCURF3Wsl Ax7sBMo5TWt9X9IZ+BnaNucysUfVs3LKbPv4xErPdJeTybcFj/7jiKIZkXgKwVMox8/Rgo2Yv rOZ8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210419_065729_968706_ADCC9749 X-CRM114-Status: GOOD ( 28.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 15, 2021 at 2:23 PM Alexandre TORGUE wrote: > On 4/15/21 12:43 PM, Ahmad Fatoum wrote: > > On 15.04.21 12:10, Alexandre Torgue wrote: > >> Running "make dtbs_check W=1", some warnings are reported concerning > >> DSI. This patch reorder DSI nodes to avoid: > >> > >> soc/dsi@5a000000: unnecessary #address-cells/#size-cells without > >> "ranges" or child "reg" property > > > > This reverts parts of commit 9c32f980d9 ("ARM: dts: stm32: preset > > stm32mp15x video #address- and #size-cells"): > > > > The cell count for address and size is defined by the binding and not > > something a board would change. Avoid each board adding this > > boilerplate by having the cell size specification in the SoC DTSI. > > > > > > The DSI can have child nodes with a unit address (e.g. a panel) and ones > > without (ports { } container). ports is described in the dtsi, panels are > > described in the dts if available. > > > > Apparently, the checker is fine with > > ports { > > #address-cells = <1>; > > #size-cells = <0>; > > }; > > > > I think my rationale for the patch above was sound, so I think the checker > > taking offense at the DSI cells here should be considered a false positive. > > If it's a "false positive" warning then we need to find a way to not > print it out. Else, it'll be difficult to distinguish which warnings are > "normal" and which are not. This question could also be applied to patch[3]. > > Arnd, Rob what is your feeling about this case ? I don't have a strong opinion on this either way, but I would just not apply this one for 5.13 in this case. Rob, Alexandre, please let me know if I should apply the other patches before the merge window, I usually don't mind taking bugfixes late before the merge window, but I still want some level of confidence that they are actually correct. Ahmad, if you feel strongly about this particular issue, would you like to suggest a patch for the checker? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel