From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98545C433E7 for ; Mon, 12 Oct 2020 15:32:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FFCB2076D for ; Mon, 12 Oct 2020 15:32:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jDOY20x+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FFCB2076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=veI/REqdPFvZTgmWDAQiyOV8LDEqf0rMg8FANpYlHOA=; b=jDOY20x+u5ImXPMeDwM/UWZJ3 OspkqdXacRMMdiV57BzZ+j7C4NW/WcOrq4ynBUO1RzsdE7Z8XalV8P3eIkZ8Z1nicaUgEHb+3RHPN Cue2subl/ScUCJgMALG8bT8KSO8XNYRZ0dCYQzpjUuhPChmnyS3XWZWQgOPjxUi6FbnjC/QCo+aLt RuOGvig4hx5FyQI/KVQpMFO179JeBZCIQwo9GWs3VQsqJNJBwYCQkh3PuCv3bsSRWqpXzt3/U1UDO t0gjGecnFs04PkujkbWHz5oG0f+jbl8vZe23ggN5pmI7kOqw45aNluWkPrieNGBRbnvgp7xg/Y0bC sS/jLDGcA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRzn6-0007x9-De; Mon, 12 Oct 2020 15:31:12 +0000 Received: from mout.kundenserver.de ([217.72.192.75]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRzn3-0007wJ-ES for linux-arm-kernel@lists.infradead.org; Mon, 12 Oct 2020 15:31:10 +0000 Received: from mail-qk1-f174.google.com ([209.85.222.174]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MLR5h-1kkLkn1b2x-00IUQc for ; Mon, 12 Oct 2020 17:31:06 +0200 Received: by mail-qk1-f174.google.com with SMTP id i22so1750984qkn.9 for ; Mon, 12 Oct 2020 08:31:06 -0700 (PDT) X-Gm-Message-State: AOAM533h8nwtRrPpggDNcNoEpCKCogSIjZodQBvjV6cRGffpzYJ+Bvfo 5N2eS/FWmm3DHwbVwlPG3FP6V4HCSX/EQ9avwdA= X-Google-Smtp-Source: ABdhPJwvsy1oYnuUy5ljPB75evT7Pa/tyuqSvAbw5I5mVYvqU4g4l8zWrAr5hU7svLQBi/0OorEm0EPGvxy5dZlnbs0= X-Received: by 2002:a05:620a:2ee:: with SMTP id a14mr5630220qko.286.1602516665130; Mon, 12 Oct 2020 08:31:05 -0700 (PDT) MIME-Version: 1.0 References: <20201008154651.1901126-1-arnd@arndb.de> <20201008154651.1901126-9-arnd@arndb.de> In-Reply-To: From: Arnd Bergmann Date: Mon, 12 Oct 2020 17:30:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/13] m68k: m68328: use legacy_timer_tick() To: Geert Uytterhoeven X-Provags-ID: V03:K1:bE54Ob/HUphO95++8KP43Ve0YNQr1H6JTiloBp8qji9G6UXqjCF 0H7fgcCQ2vMpglUA2+ZbkSCTUnUkNXmQ5Bd9k7+yk25vn4pnhd/XfE8z4E8aVahFyfNNMdY AFf3uZfegfUd76hzwRttJRhqpN0F5Kj7q2T+kM0dODlCno0USUSEoA/n+y/2ZXSRX+0dKA2 xo3XGQb+prngj46QikmwA== X-UI-Out-Filterresults: notjunk:1;V03:K0:vf1F35Uea/c=:3l3U3lFJ7MLLf8JUWwofyN cqwo4I5ZwU54VTp3Exe16AeNcK5v+Ti7PV4xmBg8TNhgxDdgAc1Ew7fPDiscZUjNp6sDQxQSU DrNg6LTcniWjziXL0vkvHZJCDx6/sAVEpqBh3axCP7/gmnoelIQEsvXqTwyCI95UMjPkwmRK/ Mn8nOLw8chGhHjRanGercn9r/R6U/E3SeBMADfxtK90NWV5tSpDnOPGBLrt+9P3KjocBsSwLT cfgkGWls1uGCKH0GzaRNi7T4Wpevm3M8fsNEte2Bjrleag2NwRyzGAyGTrtffjq9d7cFKduUS z4hqXZyrWLkkmh0WPsjk6jEU+GKCUoXd+PsAAfnfaflgC7Se7G1Y3Oan1ZR1hPX78ThimsIdw 1Du9vcPOxlPyTZS5MCyxWjcA5fT/nLrpMdFtFq+OqFuTK7fHwEsjVEE9DaD94DOHCXabD8EtE 4fszelaEyGmp+COKzov4y6TzDzTuzjOUATrpVq+Tx3XQ6/D2yQ655G815l75OIBaQqePOd4x2 gSZzB6xhrHfyayTiGUUwY1CE+XZT7oryIhFAO7Ms1KRDgOyftQbv2arZSLRvJgWYlS5IVhPGd Ba9uCG8gIGlu9xvNXwMP1j2VvT9EuO4lSLWOVJlwRTRUBVkR81LcAG7Ygx4f2zrT6OWCe8reh kZwrP9JNbv7fp/Z+BvYpmjOHNDsFxULiy7fyUTyTsjsw0e9T0pAp3TGRucMb/q0CHI/IHGqIG 12w86qNnZo3WObdjL8buFoYcqW/TuimNoKwjnVmgWU7gPVcrvjvWYvtWnnjWnZK33h7KCWdzz XTcWjq+ui1lxIALqu+i2uiJRupYukxHqyn5+UOUi4wbJPkHRW22mU1ddk7wip2TnpIQzqJu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_113109_683559_2877B9A8 X-CRM114-Status: GOOD ( 18.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sam Creasey , Fenghua Yu , Linus Walleij , Tony Luck , "linux-ia64@vger.kernel.org" , Parisc List , Stephen Boyd , Helge Deller , Daniel Lezcano , Linux Kernel Mailing List , Finn Thain , Russell King , "James E.J. Bottomley" , linux-m68k , Thomas Gleixner , Linux ARM , John Stultz , Philip Blundell , Greg Ungerer , Joshua Thompson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 12, 2020 at 3:15 PM Geert Uytterhoeven wrote: > > Given this feature is SoC-specific, not platform-specific, perhaps > it makes sense to move the selects to the M68{,EZ,VZ}328 symbols? > > Regardless: > Reviewed-by: Geert Uytterhoeven Ok, folded in the change blow, using one less line. I couldn't figure out whether it should just be part of the CONFIG_M68000 instead, which doesn't appear to have any machine support by itself. The dragonball CPU configuration looks really odd, because you have to build exactly one of M68{,EZ,VZ}328 into the kernel to get a successful compilation, while Kconfig allows many other combinations. Arnd diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu index 322a35ef14c6..648054d4f860 100644 --- a/arch/m68k/Kconfig.cpu +++ b/arch/m68k/Kconfig.cpu @@ -104,6 +104,7 @@ config M68060 config M68328 bool "MC68328" depends on !MMU + select LEGACY_TIMER_TICK select M68000 help Motorola 68328 processor support. @@ -111,6 +112,7 @@ config M68328 config M68EZ328 bool "MC68EZ328" depends on !MMU + select LEGACY_TIMER_TICK select M68000 help Motorola 68EX328 processor support. @@ -118,6 +120,7 @@ config M68EZ328 config M68VZ328 bool "MC68VZ328" depends on !MMU + select LEGACY_TIMER_TICK select M68000 help Motorola 68VZ328 processor support. diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine index 0ff9338b958e..e3c835440d9a 100644 --- a/arch/m68k/Kconfig.machine +++ b/arch/m68k/Kconfig.machine @@ -146,7 +146,6 @@ config PILOT config PILOT3 bool "Pilot 1000/5000, PalmPilot Personal/Pro, or PalmIII support" depends on M68328 - select LEGACY_TIMER_TICK select PILOT help Support for the Palm Pilot 1000/5000, Personal/Pro and PalmIII. @@ -160,21 +159,18 @@ config XCOPILOT_BUGS config UCSIMM bool "uCsimm module support" depends on M68EZ328 - select LEGACY_TIMER_TICK help Support for the Arcturus Networks uCsimm module. config UCDIMM bool "uDsimm module support" depends on M68VZ328 - select LEGACY_TIMER_TICK help Support for the Arcturus Networks uDsimm module. config DRAGEN2 bool "DragenEngine II board support" depends on M68VZ328 - select LEGACY_TIMER_TICK help Support for the DragenEngine II board. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel