From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1045C10F0E for ; Mon, 15 Apr 2019 20:59:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD97620675 for ; Mon, 15 Apr 2019 20:59:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U9h6tqrB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD97620675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T1y3AxMQFFK/rJeQzVlYDlQc+Ii2kB1JSDtnhSk0JS0=; b=U9h6tqrBnSUPZh E2wuTB6PsgW+hI+Qa1K4iioM1wGwu0BUy35sp9mDslmTkD4kZhKuDxJRKfResjt8Y9ob24yCpOAch /3JARx88jWKZItfZnnl3CU0ZrH/7Vq28URmqCipv3dI8AEIqCwJsZFRlKkYs7wKaf69+Zz3bBr+Q5 Bqq3zUMumkZ1mNT5RYXQB8InG6+hns6f7603N946j1dxLQQiiQ1DiWOBXZd60/Bkwh6k3kOFEWs+j AeEgZZe9+p6h/6G4qEy2hjgZQtYigBsGcP/kWYYsmsPgvKW5Edz9QCUceMEUacTsVynPzEH/pvUeZ anWOK7T7/pEr38CwpYzw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG8h5-0000p7-Vc; Mon, 15 Apr 2019 20:59:11 +0000 Received: from mail-qt1-f196.google.com ([209.85.160.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG8h2-0000oj-ID for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2019 20:59:09 +0000 Received: by mail-qt1-f196.google.com with SMTP id v32so20844409qtc.10 for ; Mon, 15 Apr 2019 13:59:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yWLI9fj53wRY8kGJAGKGOER5dnhpxv64doRnZ2w70/I=; b=nLyUfaZXi1H9eaSUSoS3kSBdxrMbgMDLCRjG0doso/a3y2tilA9kgbs0B4Z1YoIJEK Fp8rb7Vi4Y/p48IumJSGV6r3HS6ZeEp6K1YTgM2MekhR3Wjq8wSSjvxgPRCgK3z9OY7k SZwtgYe31//Ah9RglBfin6/t8sKMuQ9lpPWztyleYv8Tc7ZqOtS+z4BpnsGf++3o+hfz 2B+ZGsu4IOYgYiXR7OMSQDy1mULc38Zeb8b7oBZFr9/Rr5obap2MP1FYQA5o1xu2asBd SFm7jMYJ9t9zbfBDNmeIHyKCULR/Nzg1j31s+3JzF0AdIXtdSWGmZjt9w31Kh57AnTmI Z+eQ== X-Gm-Message-State: APjAAAVe8Fzio+zY8qWz5qXCda91npWsfaC3zJQdKkoAP0U6Gcln2KsR wz7FAwxLhQ4z6aTBt9NHl6ZJD1a7/smqm4ZOMgk= X-Google-Smtp-Source: APXvYqy8ZsN8Q6/v0YbvEZ3xmFAf3qHJ3hXfOKmUu93cJ+qOftiqH9CQZI1RSvGFqANGIy0LfQpUI+72e/4yrn99mvg= X-Received: by 2002:a0c:f68a:: with SMTP id p10mr63318409qvn.126.1555361947405; Mon, 15 Apr 2019 13:59:07 -0700 (PDT) MIME-Version: 1.0 References: <20190415202501.941196-1-arnd@arndb.de> <20190415205410.GA31583@roeck-us.net> In-Reply-To: <20190415205410.GA31583@roeck-us.net> From: Arnd Bergmann Date: Mon, 15 Apr 2019 22:58:49 +0200 Message-ID: Subject: Re: [PATCH 1/6] ARM: ks8695: watchdog: stop using mach/*.h To: Guenter Roeck X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190415_135908_601277_5EDAA0E4 X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-watchdog@vger.kernel.org, Linus Walleij , Linux Kernel Mailing List , arm-soc , Greg Ungerer , Wim Van Sebroeck , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2019 at 10:54 PM Guenter Roeck wrote: > > > > > config KS8695_WATCHDOG > > tristate "KS8695 watchdog" > > - depends on ARCH_KS8695 > > + depends on ARCH_KS8695 || COMPILE_TEST > > Is __raw_readl / __raw_writel really available for all architectures / platforms ? I'm fairly sure it is these days, only uml and s390 used to be the exceptions here, but they both added this. It's possible that something else is missing, I was hoping for the 0-day bot to tell me if so. > > @@ -238,6 +237,11 @@ static struct miscdevice ks8695wdt_miscdev = { > > static int ks8695wdt_probe(struct platform_device *pdev) > > { > > int res; > > + struct resource *resource = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + > > + tmr_reg = devm_ioremap_resource(&pdev->dev, resource); > > Please use devm_platform_ioremap_resource(). Ah, that is the function I was looking for, thanks for the hint. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel