From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C62AC433EF for ; Mon, 6 Dec 2021 09:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9QbK331pIs0ZY5ldHOXz4ORAV7hnLWh9il2+poP1bDU=; b=ZS5ZWMGOWGBkqG kbY+T2xJUDZFF/aOAV3CzjClLNcfukGmrYd/rl+ex/PUqHQd57SHzERx+SSELmLqhL4KXn1jofypX +qIXBsuYzvGH1xfk0ryntJDWMox8WBPfL9XG11tf4uKl64MgfJ8ZDcyBmLW9A75+k94ZK5/cznWvD wPDXG7u8I2cnkd35jYn3e8TfbWYTSifU39s2l2mcJqNFwLdwtKq41AAAXNuYtnwd7H9CbKg1Ah2+e nSRnF6KeH2avP+4G1DNUoAa8j/s2Xq3vALYj9iOEAu3FQx51sFkKtLDsb/+DjtwqZkYoUq0PoPANT KnEB58bnFBBaFniIdbcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mu9qd-0034Vz-0x; Mon, 06 Dec 2021 08:59:47 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mu9qZ-0034Ue-8P for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 08:59:44 +0000 Received: from mail-wr1-f52.google.com ([209.85.221.52]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MowbA-1mDhju3Ipq-00qTgg for ; Mon, 06 Dec 2021 09:59:40 +0100 Received: by mail-wr1-f52.google.com with SMTP id v11so20830604wrw.10 for ; Mon, 06 Dec 2021 00:59:40 -0800 (PST) X-Gm-Message-State: AOAM531x7QAJ/6w5T5zlQ6mu6HdeZn0CnqKIUdMMDWHVWjfGf21aR0lp eedqSeqrtr2tsxWFjduA02tTmLn9/2nfvT8O9cY= X-Google-Smtp-Source: ABdhPJw8rKwPBIOecacswxTOKMMxeoiEmBfy+YFh9g4vDQi3JLiqejiVdE79PUY+07qh6BJ/4t1a2LtifJmZTf8goHw= X-Received: by 2002:a5d:64ea:: with SMTP id g10mr42126554wri.137.1638781180234; Mon, 06 Dec 2021 00:59:40 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Mon, 6 Dec 2021 09:59:24 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv5 3/4] tracing: Add register read/write tracing support To: Sai Prakash Ranjan Cc: Will Deacon , Catalin Marinas , Arnd Bergmann , Steven Rostedt , Marc Zyngier , gregkh , Linux Kernel Mailing List , Linux ARM , linux-arm-msm , quic_psodagud@quicinc.com, Prasad Sodagudi X-Provags-ID: V03:K1:txh4Q+kFrpR4cI5o0lBboO+otZGeeGKdE3cH3q9EJfHQiASmBhi +YuSuxGaWbqqPxibkZOg62T1odUImD7agvfwU6ggOZSQFETXFjKyR3NOLOl7KQVl/9XciMC 7B+QQEmoiEtaIXIgGe0asI1PWpuPvEZPS4MbkyKGoBJZze9baz1tmO9me2gEtfQR3zTLNVZ MJMEzAONIHQgIe6U0NEcw== X-UI-Out-Filterresults: notjunk:1;V03:K0:63uG6Tx8FVc=:EIAXmPT9t9rMBJVSfr3Kto 0ZxHumW6ZXGcHaCGToMeLl5F5Z2xfS+6peTaSoKzZDnVzgK5kmFhI6OPL8M4vGI3jkJmboqee 2mHGYl+2a3cMTBjxv67IsO/PNY+mXfKA3Or3F3/t71FPEZu3UGEmV5s+2xtBhrEZQZe3Eidg2 mqinSV1vtjoZj8ddrIeQSX/blJaTAnKNrov7I6A5A+LQPsCUprS7jalvERcHJ71F0XUgzTz/f h4tWi0Y0pM/1ckJKKv3gof63je+VAJZtitTdoioBPGaI6YCVQDPWPwjltYT1AZir5pEE7Rp6Q qkCAMY/Q0GtE68L2HbfBUBrLkxU7Ak2prRNQaltqaNuZc5YHqR5Zc5uEtI480t3OnLH7FHP7X RQr+3lVg4DHV+cD4af2IzLrgKVb3nG5lyj6yFpJ+JItyedSBp78ZThz1YWhIjifGsbwn13pgo zjW8bW8nw57aaL8EaheKnTl4C0iyzAsgewoauQ1S9iVJCghLFpfQzPqmhGIYD87z35zUx49AG lvVP5aQEIVC+3iWJx7jNA8zxNb2eRKx3tuUg38bS1IeDiWt32pSdSnTyRRvgOHtJ1kHk6jB2l mk03HJHsTLRUkHsWVsiQVTK0+D0UDHuU/aTJ3KZfXPQ1F2q7eCks4NOe1ZFR7qh+K+dD7hvd9 3NfLx7M9cGcaMhyyhBANPbLUzyVtNio4kgRoFGED1+8zdBBC6NKZ0nVyRoTf/u510XRqy8SbI ug2fvR3t/ecWN95wOTPxI2sgXacxyt3Q1ONZGTw/FfowdD787wpapjyP9K4yfrhx7fxXsH3sy /lgpYxEeQJly2w0NAtdb4ooWjoDxXwgncoisDIgfcP3bnOhasU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_005943_620699_1F202C1B X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 6, 2021 at 9:28 AM Sai Prakash Ranjan wrote: > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > index 420ff4bc67fd..9f55bcc51de1 100644 > --- a/kernel/trace/Kconfig > +++ b/kernel/trace/Kconfig > @@ -95,6 +95,13 @@ config RING_BUFFER_ALLOW_SWAP > Allow the use of ring_buffer_swap_cpu. > Adds a very slight overhead to tracing when enabled. > > +config TRACE_MMIO_ACCESS > + bool "Register read/write tracing" > + depends on TRACING > + help > + Create tracepoints for MMIO read/write operations. These trace events > + can be used for logging all MMIO read/write operations. I think this needs a 'depends on ARCH_HAVE_TRACE_MMIO_ACCESS' or similar. > +void log_read_mmio(u8 width, const volatile void __iomem *addr) > +{ > + trace_rwmmio_read(CALLER_ADDR0, CALLER_ADDR1, width, addr); > +} Here, it may be better to pass the caller address as an argument, I think CALLER_ADDR1 is not always reliable, though it's possible that it is in the configurations when this file gets enabled. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel