From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38456C433E1 for ; Thu, 23 Jul 2020 09:15:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0248D206F4 for ; Thu, 23 Jul 2020 09:15:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yZ1qQlga" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0248D206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fkrdU+1+Yu3QCSnvsfYkLAc4kQ1EEBFMBQL9aV4RHo0=; b=yZ1qQlgafggQ9eck6bpczh3vW Xy/uuW+LltbM60n2VG7bhR8iSwcS9mi/igW4zP7hjOBWObSjJPLE31x+zxOiXLpomAFUCT/F54XoL grmASNthU7+A76PPfm6G3VVhaaoWR4Gm0TaxXuq/7lDyrqvOJu9XN4QMQ9ZWlxW+2+A66SzNgZpIW YBGjmAh2JNbCmqyYzowRtPXrYnGrVRRNE/eDS7WCbnRvJKauzivoPXPoZAugCmjb6jaQltvS8twZG F/RKTgYGCj5gs+HdGzlxNwOfuZDHExQXeelrDKboschbaG97XXVZIHmV8/LMc3q8tDGrbccdDIfG5 YEjVXjh2A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyXJB-0004zC-Gk; Thu, 23 Jul 2020 09:14:34 +0000 Received: from mout.kundenserver.de ([212.227.126.131]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyXIz-0004w5-4J; Thu, 23 Jul 2020 09:14:21 +0000 Received: from mail-qk1-f174.google.com ([209.85.222.174]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MGiF0-1k3VNZ3cRe-00Dp3R; Thu, 23 Jul 2020 11:14:20 +0200 Received: by mail-qk1-f174.google.com with SMTP id u64so4638319qka.12; Thu, 23 Jul 2020 02:14:19 -0700 (PDT) X-Gm-Message-State: AOAM532UnD/IvJ2oSXr9nM5NWYBBF4MG/VqsfVm0Q0/ybh2VMeOtmktK ZBGYK3Tnw4ImDGYALRCu2yxHU1sSALq1xh/okcY= X-Google-Smtp-Source: ABdhPJyfIhx6eiKVKg4rHbAuRO6OkD2w5iLBrvPotu3J5hOQmvUiK3e54tHiHcXr7T/fRPeYMXzXCv1u/Kq2bJSXU54= X-Received: by 2002:a05:620a:1654:: with SMTP id c20mr4131860qko.138.1595495658635; Thu, 23 Jul 2020 02:14:18 -0700 (PDT) MIME-Version: 1.0 References: <20200723073744.13400-1-krzk@kernel.org> <20200723073744.13400-15-krzk@kernel.org> <20200723090230.GB25935@kozik-lap> In-Reply-To: <20200723090230.GB25935@kozik-lap> From: Arnd Bergmann Date: Thu, 23 Jul 2020 11:14:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 14/23] memory: ti-emif-pm: Fix cast to iomem pointer To: Krzysztof Kozlowski X-Provags-ID: V03:K1:SXjLvXjaCI/Q0rKi1pHUhwJnNRv7F8kYoA1hdyGZhvYWkodPfnZ /HKhWd2ERjvwcY4LAz/ttRFZFG/e1GNSJPAOzJFv95x8RfThfwkXXIuWf4jX2uIZJ/r9hTQ nkySXuWhdnP0wjf1D/apNEAVwtMGXVyXij1G+iPtDNLlMmSnty3CxUXXgwhIAe8onlHJyZT DdKSmVPd1ixfz+EgG2qsA== X-UI-Out-Filterresults: notjunk:1;V03:K0:76XzQ8eRDIc=:avBO96fCPnDiLKTs9Dw1N8 nr0crw5XNfz6PjYa/9HAQm6GZWU4yPYzw6BMI7NUwcSBb4uiBwbwIk/F8l5SvkeUakRU9SWTV +MMYDGM/sOB2fTkpf7cwc7Dvw7exUEmhRQJD/CFF/kAf2VYuCAI12ZPRkB1FmdTD3Kua1cX/4 St1i3JLmWiX9Yp6X+Se4HA2TF93L6t1yYqxe50PwN9uBDZ+TQqu7ZLzISxdAyuUgVDKPPw8oB k6WZmy+2o6EPcQTY3WK5BwYgGhTZaUqWR9tIvX9B4k6vURUOqq7BzrIWIKsC52CJPq76AoRd4 ev3DnWunvABI58ifcDPcs4IYISxFPcZD4Ixo9GEDVTLlNSSUZB5VFogrYERpuVP7iuczQp+mf EvPdXMPyphaGCvbkYnqLYGxHYcqtJ1+jcIE48F+Chjpwweca6tMYmh2OilhaIFbCAweEUnRMm oiGkMAamFYsfMF0RtruFRViUn2VEvY4K24/4YFSikZqpcvzSV7wZB5BTy/7vvAjgEXU/ZPiXT 8vOFns6z/jpP++67oZtUWgwK7Q0MBi8DLGYegKF5SKXKyQZToo/2kliWT/VuOtNdHzQY8jDqc n1vWYkyFF8+b8xmtsJOMZawEX1B0QIpBwagFVrhyq+tm5X0LTJKIgYiIihZueht/aLTrRqceE VMbrKOye41GPxr3WahRlh4w0FXocFT07F5kk+0sdkZE8iSO665+FXHbxdosusZJ3GiDaLbaia SiOtIAvLlzSCtdSC/Zl+kT1RRfpNAHHhw3pLD70Gwc4K1gxtMjYF5UwvjcgJY3zrnQ6vU+6Qa NiaQF1UWTuQFFXISMdegGmMKMaR7RK0Br8H2E7rBmw5pUMVjVtwVRpXtyNtUMHOw4kL3Btz2P c6gjtN3221V1ln5R495za2JApSIqN8CHuBXCgSboAmv/JDpIzV0sFpVtL19vxFg1c8AMo9q93 rRyXducmyCGIdnTBd1X7GRf/TBxlGKDC8UEV8k6tXrjIoiOjAun9X X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_051421_370933_9D334174 X-CRM114-Status: GOOD ( 24.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: Florian Fainelli , "open list:TEGRA ARCHITECTURE SUPPORT" , linux-omap , Tony Lindgren , Greg Kroah-Hartman , "moderated list:ARM/Mediatek SoC..." , "linux-kernel@vger.kernel.org" , Vladimir Zapolskiy , Matthias Brugger , SoC Team , arm-soc , bcm-kernel-feedback-list , Markus Mayer , Santosh Shilimkar , Olof Johansson , Thierry Reding , Andrew Morton , Jonathan Hunter , Linus Torvalds , Linux ARM , Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 23, 2020 at 11:02 AM Krzysztof Kozlowski wrote: > On Thu, Jul 23, 2020 at 10:48:19AM +0200, Arnd Bergmann wrote: > > On Thu, Jul 23, 2020 at 9:39 AM Krzysztof Kozlowski wrote: > > > > > > Cast pointer to iomem memory properly to fix sparse warning: > > > > > > drivers/memory/ti-emif-pm.c:251:38: warning: incorrect type in argument 1 (different address spaces) > > > drivers/memory/ti-emif-pm.c:251:38: expected void const volatile [noderef] __iomem *addr > > > drivers/memory/ti-emif-pm.c:251:38: got void * > > > > > > Signed-off-by: Krzysztof Kozlowski > > > --- > > > drivers/memory/ti-emif-pm.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/memory/ti-emif-pm.c b/drivers/memory/ti-emif-pm.c > > > index 9c90f815ad3a..6c747c1e98cb 100644 > > > --- a/drivers/memory/ti-emif-pm.c > > > +++ b/drivers/memory/ti-emif-pm.c > > > @@ -248,7 +248,7 @@ MODULE_DEVICE_TABLE(of, ti_emif_of_match); > > > static int ti_emif_resume(struct device *dev) > > > { > > > unsigned long tmp = > > > - __raw_readl((void *)emif_instance->ti_emif_sram_virt); > > > + __raw_readl((void __iomem *)emif_instance->ti_emif_sram_virt); > > > > > > > Maybe this shouldn't even be __raw_readl(), but instead READ_ONCE()? > > Won't readl() be enough? Indeed it looks problematic. readl() won't work on big-endian kernels, since this is a byte comparison. > > The other accesses in this file don't use MMIO wrappers either but just treat > > it as a pointer. The effect would be the same though. > > I think all the reads and writes are with readl() and writel(). I actually see only one other access: copy_addr = sram_exec_copy(emif_data->sram_pool_code, (void *)emif_data->ti_emif_sram_virt, &ti_emif_sram, ti_emif_sram_sz); and this one ends up in a memcpy() that does not perform any byte swapping or barriers. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel