From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE1ECC433DF for ; Mon, 6 Jul 2020 19:33:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E25F206B6 for ; Mon, 6 Jul 2020 19:33:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CeKre383" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E25F206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Oo8Ur8mkHWCDbVkRthh5COnjHGBJGtQnjQtc/mg0CFM=; b=CeKre383y4kPId6RJoOtzRN4b sFILq6Pq/YVefWoWgCzK/BzKWAOgILmEgd3mTO3PDKIUndNsH3gYUFLBDXHEwAqXFscIREEFLyKD/ EQLRWg+ycpkqcJrWyA2KyNM1QE01jPDa3x5UMwz/HFs7ebzLP0HcwHU/9ghCRxX+ecJgwRKYFGqje Zy7YDLypJAdgNUxa9YRuMVJ7xOQFmLXclnytCctMzuyjXBbh3f34UNVFHaHEaY7BCT6mvkRvy8zuA CQpSrCCs5FGu3+2F0wI3wdfpymdYKue7qw0c+MrIUvJ5aOqs1Z7ldhd3Eg9HnkK2v0A96ufypoZ7w TiPa4igNg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsWq8-0001ol-I9; Mon, 06 Jul 2020 19:31:44 +0000 Received: from mout.kundenserver.de ([212.227.126.133]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsWq6-0001oH-EN for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 19:31:43 +0000 Received: from mail-pg1-f175.google.com ([209.85.215.175]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1My6xz-1kqF5t2nHD-00zSfT for ; Mon, 06 Jul 2020 21:31:34 +0200 Received: by mail-pg1-f175.google.com with SMTP id z5so18843824pgb.6 for ; Mon, 06 Jul 2020 12:31:34 -0700 (PDT) X-Gm-Message-State: AOAM532raE3iRJFR6ME1KuxSLYTBezweKYMvymPmxqU1XB/MCijBpv5h f6tesJi9ckyoxhHnOE4QICahCMXE6W8ljLEs9/E= X-Google-Smtp-Source: ABdhPJx6C57ipwOmQE4z2Of7Gek+ncIUCG3FT8OvtojjLzSEhV2HK1GZTdXppjoYBjJd7UfRoOypxp0KRmbF9eXN6oY= X-Received: by 2002:a0c:ba0e:: with SMTP id w14mr48777681qvf.222.1594063442605; Mon, 06 Jul 2020 12:24:02 -0700 (PDT) MIME-Version: 1.0 References: <20200706165336.40800-1-sudeep.holla@arm.com> In-Reply-To: <20200706165336.40800-1-sudeep.holla@arm.com> From: Arnd Bergmann Date: Mon, 6 Jul 2020 21:23:46 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] firmware: arm_scmi: updates for v5.9 To: Sudeep Holla X-Provags-ID: V03:K1:b3XWZv0P8cGfTukkql403CVYrPnIy/aspeLkkELXmnb6ChSN9/h YtixJNUMHWT6mv+dOqI7mdkjVXmYbOuQWuF3Brh+uYuTIeBTyId5/GT9lD7Qgpz6QMHi5sY HsPwsy+QAHo6n46L8812TOLDONqNHux8xyv1yTaRC4OL/Pu212SJv1fmHsYvewmLIUkvit3 OkHjM5DgWSAPdfXQKW+EA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Azkmthfdpqo=:EgBM6jUw3gktCyfFxv56Rf WYT9IcHXrqDv29Lf4TRQ6H5/U+NuirmgKTitWfzauvkIb7mvZa5p9+Gw3tNTWzBK2gzcrgmxu Gfjw/C9oIV/10LfjeXNxbUkEC6n4dAtKTxSIlyfM8iWq8KIDKyb2JpvJoDn6Vyxj0RTXo7HDz UWI9l1pKTKxgKAHsgsmkSibWq5d3Kk3qqRnh8TqiPJ2e9wnahVecBoGFh7H7lxqgqFGti9ivh DO/91cby7fvKvyDlEbt9QXeK/Xmn3aTq8NI33Vb+7TFrRwA6pK/FAuYskGZJV5gpbUGqJb6yq k3Ex82vJmXx23aaOUF3ZkQNybPqahCq1zQZAiPLwgg+3rd1hywq/v222dCIJnZVBw6BXbpUkt BCYtPUV/g8qODcVVlXSzOasO2jMOjvpXsp2TBigKD+AhBMUkQyL3lathjKdyX4F6ksOknM/YE uMtDxvMYm3OM0+Ri1yHPgxW0Wh9DFDTltzOscjQ78qrPF5Ii/4EUtsJPtZp+xJzDdeMQ+4xTZ /4iXwdubTXmIXgx/wXcEkzfXkykYcVD2LgJEcW739/Wqpq3vkrF6Nx/VgvT8i/17BIUs1PHuo 3IRDZvqcJKwOi2WsQjc6Y4eLCjJ05OJZNPfO7fFHzfyfLJAFVFphuC+j6y1YGG0NbTLVdo0ay RPRsbmesOovcPovRNlutapaiJ7j8+DRIWcCwr6xH/aTs1A0TjW+GV6TtX4edw0kqrp0g0m8it nFAD54OWV3+REp9Y4GU5e2aBK1d/pE6H4SWu3ol3mEKJ1jkepT62OmfzeBbWF3vFAXK5zaVpf PMbPr1FmcZ/TmLCMsNcaG/O4+8HLXTadJ4y5i5sFpK6dIMG1bbiNTZ8nkpRkblhq8yzlk9YOK 3kdN8N7FpF2vj8k4CylDUaRkeZs7vfCIiGr65b5l+SZiVz1Dr5YLFae9Pk+7+AxnlMF9FW076 dhLSdqNknUJ+LNiZsMZ6Ggb/oWje0DU1D2JezS/L7huERfRKjdwWW X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_153142_728549_CB0E0F88 X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: Kevin Hilman , SoC Team , ARM SoC Team , ALKML , Olof Johansson , Cristian Marussi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 6, 2020 at 6:53 PM Sudeep Holla wrote: > > The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: > > Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git tags/scmi-updates-5.9 > > for you to fetch changes up to 585dfab3fb80e67b3a54790b3d5ef2991feb3950: > > firmware: arm_scmi: Add base notifications support (2020-07-01 17:07:26 +0100) > > ---------------------------------------------------------------- > ARM SCMI/SCPI updates for v5.9 > > The main addition for this time is the support for platform notifications. > SCMI protocol specification allows the platform to signal events to the > interested agents via notification messages. We are adding support for > the dispatch and delivery of such notifications to the interested users > inside the kernel. > > Other than that, there are minor changes like checking and using the > fast_switch capability quering the firmware instead of doing it > unconditionally(using polling mode transfer), cosmetic trace update and > use of HAVE_ARM_SMCCC_DISCOVERY instead of ARM_PSCI_FW. I haven't pulled this yet, as I noticed one data structure definition that seems very odd: struct scmi_event_header { u64 timestamp; u8 evt_id; size_t payld_sz; u8 payld[]; } __packed; This is an odd mix of fixed-length fields (u64) and variable length fields (size_t is different on 32-bit machines), out of which at least one is misaligned because of the __packed attribute. There are others that are just slightly odd: struct scmi_reset_issued_report { u64 timestamp; u32 agent_id; u32 domain_id; u32 reset_state; /* four bytes padding */ }; struct scmi_perf_level_report { u64 timestamp; u32 agent_id; u32 domain_id; u32 performance_level; /* four bytes padding */ }; struct scmi_base_error_report { u64 timestamp; u32 agent_id; bool fatal; /* 1 byte padding */ u16 cmd_count; u64 reports[0]; }; as this includes four implied padding bytes at the end. I could not figure out exactly what the guarantees for interface stability on either of them are, but if these get passed between the kernel and some other code (firmware or user space), or might be in the future, then I'd suggest redefining them in a way that avoids those oddities. Once this has been clarified, please just add any further patches (if needed) on top of the existing branch and send a new pull request. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel