From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 429F1C43381 for ; Tue, 5 Mar 2019 08:08:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A70520675 for ; Tue, 5 Mar 2019 08:08:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K6WJIOg9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A70520675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PFxbohP5+eohKVxHj1Z9knZsk+IBJd9WSA29uZe+tt4=; b=K6WJIOg9/rZfw5 UyUKnjYtvVQQ6VMrPm6VlMPPAuvd5bQvs/NcmWNel4mTG59+VIBVVedjrq/rs6Co6/fyxedZ70Zd6 w2jLXrlRRJgXC4QqRDpNVWmeqB38fsZVffHfidoPfeDbqViDxBkGVkbZKhkKzRk3pgAKTQJZUrhJj 5ml4aSVAX0B1IEZUqQdRRbIXgSTACRQjNICcJ1srRMLjSkcksZE3ggImONrAUzMT7cp+ogWrcv9xD 3XA4vB/9m5VnhZet9oxMQ+Fa0MANHJqA60XBxfH52ml7EG9CjJGYWrRbOHdCnDuls0Tv6RNBJumCN wy1sZYIBuXRCiTlpNzog==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h157v-0005eG-Pq; Tue, 05 Mar 2019 08:08:39 +0000 Received: from mail-qt1-f195.google.com ([209.85.160.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h157s-0005dQ-3P for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 08:08:37 +0000 Received: by mail-qt1-f195.google.com with SMTP id d2so8079699qti.11 for ; Tue, 05 Mar 2019 00:08:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M8v7zZkltHYID9X6fdHbQ/sOeMYjmQWw7u4arJ0KXMA=; b=AK3qkGKcaPgVYUbZrCYVny/y538zFnQ6zL4EIk52Us9jwh79MlsrzY5454OhCiDNQP A1RiKIDRRXYdP17drgPwfq5HxyIvdgU6He9v3wRgkOhk8kLKhdch6acg5Xmvqwd58+jZ u4TXR3ALvcMS01XE4eaevBNDYadlS3IpmEjJlAjPtgYNC/gTebHPC2F+vh/2OLwuFB6j r61r67imKjFI7cz2Ogorzyyq3koMOZyaTPcv1CcdXuEuOnV+1Bh2/oZiEvjyOHLCji9d S97P3Prs50Vrb9rz880CyDMWvsHKsquh55QbMCM92j53F6XpQGiyJy+1oRwOKlFhFTS8 mZOw== X-Gm-Message-State: APjAAAU8mr5M/V4J4cVL/5FIHwkJ+DR1Ix5wTuAfXPsJuzhXgZ50u3cA oCs9E+0uQGrDwyHuKoK7fUcBN2/Z3X2E2tkfxgA= X-Google-Smtp-Source: APXvYqw4nxUS0BNouWVlry6aqzokLlalHS9xjJbQDxU4h6a8F+f8+3iW3JAZ41Cqvn4OFUmgrfBPbqiSXIzH2NfsYBI= X-Received: by 2002:a0c:81ee:: with SMTP id 43mr1091630qve.180.1551773314636; Tue, 05 Mar 2019 00:08:34 -0800 (PST) MIME-Version: 1.0 References: <20181218093630.io6p4ovl36hnxalk@laureti-dev> <20181218100908.GL26090@n2100.armlinux.org.uk> <20181218132146.GA20197@arrakis.emea.arm.com> <4b1af546-fb8c-f52a-1a39-ee265e7f410a@oracle.com> <20190304222851.GB36459@C02TF0J2HF1T.local> In-Reply-To: From: Arnd Bergmann Date: Tue, 5 Mar 2019 09:08:18 +0100 Message-ID: Subject: Re: ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! To: Boris Ostrovsky X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_000836_142932_C84F2C9A X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Helmut Grohne , Catalin Marinas , Will Deacon , Russell King - ARM Linux , Paul Durrant , Ben Hutchings , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 4, 2019 at 11:49 PM Boris Ostrovsky wrote: > On 3/4/19 5:28 PM, Catalin Marinas wrote: > > On Mon, Mar 04, 2019 at 05:04:10PM -0500, Boris Ostrovsky wrote: > >> On 12/18/18 8:21 AM, Catalin Marinas wrote: > >>> On Tue, Dec 18, 2018 at 10:09:09AM +0000, Russell King wrote: > >>>> On Tue, Dec 18, 2018 at 10:36:32AM +0100, Helmut Grohne wrote: > >>>>> During a compile test of v4.20-rc7 for armhf (cross build), I > >>>>> encountered: > >>>>> > >>>>> ERROR: "__sync_icache_dcache" [drivers/xen/xen-privcmd.ko] undefined! > >>>>> > >>>>> Some searching brought up c5157101e77 ("arm64: mm: Export > >>>>> __sync_icache_dcache() for xen-privcmd"), which fixes a very similar > >>>>> problem for arm64. Is that commit maybe also needed for arm? > >>>> I would rather not export that function for drivers to abuse. > >> (I am reviving this thread because Arnd submitted a patch to work around > >> this issue > >> https://lore.kernel.org/lkml/20190304204826.2414365-1-arnd@arndb.de/ ) > >> > >> Even when the same routine in arm64 is exported for this very reason? > >> > >> The patch above it going into a lot of trouble to make things work so I > >> am hoping this can be re-considered. > > It's Russell's decision whether to export this or not for arch/arm/. > > OK, I didn't realize there are different maintainers for arm and arm64. > > In any case, the main reason I am asking this question is because the > two architectures have different policies for (what appears to me) a > very similar interface. If __sync_icache_dcache() is kept private in > arm, should then c5157101e77 be reverted (assuming Arnd's patch goes in)? I don't think it make much of a difference. All callers are in the arch/, mm/, drivers/xen, and fs/dax, and this is the only one that can currently be a module, so I don't think we would need it otherwise. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel