linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Will Deacon <will@kernel.org>
Cc: "tan.shaopeng@fujitsu.com" <tan.shaopeng@fujitsu.com>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	SoC Team <soc@kernel.org>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	Olof Johansson <olof@lixom.net>,
	 "misono.tomohiro@fujitsu.com" <misono.tomohiro@fujitsu.com>,
	James Morse <james.morse@arm.com>
Subject: Re: [PATCH RFC] soc: fujitsu: Add cache driver code
Date: Thu, 4 Mar 2021 11:58:28 +0100	[thread overview]
Message-ID: <CAK8P3a2pFcNTw9NpRtQfYr7A5OcZ=As2kM0D_sbfFcGQ_J2Q+Q@mail.gmail.com> (raw)
In-Reply-To: <20210304104650.GA20843@willie-the-truck>

On Thu, Mar 4, 2021 at 11:46 AM Will Deacon <will@kernel.org> wrote:
> On Thu, Mar 04, 2021 at 10:34:43AM +0000, tan.shaopeng@fujitsu.com wrote:
> > > On Wed, Mar 3, 2021 at 10:38 AM tan.shaopeng
> > > <tan.shaopeng@jp.fujitsu.com> wrote:
> > > > +
> > > > +config FUJITSU_CACHE
> > > > +        tristate "FUJITSU Cache Driver"
> > > > +        depends on ARM64_VHE || COMPILE_TEST
> > > > +        help
> > > > +          FUJITSU Cache Driver
> > > > +
> > > > +          This driver offers cache functions for A64FX system.
> > > > +         Loading this cache driver, control registers will be set to enable
> > > > +         these functions, and advanced settings registers will be set by
> > > default
> > > > +         values. After loading this driver, you can use the default values of
> > > the
> > > > +         advanced settings registers or set the advanced settings registers
> > > > +         from EL0. Unloading this driver, control registers will be clear to
> > > > +         disable these functions.
> > > > +          When built as a module, this will be called as "fujitsu_cache".
> > >
> > > My feeling is that this code should be in arch/arm64/, as the cache
> > > is generally considered part of the CPU, rather than part of the wider
> > > SoC design, or something that can be controlled separately from the
> > > core kernel and memory management code.
> >
> > Thanks for your advice. I also would like to hear the opinions from
> > other soc&arm maintainers, and then consider whether to add this to
> > arch/arm64/.
>
> Given that all of this is outside of the scope of the architecture, I don't
> think that arch/arm64/ is the right place for it. Perhaps this would fit
> into the resctrl rework that James has been doing for MPAM?

Indeed, that sounds like a good starting point. I don't understand enough
about either of the two to be sure, but it sounds like there is some overlap
in functionality, and ideally we would have one user interface that can
deal with all the hardware implementations (intel, arm, fujitsu and any
future ones).

      Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-04 11:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03  9:38 [PATCH RFC] Upstream A64FX cache driver tan.shaopeng
2021-03-03  9:38 ` [PATCH RFC] soc: fujitsu: Add cache driver code tan.shaopeng
2021-03-03 11:24   ` Arnd Bergmann
2021-03-04 10:34     ` tan.shaopeng
2021-03-04 10:46       ` Will Deacon
2021-03-04 10:58         ` Arnd Bergmann [this message]
2021-03-05  7:48           ` tan.shaopeng
2021-03-31  8:52           ` tan.shaopeng
2021-04-01 16:15             ` James Morse
2021-04-02  8:44               ` tan.shaopeng
2021-03-04 10:54       ` Arnd Bergmann
2021-03-05  8:10         ` tan.shaopeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a2pFcNTw9NpRtQfYr7A5OcZ=As2kM0D_sbfFcGQ_J2Q+Q@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=misono.tomohiro@fujitsu.com \
    --cc=olof@lixom.net \
    --cc=soc@kernel.org \
    --cc=tan.shaopeng@fujitsu.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).