From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A16DC433B4 for ; Fri, 14 May 2021 19:35:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE25B6145A for ; Fri, 14 May 2021 19:35:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE25B6145A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G/xDWWDUOp4ujk1jA2rYGVzqWWOhl3pSoYiaoLW8u/o=; b=IEWGVQ5iQATRmYosAwSG0hP4+ B1PVeMZzee9mazgYjk9+L7/1t6+8O017poQTuvINeGHhR+DV0dqe37A+2dUc0qdc0oueu/Ejg+MXy zZStmXEWT1FYudUtrhfDCMzYalCqtGwd1V3BRKSK+ZV7W0uu73L07vBcYmjWnuzn3lTYyeibijCH6 tHDb5atRPT970I+BX81jpFpUvQOEGKJodFqijuMA4Xx0SxOn416/ic+P51HLCe61lwQjG5EezBmP1 UcIDklDTFJ1aV9ijaw2MvhIK5/n8GhEWI74y1ShsAxYorM2xFXtRUedOMlyOu+7b05yjlV6SYfI/Q UWNdwTLwA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhdYr-008qdg-3G; Fri, 14 May 2021 19:33:25 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhdYj-008qcF-8x for linux-arm-kernel@desiato.infradead.org; Fri, 14 May 2021 19:33:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ClftVL+uGmfhXtudCjQvEaJc412LM7r2LFw66XZm3oI=; b=C1pzR8yzTyUjDXn7DK+Dkc27W+ Rn70VHnukivWP0VIqpFTbwimrjwXqOAltLZ6q9NXPU2Xs2B9N2Vo7dLRwOn0VNvsHnqyzUGwFVxpd Qj8bLwxCtJXnX0dlmfIr+B/frsUFV0T0X5L34QXYNYYrkZCQ/g5pyhQ/da0CHHd7wg3Kd5IXKj7/s eJF1cgc/FDM11x+tJKRaJql9aDAFHiHTRv1hKZfpSlguWv6BDKx4nK+HU01/fk+4Bl44oFauUKNCL rQlBVUqk/PFDzsEsd6eHPXClPYmwRw0Z0VuXM9Lm41yMGtVRek6BkTX1+Fb+ezor1jdRVnOGEd319 2O9R1IvQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhdYg-00CDCa-I5 for linux-arm-kernel@lists.infradead.org; Fri, 14 May 2021 19:33:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 30C676147F for ; Fri, 14 May 2021 19:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621020794; bh=sx6RnRTXG/HkUYbZ66bme4Ihr6YCIRDKjve7uvyFxHE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=SdqSke8IaGMvUEeTe71zk1Hd28gwlDENetQe7k7Co66h23vRCRl1KPsodwwWVdhKE dvYpB/evTd7XXke5L3mNIMCb5pyrjckv1uAHT7B03ZI+6Q8VhW0fyme343G7sIOz2d srEQlIDyrnWkqm3qvfgk1LIwQGEN2ieFg2BhbrW1xznGLIUCqElPii6G++r1B9Gdlu RpHn4yyP32nYfFEo1EHqIXv/0flEjUdCxBwXURiO9O+8/CgEAeziclDuLs+j6NXhQI +PGgdKis35+IFsUe1OslqhfbMRZRI1o7OMfcrju6a0P+zV4d7W3cQbZRjeRJT+esmf LxDvDYAi5VP7Q== Received: by mail-lj1-f175.google.com with SMTP id p20so15151283ljj.8 for ; Fri, 14 May 2021 12:33:14 -0700 (PDT) X-Gm-Message-State: AOAM530Jr+/rHA84yQtXmOgxc9a0N9HsbRkVa1YS/2+Fr2dgXxCpMfjP PkVI3BSRwkdBMKg20MzKFuUcSNKd+9QGPyqAUBQ= X-Google-Smtp-Source: ABdhPJwCQ1F0CBUPxIsNYOfoW01L5a5C+nTIh8ZsdXu8MlaXBtReQ+mP8NigDxBA9czvxj+u/ONPbc8umn+Z9hfl/zY= X-Received: by 2002:a5d:6dc4:: with SMTP id d4mr62128225wrz.105.1621020781452; Fri, 14 May 2021 12:33:01 -0700 (PDT) MIME-Version: 1.0 References: <20210514100106.3404011-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Fri, 14 May 2021 21:31:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/13] Unify asm/unaligned.h around struct helper To: Linus Torvalds Cc: linux-arch , Vineet Gupta , Amitkumar Karwar , Benjamin Herrenschmidt , Borislav Petkov , Eric Dumazet , Florian Fainelli , Ganapathi Bhat , Geert Uytterhoeven , "H. Peter Anvin" , Ingo Molnar , Jakub Kicinski , James Morris , Jens Axboe , John Johansen , Jonas Bonn , Kalle Valo , Michael Ellerman , Paul Mackerras , Rich Felker , "Richard Russon (FlatCap)" , Russell King , "Serge E. Hallyn" , Sharvari Harisangam , Stafford Horne , Stefan Kristiansson , Thomas Gleixner , Vladimir Oltean , Xinming Hu , Yoshinori Sato , "the arch/x86 maintainers" , Linux Kernel Mailing List , Linux ARM , linux-m68k , Linux Crypto Mailing List , Openrisc , linuxppc-dev , Linux-sh list , linux-sparc , linux-ntfs-dev@lists.sourceforge.net, linux-block , linux-wireless , Netdev , LSM List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_123314_645392_512A1713 X-CRM114-Status: GOOD ( 21.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 14, 2021 at 7:32 PM Linus Torvalds wrote: > > On Fri, May 14, 2021 at 3:02 AM Arnd Bergmann wrote: > > > > I've included this version in the asm-generic tree for 5.14 already, > > addressing the few issues that were pointed out in the RFC. If there > > are any remaining problems, I hope those can be addressed as follow-up > > patches. > > This continues to look great to me, and now has the even simpler > remaining implementation. > > I'd be tempted to just pull it in for 5.13, but I guess we don't > actually have any _outstanding_ bug in this area (the bug was in our > zlib code, required -O3 to trigger, has been fixed now, and the biggy > case didn't even use "get_unaligned()"). > > So I guess your 5.14 timing is the right thing to do. Yes, I think that's best, just in case something does come up. While all the object code I looked at does appear better, this is one of those areas that can be hard to pinpoint if we hit a regression in a particular combination of architecture+compiler+source file. I have pushed a signed tag to https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git asm-generic-unaligned-5.14 and plan to send that in the 5.14 merge window unless you decide to take it now after all. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel