From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EBBCC4740A for ; Mon, 9 Sep 2019 13:45:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01D2F218AF for ; Mon, 9 Sep 2019 13:45:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QIf2ZBRA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01D2F218AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SQAJ8f4lA+DDQFRi5euuoQqitc/cYnj1EwNEd4kdvs8=; b=QIf2ZBRAZpIyYg RUvB3JsI2rUQvXm+/zGaUXj0JzkppjswAewz7vVsnRDs6vWfBIWsePbMOV+8j+zeWMq+bu75j3CNG 9VvEPGZquNcGMmZOosqoyiIFY3SDL7S3DAdz5UbtguIauGJancHr6Gkci4udfvQ8G/eFDnJUGrA06 3xx4Gh8CE1uwM1/SeYDZgB7J/sLdR+kUkIHY7kG15aqXC0Y9UMybOWJqeYWxEDWWyJMgFZktIuDZZ U3REajrRqgxD+3NGkyfYNg63OImx/RcOm+aflgJrAqj3PwZZDbJrfJ1s57O19FURjGh2WRQIvfPq2 tWk81sGWMKGPP/0JmCPQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i7Jz9-0001cd-PM; Mon, 09 Sep 2019 13:45:39 +0000 Received: from mail-qt1-f193.google.com ([209.85.160.193]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i7Jz6-0001c2-81 for linux-arm-kernel@lists.infradead.org; Mon, 09 Sep 2019 13:45:37 +0000 Received: by mail-qt1-f193.google.com with SMTP id j10so16152081qtp.8 for ; Mon, 09 Sep 2019 06:45:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xDjWmrpelBMsV8acnAMsSy3b05LWkf2FcGFKigsCXs8=; b=gVXtSRXk6bgQYPj16XMozSm6CFa5VEl8Y9+kuhno/rTUtzZ2W3DQO0Xq2buQQWHt1b F/89OkBhyl/alg8fdVVOxurKHYJJRKxjEpT8mL4db482HbHkLcwmqyYoTpN0EvFZ7pRI 12AJA5mgHjyR5m1ZCcUHHpVGvbhaGxcTLSu8Bd7F7AAL+YIDzmupkOaML7HuZOF2qZp0 t9YBnaswujqwvlqfzSth86RWTBThsptVidL6sAugs2fvgu5VN5hW84P7of/KTfdZp/nX 3f6upL6CJzXedmsj0Jqhaio5SDNSOIzXIUuIWnbVXBrMbIp0O3Aq78Xym9WZ5UYvVxo1 W/6A== X-Gm-Message-State: APjAAAVdHyQj1o/RPYhFT3FVgwrb9oH3lmEjO1TJVq5jKwFm6QXMH5TP Vjz6hhkPplVW6IEOLOyxT9cf028fkPdfwldZ1DA= X-Google-Smtp-Source: APXvYqy6uMINd7bjqrBIpL+FlSlRZCnr6jDIP9BcfsScpej8dgHINCuOakM78zZlQ2S5h2RBKY29EifUZf3k9t5zUQM= X-Received: by 2002:ac8:6b1a:: with SMTP id w26mr22956448qts.304.1568036734738; Mon, 09 Sep 2019 06:45:34 -0700 (PDT) MIME-Version: 1.0 References: <1568020220-7758-1-git-send-email-talel@amazon.com> <1568020220-7758-4-git-send-email-talel@amazon.com> In-Reply-To: From: Arnd Bergmann Date: Mon, 9 Sep 2019 15:45:18 +0200 Message-ID: Subject: Re: [PATCH 3/3] arm64: alpine: select AL_POS To: "Shenhar, Talel" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190909_064536_284762_F06BD2E1 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , mjourdan@baylibre.com, Catalin Marinas , Linus Walleij , "linux-kernel@vger.kernel.org" , jonnyc@amazon.com, Mauro Carvalho Chehab , ronenk@amazon.com, Will Deacon , Benjamin Herrenschmidt , DTML , Maxime Ripard , Rob Herring , Santosh Shilimkar , Thomas Gleixner , hanochu@amazon.com, Linux ARM , barakw@amazon.com, hhhawa@amazon.com, gregkh , paul.kocialkowski@bootlin.com, Patrick Venture , Olof Johansson , David Miller , David Woodhouse Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 9, 2019 at 12:17 PM Shenhar, Talel wrote: > On 9/9/2019 12:40 PM, Arnd Bergmann wrote: > > On Mon, Sep 9, 2019 at 11:14 AM Talel Shenhar wrote: > >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > >> index 4778c77..bd86b15 100644 > >> --- a/arch/arm64/Kconfig.platforms > >> +++ b/arch/arm64/Kconfig.platforms > >> @@ -25,6 +25,7 @@ config ARCH_SUNXI > >> config ARCH_ALPINE > >> bool "Annapurna Labs Alpine platform" > >> select ALPINE_MSI if PCI > >> + select AL_POS > >> help > >> This enables support for the Annapurna Labs Alpine > >> Soc family. > > Generally I think this kind of thing should go into the defconfig > > rather than being hard-selected. There might be users that > > want to not enable the driver. > > The reason for selecting it is because this is a driver that we will > always want for ARCH_ALPINE. Can you put the exact requirement (other than "we want this") in the changelog text then? It's still not clear to me what breaks without this driver. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel