From: Arnd Bergmann <arnd@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jose Abreu <joabreu@synopsys.com>,
punit1.agrawal@toshiba.co.jp,
Alexandre Torgue <alexandre.torgue@st.com>,
DTML <devicetree@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jakub Kicinski <kuba@kernel.org>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
yuji2.ishikawa@toshiba.co.jp,
"David S . Miller" <davem@davemloft.net>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver
Date: Mon, 15 Feb 2021 13:19:18 +0100 [thread overview]
Message-ID: <CAK8P3a391547zH=bYXbLzttP9ehFK=OzcM_XkSJs92dA1z4DGQ@mail.gmail.com> (raw)
In-Reply-To: <YCo9WVvtAeozE42k@unreal>
On Mon, Feb 15, 2021 at 10:23 AM Leon Romanovsky <leon@kernel.org> wrote:
> On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote:
> >
> > Sorry, I sent the wrong patchset that didn't fix this point out.
> >
> > > I asked it before, but never received an answer.
> >
> > I have received your point out and have sent an email with the content
> > to remove this line. But it may not have arrived yet...
> >
> > > Why did you use "def_bool y" and not "default y"? Isn't it supposed to be
> > > "depends on STMMAC_ETH"? And probably it shouldn't be set as a default as "y".
> > >
> >
> > The reason why "def_bool y" was set is that the wrong fix was left when
> > debugging. Also, I don't think it is necessary to set "default y".
> > This is also incorrect because it says "bool" Toshiba Visconti DWMAC
> > support "". I change it to trustate in the new patch.
> >
> > And this driver is enabled when STMMAC_PLATFORM was Y. And STMMAC_PLATFORM
> > depends on STMMAC_ETH.
> > So I understand that STMMAC_ETH does not need to be dependents. Is this
> > understanding wrong?
>
> This is correct understanding, just need to clean other entries in that
> Kconfig that depends on STMMAC_ETH.
'tristate' with no default sounds right. I see that some platforms have a
default according to the platform, which also makes sense but isn't
required. What I would suggest though is a dependency on the platform,
to make it easier to disable the front-end based on which platforms
are enabled. This would end up as
config DWMAC_VISCONTI
tristate "Toshiba Visconti DWMAC support"
depends on ARCH_VISCONTI || COMPILE_TEST
depends on OF && COMMON_CLK # only add this line if it's
required for compilation
default ARCH_VISCONTI
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-15 12:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 5:06 [PATCH v3 0/4] net: stmmac: Add Toshiba Visconti SoCs glue driver Nobuhiro Iwamatsu
2021-02-15 5:06 ` [PATCH 1/4] dt-bindings: net: Add DT bindings for Toshiba Visconti TMPV7700 SoC Nobuhiro Iwamatsu
2021-02-15 5:06 ` [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver Nobuhiro Iwamatsu
2021-02-15 6:07 ` Leon Romanovsky
2021-02-15 7:28 ` Nobuhiro Iwamatsu
2021-02-15 9:22 ` Leon Romanovsky
2021-02-15 12:19 ` Arnd Bergmann [this message]
2021-02-15 15:20 ` Nobuhiro Iwamatsu
2021-02-15 15:14 ` Nobuhiro Iwamatsu
2021-02-15 5:06 ` [PATCH 3/4] MAINTAINERS: Add entries for Toshiba Visconti ethernet controller Nobuhiro Iwamatsu
2021-02-15 5:06 ` [PATCH 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 " Nobuhiro Iwamatsu
-- strict thread matches above, loose matches on Subject: below --
2021-02-10 16:29 [PATCH 0/4] net: stmmac: Add Toshiba Visconti SoCs glue driver Nobuhiro Iwamatsu
2021-02-10 16:29 ` [PATCH 2/4] " Nobuhiro Iwamatsu
2021-02-11 22:13 ` David Miller
2021-02-12 0:29 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a391547zH=bYXbLzttP9ehFK=OzcM_XkSJs92dA1z4DGQ@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=peppe.cavallaro@st.com \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).