From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F0EECE587 for ; Tue, 1 Oct 2019 18:58:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 691BE20B7C for ; Tue, 1 Oct 2019 18:58:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fzKXFhAK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 691BE20B7C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zqk3qOhV5SU5O3Hsu8KIT3k9vTTSzTtHcv7Iups4RYU=; b=fzKXFhAKq2ikie 2Om5Vzc0tvuv7KAThE+R9wxBszDs2Z4iK8sMBXmLPHmPXdGJ6etB8Cm4ZJZ5Uuy5bShv3oQ3TgnhY Z4pd6eFfdRVWqbCeNdVNuU4nl4U9EbJ9hYoPOsZLkFZNr72RN9wVf7j42K0NAyPL+xjSSZ8V7FrxM amtmFCGXXTxKqdQPHv6G6NIhffWf/cJoX79ns9Cn1ZQPZZDhnV6p7zITC+2iC3erqvAQwV73Ccqkd 5zI4ssKvY+DZ4M+yEXQpHv8kmLc/vt1TPw8j7x57SBS58RYiahCv18XyNg+yJczB5nHEe98joW+P+ Yja4Kz8T1zVnDi9lR8dQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFNLd-0006JO-MP; Tue, 01 Oct 2019 18:58:09 +0000 Received: from mail-qk1-f194.google.com ([209.85.222.194]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFNLa-0006Ir-93 for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2019 18:58:07 +0000 Received: by mail-qk1-f194.google.com with SMTP id f16so12322614qkl.9 for ; Tue, 01 Oct 2019 11:58:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7EY66jo6PvKaSsJh31JkxqgQFmjMunJ0Kvj/PM6tpU0=; b=MlgA9zKYNc7EXODfDnSryPQ0Us9CSlNQ1D7AINUwPjVBWJ5o9yevSGyxL2D6OwcAQY tewY68XxThG8llxsdbrIoXEDcxZ+gEP9yoGLUb7qHk+OypKhtO7NNyByct2BSoUdTgmv xaAs1Eg/T/sUohnhS/fK2XVdY+LDELIgZykrhWwurejHJNUlT8ScS1fo9YxUpa4G4ZXI aWWftxCTgEnexBZ9Zo3Rz+O7i9MVPq3aJO/6gUeLMpAwXLAi9F+Mc9rI68sIJEmCBtYV UVh+TzNmnBdRtIyuxpBz/ucgOq6FKTKLXgF+5008NR33+gVC4qLkaxTU0XIhzyJuJ1xZ V9vQ== X-Gm-Message-State: APjAAAXz8axavnhJSsXJbSEsCwRh8AIFUihjCZh/W7ZGGxfF4UWpCEN8 dgZDo+P1CY13p5m9vmAMzrRpepIHTt8qBk6wFzz9BQw/ X-Google-Smtp-Source: APXvYqyDB8xPt1kofeJ9vy4DjGVaLfhn0UKXBeJHpGI6/IjnKwTQqHsuDY0fC/wEA0lObfyGUxpteBLFU4gleCtca20= X-Received: by 2002:a37:a858:: with SMTP id r85mr7732418qke.394.1569956285225; Tue, 01 Oct 2019 11:58:05 -0700 (PDT) MIME-Version: 1.0 References: <20190906153948.2160342-1-arnd@arndb.de> In-Reply-To: From: Arnd Bergmann Date: Tue, 1 Oct 2019 20:57:49 +0200 Message-ID: Subject: Re: [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function To: Stefano Stabellini X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191001_115806_319496_5B071093 X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Emil Velikov , Russell King , Denis Efremov , "linux-kernel@vger.kernel.org" , Masahiro Yamada , xen-devel , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 1, 2019 at 7:38 PM Stefano Stabellini wrote: > Thank you for the patch. HYPERVISOR_platform_op() is an inline function, > the underlying function that should be exported is > HYPERVISOR_platform_op_raw. So, instead of removing > HYPERVISOR_platform_op, we should change it to > HYPERVISOR_platform_op_raw. Ok, that makes sense. > For convenience, and for testing I cooked up a patch. Arnd, if you are > happy with it (in the sense that it solves your problem) we'll check it > in the xentip tree, unless you would like to get it in your tree? > Please merge it through your tree. > @@ -437,7 +437,7 @@ EXPORT_SYMBOL_GPL(HYPERVISOR_memory_op); > EXPORT_SYMBOL_GPL(HYPERVISOR_physdev_op); > EXPORT_SYMBOL_GPL(HYPERVISOR_vcpu_op); > EXPORT_SYMBOL_GPL(HYPERVISOR_tmem_op); > -EXPORT_SYMBOL_GPL(HYPERVISOR_platform_op); > +EXPORT_SYMBOL_GPL(HYPERVISOR_platform_op_raw); > EXPORT_SYMBOL_GPL(HYPERVISOR_multicall); > EXPORT_SYMBOL_GPL(HYPERVISOR_vm_assist); > EXPORT_SYMBOL_GPL(HYPERVISOR_dm_op); Note that there are obviously no callers from any loadable modules in the kernel, all users are in built-in code at the moment. As an API definition it still makes sense though. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel