From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1C32C433F5 for ; Tue, 21 Dec 2021 14:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3ciBcM2+Hix2ixB6xboGHLpk1qc9jz2paAg7+hZ/mxM=; b=ugcv/s3FpFt2rK 6p8bvVdcVPBVCA5Dd761DXh8WH99mOIzpixDuiyyitk8EqNYqL86dHdXqHJQk2Az5pVpbz9s2q4Ug w/A4EB5I6p/TkrzcS+tZufblqUz0sSpUE+zzkl+P5SS+aEKV9boXmPtiFrjORaozsipFbXTbI0V1C T6T52PDmF+L2AgMk87WZiSKMmaQPNQzlNWkG5q6nasHljfgZpFOZnX+61VOicuFKkO8TmJFxqjO2+ EsvYjZ6spqComYE8gOeSo5Re4YNFw8fCVO650t4y/mQKJs3yxOhkOOgpaNKZQ7Q1ABE0RZH2Ni5MG RsbzsO9YHoTm13n7jcdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzfmw-0074SC-3X; Tue, 21 Dec 2021 14:06:46 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzfms-0074RI-Ft for linux-arm-kernel@lists.infradead.org; Tue, 21 Dec 2021 14:06:44 +0000 Received: from mail-wr1-f47.google.com ([209.85.221.47]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N7zW7-1mM9sR3WV9-0151ez for ; Tue, 21 Dec 2021 15:06:40 +0100 Received: by mail-wr1-f47.google.com with SMTP id e5so27155094wrc.5 for ; Tue, 21 Dec 2021 06:06:40 -0800 (PST) X-Gm-Message-State: AOAM533cO6lq046IdrpNrNz+maiJFyopyM6c+F9H27elkMQy5TkGi5BN KsaoSmIqOFB5pBSToJf2AQ3S1hAow31JqysJe3o= X-Google-Smtp-Source: ABdhPJyzvQ/1QAK1GqHOaaSnEoVf7yge/oTnq2f+7MJ+Itino1uirIiewhJO40OrvktYWj5bEn5HdqsDGLHkkhTqttQ= X-Received: by 2002:a5d:6d0e:: with SMTP id e14mr2899826wrq.407.1640095600018; Tue, 21 Dec 2021 06:06:40 -0800 (PST) MIME-Version: 1.0 References: <20211220211854.89452-1-nbd@nbd.name> <20211220211854.89452-8-nbd@nbd.name> In-Reply-To: <20211220211854.89452-8-nbd@nbd.name> From: Arnd Bergmann Date: Tue, 21 Dec 2021 15:06:23 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v8 07/14] clk: en7523: Add clock driver for Airoha EN7523 SoC To: Felix Fietkau Cc: Linux ARM , Michael Turquette , Stephen Boyd , John Crispin , Linux Kernel Mailing List , linux-clk X-Provags-ID: V03:K1:TipPqfZrt5fPNpVpqfXrkqNHXlljoK75j/MGT/b3Ebe6EMNsFxk CMAO67upxEevPfpibZT1KCW1lDlInvVGXlELHfsahhYmJGo00Poy3wo8Lp2bMJNHk6DfPwl Xo4TNAeAFL3nUeAaEysu4kdCjgqnlbnAtx3/bV/3/2y2VtIqXp9f3E9OLnCHv5FjvCNpgWQ F70MI1xIGgX1jhDGvfzEA== X-UI-Out-Filterresults: notjunk:1;V03:K0:aqFulIC6wKo=:rhKbD7ZhXTZXOtrthXI7Ro 2CitY2mIHhT8A24OLDIuf5CevQKdv21Cw34lBCSpd2BQI5TE7Xv51EqDWueNHtYwxZ08jKazt rvhJ7B6tA/2VRQA8UU78jRrlX+Apk02Qiiy+GI5dv/ftr2dzaKCr6Sqwgmn56WJAA2rdFfil2 YsXdWUkMTvEGCCatv4GuejviXKVDQrQoFgiLfowWK8PCdjOjeHVB+J2Sj+l4TFedu1hvNABwr LX4CGQ32SrOaWJJr58qMQz/zb56doSsPcugCT7Hlu0QGGra6D5RzHUdjkEcnbFZQRXQBzt9B6 fzmOQJVkU+CaqmKPNeY8c73m4qwwIJ42e09ricEGzUu56qa19Jm1GQHA92mveV3QWTuYxtqDP LTS1V8tD6aRcZtjPRM+F+LNHOuFjImD/+fqecW2xmQNXD24ob+6cqWxLNaeVNJ8Vyf/BoDPYq 9f2H0nDVGCuZZ0H/e9i7TLUPAAHqk5pPWWsR9pHmFPSe3Pz9xpADnSI3M5XQrp5RqHDccLIS8 NeWmnsudqmBO06jQindjH3AN9R12n759N5jHdm1a7JZDEPAPhiOCre087rRJRPMact+Y3nFsP qZ6py20dYg7dj84h3F6iLOFnex0Qm6YvWLZztqvIFFvOKQkbo4Sa7RphSQo+Iafllk59EwExT YbNOlKW/Bg3R0HFeSulL0AEtK0rL8G53SY1HMfUA3W4K3r3//C8OV6F39yUpYOSXLBSlkLyWm Z1GWGaj8OEMdF+p6crlJ/NMGwxwLDCXwqqRphzpqu/NDKFFUTQ4L39MseQ3chu1ik9fTX1dMp wb9QuvCp4nOBHQ5sMKwxacrIcqLeH5FyU30fulGTy2cFc30ttk= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_060642_844271_561BB675 X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 20, 2021 at 10:18 PM Felix Fietkau wrote: > > This driver only registers fixed rate clocks, since the clocks are fully > initialized by the boot loader and should not be changed later, according > to Airoha. > > Signed-off-by: Felix Fietkau I don't have any particular comments on the driver itself. I'm happy to merge it through the soc tree for the initial support of the clk maintainers are ok with it and have reviewed the actual code. > drivers/clk/Kconfig | 9 + > drivers/clk/Makefile | 1 + > drivers/clk/clk-en7523.c | 350 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 360 insertions(+) > create mode 100644 drivers/clk/clk-en7523.c I think this should go into drivers/clk/mediatek, as it probably shares some of the logic with the mt762x drivers in there. I'd suggest adding the maintainers for those drivers to Cc for additional review. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel