From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9458C433F5 for ; Thu, 25 Nov 2021 21:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KIY04qDlWM52Zl/8PP5rpXRKL2ZBCm8oxPOEeMh2LaM=; b=bLPrbL9BYvKVty Qs3J1V7ue4EhlozBfZtSBITO5tveF4RmYr9kMzWoYKOpXjpiADxesUr5ugopy4gcq22GSXrPsv7E/ JfOdh5EKMHjYVkCYQl8VObQtjHdv/OqtUYKGOIDFCu1dEWeuXDouGikqyuVedYFn7ud9rR15F5udY kVbdjsvoe5E4wBQaAFTZ2ip6zBdP3YyQF/IUOfa/0rQvbM2N9zBzs9mNPLaZ35eABgH6kt1WY/i8S X5lTZmvmM2brBv00i2H//Jb1FcfGn+wDiX9Lt8efzyFbsM9iFV6MwC6yO1nDBU3PT8t05dmd9rrSv QcfMzrfBtPB2oTE+ft0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqMWa-008mDm-Rz; Thu, 25 Nov 2021 21:43:25 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqMWW-008mCq-OC for linux-arm-kernel@lists.infradead.org; Thu, 25 Nov 2021 21:43:22 +0000 Received: from mail-wr1-f47.google.com ([209.85.221.47]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MysBI-1mdw0G43Wc-00w16m for ; Thu, 25 Nov 2021 22:43:15 +0100 Received: by mail-wr1-f47.google.com with SMTP id b12so14369276wrh.4 for ; Thu, 25 Nov 2021 13:43:14 -0800 (PST) X-Gm-Message-State: AOAM532MZ1E95nJSM7YqVjR9+vqoTLqt116IhdRytci3ZZyi09TP4J1V 9b9vf4xmu419G/NsoTDMs7wXvRU364ljQ8mIRNA= X-Google-Smtp-Source: ABdhPJwjKapht7W/sukRuCfcX+lckyEPy1NdAnaERzdim0N17M/wef+Nllp0lT2Vmf332KaJEcKdDsO7PSXmL6JXu0w= X-Received: by 2002:a5d:64ea:: with SMTP id g10mr10262560wri.137.1637876594530; Thu, 25 Nov 2021 13:43:14 -0800 (PST) MIME-Version: 1.0 References: <20211125211443.1150135-1-Mr.Bossman075@gmail.com> <20211125211443.1150135-14-Mr.Bossman075@gmail.com> In-Reply-To: <20211125211443.1150135-14-Mr.Bossman075@gmail.com> From: Arnd Bergmann Date: Thu, 25 Nov 2021 22:42:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 13/13] ARM: imxrt_defconfig: add i.MXRT family defconfig To: Jesse Taube Cc: NXP Linux Team , Michael Turquette , Stephen Boyd , Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , Ulf Hansson , Dong Aisheng , Stefan Agner , Linus Walleij , gregkh , Arnd Bergmann , Olof Johansson , SoC Team , Russell King - ARM Linux , Abel Vesa , Adrian Hunter , Jiri Slaby , giulio.benetti@benettiengineering.com, Nobuhiro Iwamatsu , linux-clk , DTML , Linux ARM , Linux Kernel Mailing List , linux-mmc , "open list:GPIO SUBSYSTEM" , "open list:SERIAL DRIVERS" X-Provags-ID: V03:K1:1oiEUpUsHIUIWa89UkPnxtN45yxdUXpnrEMxRvEHScVrmrUXW8D lGmMcU/88ldz9q0Y7yHg1JacOc8mpsKBo7fbvtRBz7cxSmh13P90UhEyrQTa8Sth00ydbCH BRLKDj1xr5wyLs6h2KcGmsG+A5sjmcPILawXTNZfmEpEqQXROud7n2bjWR31PR2X+XdQWiQ BZkMSyY71Y8YJ0xANu/SQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:BYgrw9mrKEQ=:/4g1n34Y/Ou9enXW5wwe5I I2Kz/9lU6E/DzHGGZVfTfhbFSjX5+zi4CC0hCDBB/07VfD/F0h1O7ni3RSxpHFIbqPLtVKo4Z srdmPw5LBeoQxCRZLoqdO/8+C9qOCCSJG9TZMGWBzmCruplZgnEUzqmcs4CMa7KHrHhHDmqFe SNrzcDCKohkoT9R/dnfa0XfEpuL5x8iicapWyl3vcoQQ8d3qgP1qSdbmOrYBEzvtfRmmjeb+Z mFtwIntf34f3qrf6Dg725BYQn1isT1EZ8Jtnjd3SdbL4+/cRaoCLaidX+5dUWWak8OQmAz2LA eaCr/pc+7vvUm9bL09XtPvdGRNfqpd7yStEmwKZDQPJjfkvw5TVOw0GqC0f4u5Dlt03qiFsrt GZGp/4xgs0ilQSld5w5tpuB2MxT7IoF4DlsVhnk9CKm9/CinZAYFs4iclWd7Qzp+nEPCCn8pz 6nzktwohPExea5i/P+n/GxzRy/9uieSi4I4FevmQvezh91pKl2ITbt24GAPXtTbNCaudW8/EA FAl4aqEbB3WiV6pQUQz3I1+Eu4Sv1UZ7ICetF5bC0MHZUhFW7JPKw8IK0+koxCBciqLV9kitl NK71QlTflRa7BYQq2CTl463z0O1HOpzbZWBZdT+vlTMurnBQKue3NsopxpLkHTG5i6f+PeCoL KmkYT6uJKFYYtRU97c1JmhPCh1/4aHj6gfu/ESRV0GEuIh+amBDKqqUpoDYeMGo2MGI01+pP1 Xcd4vBhYuHZLI7mD80/K5XQhTsEQls4bLJmloJY5prhKAIJJ8PE90pfe/Be9G5of5wpAbUI9k bJxDoCOfRkR8xgLTLeWjiHb9dpqsons9ReNJ3IHKU0Ip1tLZg0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_134321_131455_418A012C X-CRM114-Status: GOOD ( 33.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 25, 2021 at 10:14 PM Jesse Taube wrote: > > From: Giulio Benetti > > Add generic i.MXRT family defconfig. > > Signed-off-by: Giulio Benetti > Signed-off-by: Jesse Taube I see a lot of things in here that probably should not be part of the kernel, either because they are rather obscure, or they take valuable memory: > --- > arch/arm/configs/imxrt_defconfig | 157 +++++++++++++++++++++++++++++++ > 1 file changed, 157 insertions(+) > create mode 100644 arch/arm/configs/imxrt_defconfig > > diff --git a/arch/arm/configs/imxrt_defconfig b/arch/arm/configs/imxrt_defconfig > new file mode 100644 > index 000000000000..d673745a5462 > --- /dev/null > +++ b/arch/arm/configs/imxrt_defconfig > @@ -0,0 +1,157 @@ > +# CONFIG_LOCALVERSION_AUTO is not set > +CONFIG_SYSVIPC=y > +CONFIG_USELIB=y You almost certainly won't want USELIB, and SYSVIPC support would only be useful for certain applications that you probably won't run. > +CONFIG_BSD_PROCESS_ACCT=y > +CONFIG_BSD_PROCESS_ACCT_V3=y > +CONFIG_PSI=y > +CONFIG_IKCONFIG=y > +CONFIG_IKCONFIG_PROC=y Probably nonen of these are helpful here. > +CONFIG_MEMCG=y > +CONFIG_BLK_CGROUP=y > +CONFIG_CFS_BANDWIDTH=y > +CONFIG_CGROUP_PIDS=y > +CONFIG_CGROUP_RDMA=y > +CONFIG_CGROUP_FREEZER=y > +CONFIG_CGROUP_DEVICE=y > +CONFIG_CGROUP_CPUACCT=y > +CONFIG_CGROUP_PERF=y > +CONFIG_CGROUP_BPF=y > +CONFIG_NAMESPACES=y > +CONFIG_USER_NS=y > +CONFIG_CHECKPOINT_RESTORE=y Same for control groups overall as well as checkpoint_restore > +CONFIG_RELAY=y There are a few drivers using CONFIG_RELAY, but I don't see you enable any of them, so this is not actually used. > +CONFIG_EXPERT=y Are you losing anything without EXPERT? If not, remove that > +CONFIG_SGETMASK_SYSCALL=y > +# CONFIG_FUTEX is not set Futex is probably one of the things you /do/ want. > +CONFIG_KALLSYMS_ALL=y > +CONFIG_PC104=y Turning off KALLSYMS_ALL may save a noticeable amount of RAM. PC104 isn't actually that big, but it seems unlikely that you have that hardware. > +CONFIG_PARAVIRT=y You don't seem to enable XEN, so I don't think PARAVIRT is useful by itself. > +# CONFIG_ATAGS is not set > +CONFIG_CMDLINE="console=ttyS0 root=/dev/mmcblk0p2 rw earlycon rootwait" The command line should come from the boot loader, users probably have a different root device. > +CONFIG_BLK_DEV_BSGLIB=y > +CONFIG_BLK_DEV_INTEGRITY=y > +CONFIG_BLK_DEV_ZONED=y > +CONFIG_BLK_DEV_THROTTLING=y > +CONFIG_BLK_WBT=y > +CONFIG_BLK_SED_OPAL=y > +CONFIG_PARTITION_ADVANCED=y > +CONFIG_BSD_DISKLABEL=y > +CONFIG_MINIX_SUBPARTITION=y > +CONFIG_SOLARIS_X86_PARTITION=y > +CONFIG_UNIXWARE_DISKLABEL=y > +CONFIG_LDM_PARTITION=y I don't see you using OPAL or any of the 1990's partition formats. ot set > +CONFIG_BINFMT_FLAT=y For the defconfig, you should probably have ELF_FDPIC enabled, not just FLAT. > +CONFIG_CLEANCACHE=y > +CONFIG_ZPOOL=y > +CONFIG_ZBUD=y > +CONFIG_Z3FOLD=y Do these work as expected on NOMMU? > +CONFIG_BLK_DEV_LOOP=y > +CONFIG_BLK_DEV_RAM=y > +CONFIG_BLK_DEV_RAM_COUNT=1 > +CONFIG_BLK_DEV_RAM_SIZE=65536 I don't think you can have a ramdisk larger than RAM ;-) > +CONFIG_MEMORY=y No need to enable the subsystem when you don't enable any of its drivers. > +CONFIG_EXT2_FS=y > +CONFIG_EXT2_FS_XATTR=y > +CONFIG_EXT2_FS_POSIX_ACL=y > +CONFIG_EXT2_FS_SECURITY=y > +CONFIG_EXT3_FS=y > +CONFIG_EXT3_FS_POSIX_ACL=y > +CONFIG_EXT3_FS_SECURITY=y Never use EXT3 on eMMC, just use EXT4 instead to make the device actually live longer. You probably don't need to enable EXT2 support separately. > +# CONFIG_FILE_LOCKING is not set > +# CONFIG_DNOTIFY is not set > +CONFIG_QUOTA=y dnotify and locking seem more useful than quota here > +# CONFIG_PRINT_QUOTA_WARNING is not set > +CONFIG_AUTOFS4_FS=y > +CONFIG_CONFIGFS_FS=y I don't see anything using configfs > +CONFIG_LSM="yama,loadpin,integrity,apparmor" None of these are actually enabled as far as I can tell. > +CONFIG_DEBUG_INFO=y > +CONFIG_DEBUG_INFO_DWARF4=y If you use DWARF4, you probably want DEBUG_INFO_SPLIT as well, to reduce the vmlinux size. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel