From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D9D2C433FF for ; Fri, 9 Aug 2019 11:43:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22C3821743 for ; Fri, 9 Aug 2019 11:43:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J/319ySd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22C3821743 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NFxyodDolEtRNosp+DY3TT4WCrOTmTLpkgR1+9WxPEo=; b=J/319ySdoVwOMB hu3kAfaQeYKatNv79CzdT5NAaD61h0whpBwZrUlKqupVuUeMa6LJlBReINN9BQEJ4BSTQUuxGV++n 664/r3pBsGe4UXiMUi/Tm35AHLCXZPJLL8XkJA9DBSnEYR7c/R89K0sqGrXUL+B5sVTBevjTlNGQk DE/79urCS8dKTc6ybNsd1omIHcXquPNA7+cJYxh/tlHReg1jQI38/P2YfPBqaKWi0yyVHA+t3vyH3 1jvtniGyt5sd4zqPmONpkX1DlE8rU0IS9GfpyE4lSifk1Nc31Bh5FOKL9sJN5trkRoQwFkL5gz8Ny jZlMkScCEUk/CkLr584w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hw3J0-0006s6-54; Fri, 09 Aug 2019 11:43:34 +0000 Received: from mail-qk1-f194.google.com ([209.85.222.194]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hw3Ix-0006rS-1S for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2019 11:43:32 +0000 Received: by mail-qk1-f194.google.com with SMTP id 201so71284547qkm.9 for ; Fri, 09 Aug 2019 04:43:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VVKEn1uhwnct32QQNQWKMMQwz1IKox/lIkY41QXr3n4=; b=lTfOcWOqvtBAV/pYfJncSUhMbX7EOQYEu0uTqTdL46dm3rK+ztXCT5eukf77bwcY3y aL5YJ1o2R4rMpdOpneVi5h3jTPqtxoo9LLLNtIB+//jJ9CywJLn8WHTJrPtXVBpWES32 eK7/vIuShFMYqUpY8VsnAGTq+JSckhP5lfs2wWTTg4grAnHLZ6U93YHZmC4eTE37uUoC 6AguiqZIc6Yh04oqsR5PsAqLodhgRERm0JoNrmbdzN4OiOPeACiHzeUsydkuZ2kQXSKT YK0r5AxCq+tX1Y6sgkV6f8JOU0muMvbeDcCw/RhzgXvGWgo7VgwBeyZ2bRXtaJATNM+I Zx5w== X-Gm-Message-State: APjAAAXWjvxJl2y7ViYeoNKChUg3CaTCM3avh5GF9RSic48OgZLlXuyJ A3b3gGQrzBGv5QsWdRVxuZ/aYLKAvvzA1qd4SPQ= X-Google-Smtp-Source: APXvYqz3y2NTzxkuXgdthyLbml49Ah52Sn2rqR//B9FnkAzFwcen/MazMdX5ZFS3FoRo2xISosV/96/4q4XOkHiRGAw= X-Received: by 2002:a05:620a:b:: with SMTP id j11mr17853054qki.352.1565351009257; Fri, 09 Aug 2019 04:43:29 -0700 (PDT) MIME-Version: 1.0 References: <20190808212234.2213262-1-arnd@arndb.de> <20190808212234.2213262-3-arnd@arndb.de> <55c9608d-68c4-17f6-2682-7668d5d7720a@samsung.com> In-Reply-To: <55c9608d-68c4-17f6-2682-7668d5d7720a@samsung.com> From: Arnd Bergmann Date: Fri, 9 Aug 2019 13:43:13 +0200 Message-ID: Subject: Re: [PATCH 02/22] ARM: omap1: make omapfb standalone compilable To: Bartlomiej Zolnierkiewicz X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190809_044331_086177_41D6A3F3 X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aaro Koskinen , Tony Lindgren , Greg Kroah-Hartman , Linus Walleij , Linux Kernel Mailing List , dri-devel , Tomi Valkeinen , linux-omap , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 9, 2019 at 1:32 PM Bartlomiej Zolnierkiewicz wrote: > On 8/8/19 11:22 PM, Arnd Bergmann wrote: > > The omapfb driver is split into platform specific code for omap1, and > > driver code that is also specific to omap1. > > > > Moving both parts into the driver directory simplifies the structure > > and avoids the dependency on certain omap machine header files. > > > > The interrupt numbers in particular however must not be referenced > > directly from the driver to allow building in a multiplatform > > configuration, so these have to be passed through resources, is > > done for all other omap drivers. > > > > Signed-off-by: Arnd Bergmann > > For fbdev part: > > Acked-by: Bartlomiej Zolnierkiewicz Thanks for taking a look. > [ It seems that adding of static inline for omap_set_dma_priority() > when ARCH_OMAP=n should be in patch #9 but this is a minor issue. ] That would have been ok as well, but having the addition here was intentional and seems more logical to me as this is where the headers get moved around. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel