From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 551B2C433E0 for ; Mon, 29 Jun 2020 12:00:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2103923D1F for ; Mon, 29 Jun 2020 12:00:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ilyk3xaA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2103923D1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N4nPzvhDSz9RNpYjgUi8fz/Ld+50gbvYneepA9Tt/OU=; b=Ilyk3xaAZVbTHV5yavsmnfrf9 bS3aOxyWXHhdx2fywHwXNiorWX0v+28BpjXdoRNSeYhsZBvgsz5j2obFvQs1GGZhzg1TNWCk2SFBE EeqT5YhaDTcbOn6f+S+aq53MOHXwwPJXdtQTIiq/8ggc3QiSbURBOZ9RRFiZZ+XpzjPEEZRDBOm9k bJgy3LsFtxUIdHf0SnERPP3xhgvDgT1WtWJq7hGYBVAvsCUEFLCvgfO+dWDUb8EtIl+S16Y8HsmhK 9f5sGCyhUSMRQoTiw+515ruJhYvXahBSAZXZkHGjYnepYW8MpRIvXZ8aCTzOZ/4oD2hFKOkxCmqc8 mSPxSg4NA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpsR9-00070J-Ms; Mon, 29 Jun 2020 11:58:59 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpsR3-0006yj-4q for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 11:58:57 +0000 Received: from mail-qk1-f177.google.com ([209.85.222.177]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MnpP8-1j1iUq0VLe-00pOs0 for ; Mon, 29 Jun 2020 13:58:34 +0200 Received: by mail-qk1-f177.google.com with SMTP id e13so14928279qkg.5 for ; Mon, 29 Jun 2020 04:58:33 -0700 (PDT) X-Gm-Message-State: AOAM5314bKRjF26FaYZFd7AsLmhH0YLbQW5WlLUAqPSmaff6im5F/b1o JoIZ6anm0RXe1FEEUbun1TOM17pdbh3oEurXxq0= X-Google-Smtp-Source: ABdhPJxw4aQcyyOjqz6zdloYX0Zg8NLEiVrSGqKIRrgeB6TYwmUcJuTIitYyWyx3icLmYS7sF9chjW5BSGykMBVcb8E= X-Received: by 2002:a37:a282:: with SMTP id l124mr13904809qke.3.1593431913015; Mon, 29 Jun 2020 04:58:33 -0700 (PDT) MIME-Version: 1.0 References: <1593410042-10598-1-git-send-email-Anson.Huang@nxp.com> <1593410042-10598-3-git-send-email-Anson.Huang@nxp.com> In-Reply-To: From: Arnd Bergmann Date: Mon, 29 Jun 2020 13:58:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for module build To: Anson Huang X-Provags-ID: V03:K1:/FmNTDzqYrx0SchXa9XNByH8VF++mz63PETVzdVNt+QxaW/cLF6 jsklIdCYA7dxLxam4MKWKEMDE9DI/6ZjXOMIkPm3jIPHo7TRhma0eiUuvPJFuK2+r0t5yb4 s6cDue3zTSYX45LGeJSOk6yscGZEFgGID1v6P5XiXU3ZGSOEwmVu3KLkz16+4VHCnZbzkOr gsh/15SfzdBE2YK8lODFg== X-UI-Out-Filterresults: notjunk:1;V03:K0:dy9JjxTfVIM=:nn73GfAYesQdAIOe3mG7dv TKfKJilYib4n/xQt7mtWwmUpb75Ywu0qqjypIjZ7k0fxjhxAhSUTSxBdueKEAWmCQhZ/NIgHk xhRkFIaGKXasg5U3+D9RDarcDCoVYBINLsLS5ZUp0DVfD6qN1PrNZg4uTgdPza+jgNQl2709n LfDcoxPfnLnv8yzzLQxaA3rC4yTmzPPuvSxIotJiY5VyOwqznFJXS3AbaJUJoPSSQMuu28USi oA+4+Rd90Ogh4ihNf+8gsXeyhwvj7kmGMUxyqzzC+w053l0OuxthXmWwGTZAbomtSIhMRAG8q K/Px1oVu03xxVCyoGl0kZ+SvuYWLo6JBhB3MWz+V7wy/oXVlLyysnJfsELc1FCHAf0/UVgDIk 9hsuDJ2/KpBYyvgj7ic8/fSKTNWs6mI1u0yjN4n0ZM8y+sqzG/fbvphTKXPdSluja71RK+JWz lYGr/B24GVgzNjKz4TuRAB+PbHXKRvN4Ov9uRsmh5gOi7vs87ByfgiBR8r1ogboSXlW3qVTzB tJKCD9ibubtkvhXADGksKYmsXAphAiiJQRt75OB1dgorzmQhsd3PAYB6ox2f+JZvlxiXz/7NE mA91AA+oSyCCj9iZI6pD3VVYVEx6ikne+eYJPG7QA/eBy0hgABTMXJITceXjoJOn2uH5RRFYs dxNhfE9TfZ8/F70S7LtzS4tH1DSMVl6ohEiu0IdPFSXYIStXNVgrVLQprfgLxRk3v5S1BSO2S VtSQTwv65ecNetwx5zVBdmVct1/uHNPEO5zn5HBYsgSZAXyrv0iQSPKrY/c3WFs4hI886scxv v3zdBZEk1zXU6UMlPolTLpIsp6yrtDKFxotCFS5UpyQxt9tNcY= X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Stephen Rothwell , Peng Fan , linux-clk , Andy Duan , Abel Vesa , Stefan Agner , Stephen Boyd , Shawn Guo , Sascha Hauer , YueHaibing , Russell King - ARM Linux , Daniel Baluta , "linux-kernel@vger.kernel.org" , "oleksandr.suvorov@toradex.com" , Al Viro , Sascha Hauer , Fabio Estevam , Michael Turquette , Linux ARM , dl-linux-imx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 1:40 PM Anson Huang wrote: > > Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for > > module build > > > > On Mon, Jun 29, 2020 at 8:06 AM Anson Huang > > wrote: > > > > > > Keep __setup_param() to use same parameters for both built in and > > > built as module, it can make the drivers which call it easier when the > > > drivers can be built in or built as module. > > > > > > Signed-off-by: Anson Huang > > > > I wonder if we should instead drop the __setup() and __setup_param() > > definitions from the #else block here. This was clearly not used anywhere, and > > it sounds like any possible user is broken and should be changed to not use > > __setup() anyway. > > > > > It makes sense to drop the __setup() and __serup_param() in the #else block, > just use one definition for all cases, if no one objects, I will remove them in next patch series. Ok, sounds good. Note that there may be users of the plain __setup() that just get turned into nops right now. Usually those are already enclosed in "#ifndef MODULE", but if they are not, then removing the definition would cause a build error. Have a look if you can find such instances, and either change the patch to add the missing "#ifndef MODULE" checks, or just drop the __setup_param() and leave the __setup() if it gets too complicated. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel