From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2970C31E5B for ; Tue, 18 Jun 2019 21:09:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C22482084A for ; Tue, 18 Jun 2019 21:09:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NxkfWxDc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C22482084A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+2ge6zotSAirx+IWiNgrWvg8vyjngCYt/xEvK0Zm+40=; b=NxkfWxDcU6NsWS wPVFCkljS5u3+5G7hutL5Hiqzc2Goews2bwZ9Y2n3t17nO05V0oPZdxN5XNlzOC8lpIYxPARHxCqp SPe+Fnm9JsuFaPuZ3U7A0aoMELEWoytqt7ZBXPzTv6/8lkcr0O5ojlb7Dvi+blZ16EuQJkLV3Ctj/ kyCG161qpA8yibtKAQbSp8dpvLuXzOjQePsIVOW/fWFBxeWorcfHNXIyK5fypdqU1eT5GlxRT5xhv 4E2HOF4tZLWfM/VFOTLhW4HgPGQZsqfBtG2gIf2ZEuqfOuanKh/qtRev3XqdQrsdCiWrnzZYz79M+ Nr9LvXIrepoAMGjzdffw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdLLt-0001F5-9W; Tue, 18 Jun 2019 21:09:13 +0000 Received: from mail-qk1-f193.google.com ([209.85.222.193]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdLJY-0007qI-8I for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2019 21:06:50 +0000 Received: by mail-qk1-f193.google.com with SMTP id a27so9539203qkk.5 for ; Tue, 18 Jun 2019 14:06:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PhQShykXloliKPMckMupDfwZ8pnrhdgE2i1x2GgfEmI=; b=Gh7by3bZzbayE9gu+ay68toQAYmdCnnN0NTnoX5L+tIt4dfnHgt6kXo68p252pPyjQ 4l40bubAeC7jxDyCO5ff80mD7PgFP7mTCpx0o/NAC/+pQgqjJl79uHZYFzagbT4/xCwW BTNlfPDtpbgFFJOUeAGQg90obvV4IkHxw3fq/AFV1PrETI7YcQM+8R0CKfYDZJGZ2O5p 5xTSxSKBFSf/HjGxYog+7kZcLNrHx+PStAGwGMbVWnK6J4+D2bTHxm64bho28/FWzcZ7 VdvzmEkJ+V3DUXUD/sm65U8fhBYt4g2e9CvcPsHIUyg6GdJECwRJCT0YrXXjUWqTz41Q ZCZw== X-Gm-Message-State: APjAAAX8mpNaLqsKtk1lxYAC0Nx2aYBNbT7zuASy7aW+db6altqGjpSv +eERoPL13/mtZYzrpkjkOVnXbcryh7pk07R9qzU= X-Google-Smtp-Source: APXvYqyldOckhcLwc1fQrwZ7LnDDOLS2W9t7zPz5YSzYHLSMEwkWyDge/ONSs2cFdXB+lyGj7IX6kT1wQZim1MIdYpE= X-Received: by 2002:ae9:e608:: with SMTP id z8mr87456546qkf.182.1560892007052; Tue, 18 Jun 2019 14:06:47 -0700 (PDT) MIME-Version: 1.0 References: <380a6185-7ad1-6be0-060b-e6e5d4126917@linaro.org> <36bca57c999f611353fd9741c55bb2a7@codeaurora.org> <153fafb91267147cf22e2bf102dd822933ec823a.camel@redhat.com> <97cbfb3723607c95d78e25785262ae7b0acdb11c.camel@sipsolutions.net> <54a5acb6cf26ebc6447f8ebcbdcb8e0eed693ab3.camel@sipsolutions.net> In-Reply-To: <54a5acb6cf26ebc6447f8ebcbdcb8e0eed693ab3.camel@sipsolutions.net> From: Arnd Bergmann Date: Tue, 18 Jun 2019 23:06:29 +0200 Message-ID: Subject: Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver To: Johannes Berg X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190618_140648_337640_93DB74B5 X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , syadagir@codeaurora.org, Eric Caruso , David Miller , Dan Williams , linux-arm-msm@vger.kernel.org, Ilias Apalodimas , Linux Kernel Mailing List , evgreen@chromium.org, Bjorn Andersson , Networking , Linux ARM , Alex Elder , Subash Abhinov Kasiviswanathan , linux-soc@vger.kernel.org, abhishek.esse@gmail.com, cpratapa@codeaurora.org, Ben Chan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 18, 2019 at 10:39 PM Johannes Berg wrote: > On Tue, 2019-06-18 at 22:33 +0200, Arnd Bergmann wrote: > It seems to me though that this is far more complex than what I'm > proposing? What I'm proposing there doesn't even need any userspace > involvement, as long as all the pieces are in the different sub-drivers, > they'd fall out automatically. > > And realistically, the wwan_device falls out anyway at some point, the > only question is if we really make one specific driver be the "owner" of > it. I'm suggesting that we don't, and just make its lifetime depend on > the links to parts it has (unless something like IPA actually wants to > be an owner). My feeling so far is that having the wwan_device be owned by a device gives a nicer abstraction model that is also simpler for the common case. A device driver like ipa would end up with a probe() function that does does wwan_device_alloc/wwan_device_register, corresponding to alloc_etherdev/register_netdev, and then communicates through callbacks. I agree the compound device case would get more complex by shoehorning it into this model, but that can be a valid tradeoff if it's the exceptional case rather than the common one. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel