From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2ACEC433C1 for ; Mon, 29 Mar 2021 19:23:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47BED61919 for ; Mon, 29 Mar 2021 19:23:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47BED61919 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pensando.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eOOi4DXJ3UgIknUr6bba6VqZ+tRz6VKMVOva5id5UJ8=; b=PY7rtcZdMWuLiEdot+YleWT6B MTnPTi6WYAxYtQ5guL6ArYeMA3oSvdGuEtoHcL3cddNsA4Ft9sDk2/OJyUVlkcYTThEaoUbdZ2XPR dizyOgcM4SFpmbfV0H1GFgaXIQC+QR/ULDQfTlTSO6N0lFzLpUzBz0MPnuvRl09WTRM+B8LCpAzRn 2JE5qnVmKXz21Zud/Hli096ZZzK02pCk6RLvZ8JSyGkBr5zTddM5ek2jx4ky/OS7NNFDvMaw3Sh0U rmMGVqg27/3cQsNo7P34MhQZnS2cTb1NN21KmJRnbjfBXB9Iy2iWT8WNDP0aEBvrOIAxRfktno9lB P322Nhrqw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lQxRY-001Dzs-Gh; Mon, 29 Mar 2021 19:20:57 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQqCp-000cep-4j for linux-arm-kernel@lists.infradead.org; Mon, 29 Mar 2021 11:37:17 +0000 Received: by mail-ej1-x62e.google.com with SMTP id u9so18887560ejj.7 for ; Mon, 29 Mar 2021 04:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=349fMBgcvLa2+pNSfzfycVChb5yT8zGK3bjeXkh2b54=; b=tYAV3AJw8goKt1/I7O4N9gCWAgwEW8sSZRa14XT9mZfyxwEeObMDl3W42OIKtzffuv hU4x0UFkFi8+rMG3TDwCTx3teYcimezXli/2hwxG0Q2DxNIRn5b697BGR1AIzhlrC3xd X2UxFk3DpKTYoYgAbJUWRKnszi8byKrP6EDHBMYS2BLEUN80cmWm+KjJZyYtfjLgZePW Vuuvf2SDnJJ14TroALOxjjQEqhnZe5Q9qqrfXSQjR6BM4oC0QryXWiTXQA9AbisGjsc/ NFRXKpaM31T02m1hkP+9CX+F+RsEb4rigy77KDGuIdsJ8HQzes+kWnK4njaFgdwZwWu1 y1GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=349fMBgcvLa2+pNSfzfycVChb5yT8zGK3bjeXkh2b54=; b=BjnMSwp0kFz8LHYVw2+Q8XKxN3kX8Q96iJTa2DzTQFHkTsJOSpGYP80Awz/PIGD7on hRMIwa1djXTPJxuBhi1IMIhZ25/v2HjIYFsVvvDTTaQUrReIO8KBufc+jho3EBK+Gqoz bKD/Bb9q4UicuIlWB6tVmJvYjFc5/R27/ickeSKTcc3hIqBelf4udXwtAYz/S9A5Dc0Q guBjY83aplm4x/hIM1ykXtNTpZEFz6O4iA4jrsH4OJQiiG54jg+KYQjkNi2qU1GfXAUW mLOJxoGyXKF8twY3vjihceFTVBnbSvsZYce94D4vVtPL2R4HCZV5EA8m8Ys6/vwI571h H7kA== X-Gm-Message-State: AOAM533l7NKP+enZAn8YOwcirC8cgKjhug/qh+oa99UgOYfGIpEw2XOY LicNbOUaHFvWSRA8IbSxPzzitMWLxtugpW0AtkEHuEr9J/h+hA== X-Google-Smtp-Source: ABdhPJzkNiPyCnBppUUGbv5MVnPLDaLWeyH5f2w/Q4QJP77DBRiwNOzHDtPrBNoUB6HHPhXJcxOs61+ET0MKzh7YrWk= X-Received: by 2002:a17:906:52d0:: with SMTP id w16mr25994658ejn.172.1616980080843; Sun, 28 Mar 2021 18:08:00 -0700 (PDT) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-8-brad@pensando.io> <20210304080355.cc37g7jagswro3dg@mobilestation> In-Reply-To: <20210304080355.cc37g7jagswro3dg@mobilestation> From: Brad Larson Date: Sun, 28 Mar 2021 18:07:50 -0700 Message-ID: Subject: Re: [PATCH 7/8] arm64: dts: Add Pensando Elba SoC support To: Serge Semin Cc: Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_123715_324730_72991FF3 X-CRM114-Status: GOOD ( 21.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 4, 2021 at 12:03 AM Serge Semin wrote: > > On Wed, Mar 03, 2021 at 07:41:40PM -0800, Brad Larson wrote: > > Add Pensando common and Elba SoC specific device nodes > > and corresponding binding documentation. > > This also needs to be split up into sub-patches seeing these are > unrelated changes like device bindings update, new platform DT file. In patchset v2 this is split into sub-patches. > What about converting this file to DT-schema and adding new HW > bindings in there? Converted existing file devicetree/bindings/spi/cadence-quadspi.txt to YAML schema. > > +&spi0 { > > + num-cs = <4>; > > > + cs-gpios = <&spics 0 0>, <&spics 1 0>, <&porta 1 0>, <&porta 7 0>; > > Oh, you've got four peripheral SPI devices connected with only two native CS > available. Hmm, then I don't really know a better way, but just to forget about > the native DW APB CS functionality and activate the direct driving of > all the CS-pins at the moment of the DW APB SPI controller probe > procedure. Then indeed you'll need a custom CS function defined in the DW APB > SPI driver to handle that. Yes, with an Elba SoC specific gpio driver. > So that GPIO-controller is just a single register which provides a way > to toggle the DW APB SPI CS-mode together with their output value. > If so and seeing there are a few more tiny spaces of config > registers added to eMMC, PCI, etc DT node, I suppose all of them > belong to some bigger config space of the SoC. Thus I'd suggest to at > least implement them as part of a System Controller DT node. Then use > that device service to switch on/off corresponding functionality. > See [2] and the rest of added to the kernel DTS files with > syscon-nodes for example. > > [2] Documentation/devicetree/bindings/mfd/syscon.yaml To us it was more understandable to implement a standard gpio driver for the spi chip-selects. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel