From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8522CC433DB for ; Tue, 30 Mar 2021 02:23:35 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0CA461989 for ; Tue, 30 Mar 2021 02:23:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0CA461989 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pensando.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=POonyPEhOAzkrqR+f5cAiRrRkd1ivebVktdIb84cpXw=; b=ojZ5RJUj0eCJlcVnUfG8hPLRJ CDFyjXKZWFvm5UL7WVYEt3JuARuRTRXISUjGbAk0oGadveFR/j+4d4fltM9DxzCC4sozk8zOMLXRM f9/PZJE6FbdjKZ4yVELlAhV0JqKXikFzPt8nWTerBu184XFm/i0cJ2ppJnkYvIkoaJDsQY1wivfVC so5izspan/zapF66zqbHe3JIuLilgNTX8kF+58n5qo1i54RHY1ByPYR86R4QOnuLa9Zsp31Kd66Y7 I8iVXPmlrgQ+nwZswWsdjv8LujYmsyaTtrpNUyS88lVihehHcbEptc1ap/yWZ/trmuvoHLWbuePGF Uoek35a+A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lR3zr-002R39-6w; Tue, 30 Mar 2021 02:20:58 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lR3zR-002R14-3I for linux-arm-kernel@lists.infradead.org; Tue, 30 Mar 2021 02:20:44 +0000 Received: by mail-ed1-x534.google.com with SMTP id x21so16359502eds.4 for ; Mon, 29 Mar 2021 19:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BNHTcB7T4m2UhGaP6tF0hE5xsssyn7CBJeCl2o2y96c=; b=3Jk70Zk4F5jowxsYWm3lTWYYlFYvVtweN2HMGEERNCWJJoFJScnelnvTOGhHoGtEHF bjWgFDtn1L6n3yORUefyad+0vjG24U9GJNwJRGuyz6k8ScIp9qXoNqdkiEeHH/JFHPVC KUG8Fa7VA/iCSp2eXPHM42dNLXgO1ZCzVk7aZcKwKUE0V4e43WySAFGTmyQ4OibO7zZQ np1ngO5SCpzrNuQhxfTy1UE16zRzBoLG+LrAieW8c4tE9+JhJuQqW8tTRGa6jOt9aM0M raa/SHExfWUvx5PesBNPEjW1Li7Y/pw2lpWu5Xs5UckyIttjnuxifL61PIMKgNj0c1x0 qccA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BNHTcB7T4m2UhGaP6tF0hE5xsssyn7CBJeCl2o2y96c=; b=EQrlFCHvCwW6+Bj6jiGy6jNPikovAeLqWgYMqiYt3Fiwm5dBHJkxVZHU1fSOleYXJx 2gGjnkuHhWTb2uXHC5U52fFez4TRd9aNcgE96vOkyiEo3ZRLpoxf54N4zjzdavOTlm+Q X5PzPGi7GaOXUxOXcdJ1LMWePPbP8AROcFuLS6dBnZT7xUDV32/PZdG2TBuSC7XLYmTQ mZb4FEQpaO+20l7Gv4QGJgaxfNBGv8uTuVklOmvbk/X4//K4PAYh7uOaqUCSbAGlxeoV ejsJyeZv0eXmkO3V92rr6WG4bAHX27w54WT2BWG6K3XNefO0l9jr05rPo5+4bmNmgqAi 6grA== X-Gm-Message-State: AOAM533yJDHy9sbX1S85pwtqQdPpq8Ah1K8QPUHA1RKjNUbpG4DExQCd 3Jkhax5GLImyLXn30WCePvJaZOkE2/IrW6iHcP89+A== X-Google-Smtp-Source: ABdhPJxH6gMBXO9lUMvfVnMPvFOCVPVBGxmo2plP7nneNga21Eq/glfl39TCieWaga31tJtldBkoruBR43eR0xdv6v4= X-Received: by 2002:a05:6402:b48:: with SMTP id bx8mr32418567edb.162.1617070820221; Mon, 29 Mar 2021 19:20:20 -0700 (PDT) MIME-Version: 1.0 References: <20210329015938.20316-1-brad@pensando.io> <20210329015938.20316-14-brad@pensando.io> In-Reply-To: From: Brad Larson Date: Mon, 29 Mar 2021 19:20:09 -0700 Message-ID: Subject: Re: [PATCH v2 13/13] gpio: Use linux/gpio/driver.h To: Greg KH Cc: Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210330_032040_331643_D9088047 X-CRM114-Status: GOOD ( 20.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 28, 2021 at 11:48 PM Greg KH wrote: > > On Sun, Mar 28, 2021 at 06:59:38PM -0700, Brad Larson wrote: > > New drivers should include instead > > of legacy . > > > > Signed-off-by: Brad Larson > > --- > > drivers/gpio/gpio-elba-spics.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpio/gpio-elba-spics.c b/drivers/gpio/gpio-elba-spics.c > > index 351bbaeea033..c0dce5333f35 100644 > > --- a/drivers/gpio/gpio-elba-spics.c > > +++ b/drivers/gpio/gpio-elba-spics.c > > @@ -6,11 +6,10 @@ > > */ > > > > #include > > -#include > > +#include > > #include > > #include > > #include > > -//#include > > #include > > #include > > #include > > -- > > 2.17.1 > > > > This should be part of patch 1/13, do not add a problem and then fix it > up in the same patch series. > > thanks, > > greg k-h Yes, thanks. I'm laughing at myself today looking at that patch tagged at the end. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel