From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CE7C4338F for ; Mon, 23 Aug 2021 01:10:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BF0C61354 for ; Mon, 23 Aug 2021 01:10:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5BF0C61354 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pensando.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0wa6jUppZYUdcys2ArIs0VMO9swrje/F28MKVq4HC5Q=; b=He8VufMUiJ0Grw 8Ls4qJrLGjQFkRuVF5EzGz3iMuDX17vzxpRSyn5Ed/mzCCHyW+Aiuk7ONPIN4V+n3i9SewlajlI0B +2QjtYWwxor7sO7+FUe1FmQ+yZyvOatjBLYicd1lJJWMYC4EDV38wo29Yi+F1T6+6Ixz8MAysLhhW dTa+jOnsNKTvnnuHPix+OrM6Yoq1n2A6cqSfxGpDig3zrUPdvzynxgESbHevEYgMDs33ebuHVL2kh wFAPBG4rWvHIgE7j6p/9+1nfeenbKG4WFFaNZs6LmLNZG4v+OqVSELKIBTVbbMuGi2RA8XeMf59ME ZwnUus82E5f4IOEzJafA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHyRb-00F0w0-OM; Mon, 23 Aug 2021 01:08:07 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHyRU-00F0tY-RG for linux-arm-kernel@lists.infradead.org; Mon, 23 Aug 2021 01:08:04 +0000 Received: by mail-ej1-x630.google.com with SMTP id a25so6734893ejv.6 for ; Sun, 22 Aug 2021 18:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T5y7wVd3UOjVoEbI5ONgdC3uXVDViTEHAaSeTJ0ja4U=; b=h0t9/9UfiLyNfrXy6i0QXamegtgkKo10OoklxRz3R26HLZl3qSFetS66GnthOrWnFf 8PykNkBM5JtaKkf7uWyRaN89t138vt/k5ZFqskLgc2pFLnrMvajgV8sWsKyLI7CVyw5L FOtjL9mWdRKC/LfK7HLFayYeNxmQBONc909smYGw0rf7A1TC/wLwEkixK7SVhue9ER5r XVkPy8Bm3BSgyC+Ela1I18JEE0ZGtFWcBI0tKH5q7eqCZ1U9D9pnxZ259b4JW2pwBMPD xetYuva9J0p3LJ+wLpd7LmG3bj1jYwgCb7iUpo1GhKG/y4d4XZxJJbI1yAX1LnIn1uT9 dTyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T5y7wVd3UOjVoEbI5ONgdC3uXVDViTEHAaSeTJ0ja4U=; b=EPdfKnQD4mjwlMlAS67HHzhqC5aMPs22ELnhixMdA/C2Kj/HoI6wsl1itPdEM6/w8f 2uIoY97eiLZaWREItvJyNrDvCWTlfajIhhENNGUru5Y39h+7GiUGChg5ibowE2t2imB2 gUJmo3F9bII1lhYtastdvH8i1sP8bBRRjRe7OzydymEGsPTLBE/7KNsYyJP8q6mHJgVx Vuw/kXPp60h3pAayt0ZkGjoHhNWLMKrPXG2OrGv8FoBtsBdVM+9Zs+/eCc36HpMVtNI0 tLSAwI68C+MJ52P0Ck71uTPejaAPRFQxUc62Rc+jlj0y00GTNIzKDRZEVSellWsU2ZEV aMaA== X-Gm-Message-State: AOAM530mmiFjFFwI+CkfDtHjnzJ+GPZUJKEw79oYIFE1lBnDFAcxoAe+ DhUgk3zsMcO2IVb+gnBbyZ5jFNNAMh8iAjwYmqcXCA== X-Google-Smtp-Source: ABdhPJz0StLU+fjdzYTuDDRKxp8saXqBpf1ETE1pQ01x6B/7KvW0AELfBnJQYQyaNAKcNTY+WEiB0NIW5O91SEGzLTA= X-Received: by 2002:a17:906:2305:: with SMTP id l5mr33404768eja.72.1629680879402; Sun, 22 Aug 2021 18:07:59 -0700 (PDT) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-2-brad@pensando.io> <605880ad-6c12-bf1d-45f8-ef70181e4eec@canonical.com> In-Reply-To: <605880ad-6c12-bf1d-45f8-ef70181e4eec@canonical.com> From: Brad Larson Date: Sun, 22 Aug 2021 18:07:48 -0700 Message-ID: Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control To: Krzysztof Kozlowski Cc: Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210822_180800_925593_2E78C039 X-CRM114-Status: GOOD ( 13.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Fri, Mar 5, 2021 at 3:25 AM Krzysztof Kozlowski wrote: > > On 04/03/2021 04:41, Brad Larson wrote: > > This GPIO driver is for the Pensando Elba SoC which > > provides control of four chip selects on two SPI busses. [...] > > + ret = devm_gpiochip_add_data(&pdev->dev, &p->chip, p); > > + if (ret) { > > + dev_err(&pdev->dev, "unable to add gpio chip\n"); > > + return ret; > > + } > > + > > + dev_info(&pdev->dev, "elba spics registered\n"); > > Don't print trivial probe results, unless you print here something > useful. If you need it for debugging, keep it dev_dbg. Removed that extraneous logging Regards, Brad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel