From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7015CC4338F for ; Mon, 23 Aug 2021 01:25:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E57861357 for ; Mon, 23 Aug 2021 01:25:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3E57861357 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pensando.io Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S+uI3jPHsYRTST0R0EOhSS+vGrlsnMgXym9s/YHiY18=; b=E/4Eh/E8tYxbTe wAKzcfLlzRwLBA6bOaVVoxgcO/j6nW+D+BWPKo4moKBapNT0z7Ryk6yD1sGM+kz6Oz1DyYFfLdaTl JSmLw6xWo0YrupaZfLFrJtYu9sNZjWxdJxuIlmfQjEzs5fvSCyZn4f34dOaUdUcE1t8Wfs+hyBOKW g366jeAqRVLsxOa3npOyfj3WtujgvyUkyWZ0E/Ryn0uUxA+XgVCsOq5wqypBFi9q3ajtqaSPljblL iaQxbr3BgDkmGT8hNTXzQRukJDjVOpMopU5p+yRyph23r5G/89LaRJq804Abpb4EizeLYbg5FVM+Z UbdBBah6aqFaiHA8cQVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHyfy-00F4jw-If; Mon, 23 Aug 2021 01:22:58 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mHyfr-00F4iB-VE for linux-arm-kernel@lists.infradead.org; Mon, 23 Aug 2021 01:22:55 +0000 Received: by mail-ej1-x630.google.com with SMTP id me10so5110847ejb.11 for ; Sun, 22 Aug 2021 18:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WYDJcPk27eaOYzRvmn3VXjqVNS8Lwk0NBihSR+O45KM=; b=nZYLHHjr5VkmwGK7MDgQNkIuvR9b708LZrDPVpVfiOfCaOsZc67/GF0ZTFXAn1YfFR 8QXLJ/bFLIE3ey2RE7gNjmdtcjSFVy1YeHyAfMIpxs8eI6tj7IZeS1Ax2rLB/DJ9u6eV cXCZIVmYemvhIbpyY4uzErf646Afut7PXBc6rC5QVTSjlDevFOwEAf3zp4uS95DzziGp 7lvKI3WBx4lSQgMFaofLbL+q1oYtmxSS+9AI8V+XN9CCs6NYICElUYvZLqpAg7SsS4Mv tSaLsbwGa4Gb2+cGjFUH0D+Z7l4iIepsGKUNbUeJKsWhQDYnTpT7ltRBncOVF8fQQp43 WN+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WYDJcPk27eaOYzRvmn3VXjqVNS8Lwk0NBihSR+O45KM=; b=qoQRsmQLMLJP3Hq6XMUHylyXzeID3OG4ZfQ1JMNJJF03a9mIV3emEmigF3T1WsV2A3 praU8vNjsVE8g//wCWIgWWXIVwkvnnexPQF++6NHnbJLF/dhLiaEAV2A4spGMeKdKYgS WnTm9f9eeUxXyraBC64Q+JONg7UnBu9NaPVwTJMXcYE6q0mI6OHA3FXSSF09EF++2Yvi 1GfXu5lDANST6g/+N9cF0GcVmFimRqxZ0JqbGP/+88EuhfwKtmI/R8X0R0WSsm5HYpwT 9ys0/qTgbN+p/hmu1ZTUORDLxIZIJmp+MIgyDxZ7mt0zuLobp9qD2q3asBArUviuikVp a2pg== X-Gm-Message-State: AOAM532vWX//4XGYOTBs2JSTEweSURGDWZ/hWPP5lh1HfPEv5JXrOn74 TM28aIgt4ohhlNAwQJtVP8Va4XgKqJ24fN9IgZTV+Q== X-Google-Smtp-Source: ABdhPJw6n+mH08Xf6OE4yaoX37ooGQf1hGFMgsgeCuMYD5FoyBZzpgVOJVBPL9zW75eYcv5s/Is2jMQ3RdsUuC5Q3Gs= X-Received: by 2002:a17:906:b25a:: with SMTP id ce26mr1428510ejb.174.1629681770527; Sun, 22 Aug 2021 18:22:50 -0700 (PDT) MIME-Version: 1.0 References: <20210329015938.20316-1-brad@pensando.io> <20210329015938.20316-2-brad@pensando.io> In-Reply-To: From: Brad Larson Date: Sun, 22 Aug 2021 18:22:39 -0700 Message-ID: Subject: Re: [PATCH v2 01/13] gpio: Add Elba SoC gpio driver for spi cs control To: Andy Shevchenko Cc: linux-arm Mailing List , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , devicetree , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210822_182252_032802_1AAF786E X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Mon, Mar 29, 2021 at 3:41 AM Andy Shevchenko wrote: > > On Mon, Mar 29, 2021 at 5:01 AM Brad Larson wrote: > > > > This GPIO driver is for the Pensando Elba SoC which > > provides control of four chip selects on two SPI busses. [...] > > +MODULE_LICENSE("GPL v2"); > > +MODULE_DESCRIPTION("Pensando Elba SoC SPI chip-select driver"); > > It's funny, you told it can't be a module and you add a dead code. Be > somehow consistent, please. Yes the code was not consistent with statement that the module cannot being loadable in my reply. I had not used builtin_platform_driver() previously. The updated patchset will be changed to this for the driver. -module_platform_driver(elba_spics_driver); - -MODULE_LICENSE("GPL v2"); -MODULE_DESCRIPTION("Elba SPI chip-select driver"); +builtin_platform_driver(elba_spics_driver); where drivers/gpio/Kconfig could be changed to this --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -241,10 +241,8 @@ config GPIO_EIC_SPRD Say yes here to support Spreadtrum EIC device. config GPIO_ELBA_SPICS - bool "Pensando Elba SPI chip-select" + def_bool y depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST - help - Say yes here to support the Pensando Elba SoC SPI chip-select driver Regards, Brad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel