From mboxrd@z Thu Jan  1 00:00:00 1970
From: ohad@wizery.com (Ohad Ben-Cohen)
Date: Thu, 24 Jul 2014 16:45:44 +0300
Subject: [PATCH 1/2] hwspinlock/omap: enable module before reading
 SYSSTATUS register
In-Reply-To: <1404342060-2919-2-git-send-email-s-anna@ti.com>
References: <1404342060-2919-1-git-send-email-s-anna@ti.com>
 <1404342060-2919-2-git-send-email-s-anna@ti.com>
Message-ID: <CAK=Wgba3OOgZG_smj5=raE+ZXZ-F0ksn4pcGeDc1JDE34Q-wFg@mail.gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Suman,

On Thu, Jul 3, 2014 at 2:00 AM, Suman Anna <s-anna@ti.com> wrote:
> The number of hwspinlocks are determined based on the value read
> from the IP block's SYSSTATUS register. However, the module may
> not be enabled and clocked, and the read may result in a bus error.
>
> This particular issue is seen rather easily on AM33XX, since the
> module wakeup is software controlled, and it is disabled out of
> reset. Make sure the module is enabled and clocked before reading
> the SYSSTATUS register.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
...
> +       /*
> +        * runtime PM will make sure the clock of this module is
> +        * enabled again iff at least one lock is requested
> +        */
> +       ret = pm_runtime_put_sync(&pdev->dev);

Is there a specific reason for using the put_sync variant here? If
not, let's just use the regular put().

Let me know, and I can do the change while applying these two patches.

Thanks,
Ohad.