From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBFFEC00144 for ; Mon, 1 Aug 2022 04:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vz0+lL1qJoFz5xKd6mK+diaHP2NwZYoXggR8v+NPHZ0=; b=C2/30HzpnQRQjh Adyog10YYuLkrMPHQtdZuZhohlm8gHqxOHOH5B+UOmFw2COsAJaUabGaGq5yNhcKIXZllGgu4vG+H w3sseFiLjC7UpdT0tg393zMgqm525SNxVjm9i+Ovm/fpFRSD8kObrVa+LnEFz22xGogtsViQ/HLVx di6u0OV9mXKZ6IuM8YJwlq1W0IyKa153PwsG9kTDS+6tlaDRPjSR8FNXqEdOC/AjMLGPYsIxfdXZB p5JSLlmOj5Pe00HOFBVOjlyziTEsW97LkM2BGUq1gBgH7Lw3MhMyHAdNwtkgnXm1Inkz0Ax+kqzch ceVShqoiPh9h8Ya8TJcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oINKn-001ryc-FU; Mon, 01 Aug 2022 04:47:17 +0000 Received: from mail-vk1-xa32.google.com ([2607:f8b0:4864:20::a32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oINKk-001rv8-HU for linux-arm-kernel@lists.infradead.org; Mon, 01 Aug 2022 04:47:16 +0000 Received: by mail-vk1-xa32.google.com with SMTP id n15so4978656vkk.8 for ; Sun, 31 Jul 2022 21:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:sender:from:date:message-id :subject:to:cc; bh=Lw6ftY/TKlMb6+me9g+W5uZ99+C7bnz14lMwnr8n6c4=; b=BivyfpXPh+b5BrckNjDolRmC/G0BCa132qwkYm/uOKn0qBhRgcfnEGfELdMx74doVO NWjYAZ+hUT4OSrptv7Nafz/y4Mo7nXoTpKgsOj7YIPXHbXpTbGpdL81j3aIz9UxZVUhq OIRZKaW+j4qXI8C7riokWIyOjiC30f2otq93U9ZLTccOpwgqJPfoZ5rr/rgP1Bxu+PYm EHvyL4fw31d0BKURn3Ivz/le3NSEcHiGCNPOM+PQUxa8s2egUdPIpamSVu7mrrnEy7mW g+Co3xuU+IWGzAQHti29kkt4PYVMe+gvvhl2gjgsPRT2KUJvsFM9zpYDELCeHCbe6PFN jvDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:sender:from :date:message-id:subject:to:cc; bh=Lw6ftY/TKlMb6+me9g+W5uZ99+C7bnz14lMwnr8n6c4=; b=AkFH0kgVhZ1+MMN3ZZ+HetkAZQ614FTPwHGrxGvt6r781RHQzHwdXNhrZl9/T9dAG5 T3zLwTlHmte/FRH4eQwfs9ueelUTBR2RV9nNtOBFcaLX7e6+IOuj8yCy2sph9NOe4FWG z6Xp/B8/o88zOmVJB5GD9bXxy7ZBiM2w4wxi+Y6qT4mSON9KQbU1AZTiKDDgC8ZyDB8L 9APJeisGMz9/D/FK0tHMhXGAzZ/xFfzj4y8kB7RIUm9PI20QY7Wg2RhoerqV4CXV250p 1YNW0FyIFSaJsPpDULRKkmPUWT7A9BgXSaGJ6vLSGFM4uVfHlEtSI2ozteqYrtSzJNC4 60LQ== X-Gm-Message-State: ACgBeo2BQKJrDM1n7cSP61JhGdMNSloGMa7X/n+doOBqgCfa4chKDF4a YB+Iq2NIlLsnHRLKUBNmxGLXsbYkQkm844M2bpQ= X-Google-Smtp-Source: AA6agR6BBWM7q0N4oPiUYv0EGCG/OK3dmvKCfZPyMNQt8ZobjEPOOwF15DS7dBfG3tpXHcif9HtzVL92A6o+Qt952ak= X-Received: by 2002:a1f:34d8:0:b0:377:142f:3e2f with SMTP id b207-20020a1f34d8000000b00377142f3e2fmr4440588vka.27.1659329231324; Sun, 31 Jul 2022 21:47:11 -0700 (PDT) MIME-Version: 1.0 References: <20220227205608.30812-1-cristian.marussi@arm.com> <20220227205608.30812-15-cristian.marussi@arm.com> In-Reply-To: <20220227205608.30812-15-cristian.marussi@arm.com> X-Google-Sender-Delegation: getarunks@gmail.com From: Arun KS Date: Mon, 1 Aug 2022 10:17:00 +0530 X-Google-Sender-Auth: xqremnycBgmRgYu3Ngu8pLSRFS8 Message-ID: Subject: Re: [RFC PATCH 14/16] firmware: arm_scmi: Add testing Voltage protocol support To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@huawei.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, peter.hilber@opensynergy.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220731_214714_630352_88B9E65A X-CRM114-Status: GOOD ( 24.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Cristian, On Mon, Feb 28, 2022 at 4:23 AM Cristian Marussi wrote: > > firmware: arm_scmi: Add testing Voltage protocol support > > Signed-off-by: Cristian Marussi > --- > .../arm_scmi/scmi_test_driver/Makefile | 2 +- > .../arm_scmi/scmi_test_driver/scmi_test.c | 2 + > .../arm_scmi/scmi_test_driver/test_common.h | 1 + > .../arm_scmi/scmi_test_driver/test_voltages.c | 51 +++++++++++++++++++ > 4 files changed, 55 insertions(+), 1 deletion(-) > create mode 100644 drivers/firmware/arm_scmi/scmi_test_driver/test_voltages.c > > diff --git a/drivers/firmware/arm_scmi/scmi_test_driver/Makefile b/drivers/firmware/arm_scmi/scmi_test_driver/Makefile > index 68a3d94a6a88..3b7df18de250 100644 > --- a/drivers/firmware/arm_scmi/scmi_test_driver/Makefile > +++ b/drivers/firmware/arm_scmi/scmi_test_driver/Makefile > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0-only > scmi_test_driver-objs := scmi_test.o test_common.o test_clocks.o test_sensors.o \ > - test_powers.o > + test_powers.o test_voltages.o > obj-$(CONFIG_ARM_SCMI_TEST_DRIVER) += scmi_test_driver.o > > diff --git a/drivers/firmware/arm_scmi/scmi_test_driver/scmi_test.c b/drivers/firmware/arm_scmi/scmi_test_driver/scmi_test.c > index df0d3e572010..2ca9f82c5bf3 100644 > --- a/drivers/firmware/arm_scmi/scmi_test_driver/scmi_test.c > +++ b/drivers/firmware/arm_scmi/scmi_test_driver/scmi_test.c > @@ -26,6 +26,7 @@ int (*scmi_test_init[SCMI_MAX_PROTOCOLS])(struct scmi_test_setup *) = { > [SCMI_PROTOCOL_POWER] = scmi_test_power_init, > [SCMI_PROTOCOL_CLOCK] = scmi_test_clock_init, > [SCMI_PROTOCOL_SENSOR] = scmi_test_sensor_init, > + [SCMI_PROTOCOL_VOLTAGE] = scmi_test_voltage_init, > }; > > static void > @@ -125,6 +126,7 @@ static int scmi_testing_probe(struct scmi_device *sdev) > } > > static const struct scmi_device_id scmi_id_table[] = { > + { SCMI_PROTOCOL_VOLTAGE, "__scmi_test-voltage" }, > { SCMI_PROTOCOL_CLOCK, "__scmi_test-clock" }, > { SCMI_PROTOCOL_SENSOR, "__scmi_test-sensor" }, > { SCMI_PROTOCOL_POWER, "__scmi_test-power" }, > diff --git a/drivers/firmware/arm_scmi/scmi_test_driver/test_common.h b/drivers/firmware/arm_scmi/scmi_test_driver/test_common.h > index 9f3d35ba4477..338b65da593f 100644 > --- a/drivers/firmware/arm_scmi/scmi_test_driver/test_common.h > +++ b/drivers/firmware/arm_scmi/scmi_test_driver/test_common.h > @@ -102,6 +102,7 @@ int scmi_test_release(struct inode *ino, struct file *filp); > > int scmi_test_clock_init(struct scmi_test_setup *tsp); > int scmi_test_sensor_init(struct scmi_test_setup *tsp); > +int scmi_test_voltage_init(struct scmi_test_setup *tsp); > int scmi_test_power_init(struct scmi_test_setup *tsp); > > #endif /* __SCMI_TEST_COMMON_H */ > diff --git a/drivers/firmware/arm_scmi/scmi_test_driver/test_voltages.c b/drivers/firmware/arm_scmi/scmi_test_driver/test_voltages.c > new file mode 100644 > index 000000000000..ab91080e3a0f > --- /dev/null > +++ b/drivers/firmware/arm_scmi/scmi_test_driver/test_voltages.c > @@ -0,0 +1,51 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * SCMI Testing Driver - Voltage Protocol > + * > + * Copyright (C) 2022 ARM Ltd. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "test_common.h" > + > +struct scmi_voltage_data { > + unsigned int version; > + int count; > +}; > + > +int scmi_test_voltage_init(struct scmi_test_setup *tsp) > +{ > + struct scmi_voltage_data *vdata; > + struct device *dev = &tsp->sdev->dev; > + const struct scmi_voltage_proto_ops *voltage_ops; > + > + vdata = devm_kzalloc(dev, sizeof(*vdata), GFP_KERNEL); > + if (!vdata) > + return -ENOMEM; > + > + voltage_ops = tsp->ops; > + vdata->version = voltage_ops->version_get(tsp->ph); > + vdata->count = voltage_ops->num_domains_get(tsp->ph); > + > + if (vdata->count <= 0) { > + dev_err(dev, "number of voltage doms invalid: %d\n", > + vdata->count); > + return vdata->count ?: -EINVAL; > + } > + > + dev_info(dev, "Found %d voltage resources.\n", vdata->count); > + > + tsp->priv = vdata; > + debugfs_create_x32("version", 0400, tsp->parent, &vdata->version); Any particular reason, why we are not creating debugfs entires for regulator level_get/level_set like it was done for clocks(rate_get_set)? > + > + return 0; > +} > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel