From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F2BAC31E5E for ; Tue, 18 Jun 2019 09:46:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 677372070B for ; Tue, 18 Jun 2019 09:46:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HcR4IMjY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KoP3nBVt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 677372070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JzQ30X44Xjjqb7uf0owoumRrxZ54R6HcMCuQtKIoM3Q=; b=HcR4IMjYjUJFCG 8xwvpNUhsexwQAuu68NO41z7IoxNkjSm0bULNUNssOkGKYn8Zcvey7Zg+dA1U4LeSy1gSqNQcgPDS CmzN+zxhTKd4RDY/iSy7ZQoLwtdd3QiwoR+iXn07mTu/QvWu59NlJ+mCu1FAX0CDKQUtrEyOY4Nsy yzo+AtHzLSRWTI1mwNVMeozmhCegSRi1pc9Skza8tyFhWgDrbljQXHODDvBZ8xzVJFj2GQHfqI6z1 sOiUw5s7UpIvuMenS7z6Omz6P3tkNssJryOOvIA1pjvH6OalowjTdEmPtCsNJ+psvne3lwfmGsN2M CnVy1J8FLlQEqYQV354A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdAgq-00046Q-3V; Tue, 18 Jun 2019 09:46:08 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdAgn-00045l-0R for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2019 09:46:06 +0000 Received: by mail-lj1-x242.google.com with SMTP id k18so12372193ljc.11 for ; Tue, 18 Jun 2019 02:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dFNO/LKvYXvmFansFhyqwV2emff3osiWobNFjm+LOZY=; b=KoP3nBVtEN46bstqiMPFdsUTbbPqY93iN7frcTYWr8sCkKcBebn35gCjj5jqcvfKhd fAuG3oSUIsxzueLCci8XKFWf5vyJEcjs8vc/tenn/7tedfBJnIjkrUS2emDtyh1XcVKN oJDo3aSm0I9kNs8kSqe8S7BpxGPY/S1XIGyrpqJwXiVoAjJ21EkDkul6gD/j+g2k7chV 1q8IYd1jAabrLTjzTFW+sNKXtfxKxoVVe4Tv2xbq9ilJGzSX2Xwu1c6FkoVxQK/B9d7O 5xswsVa1q7duPRYnUKJhxEn70tEaolrLmQiQYoN4UFh8A5Cuug+J++VyRPd/hcvZEWkl 4ciw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dFNO/LKvYXvmFansFhyqwV2emff3osiWobNFjm+LOZY=; b=CMYJT9nAaUmtTsycZnZH9uPI6wALzfndt6cMxzlSe+CcRyp9MeuFmZ6qzgdojgLmEC kDiZcIdG3wxnnaiviGt7MutX/LaQgzjM8jFskVxFekY8/Nxf+lGshViV6EwIXxmSkPNY n4QOM3JrpitoIT92zFWkAiX9fD7uHONPHgpJU3xQiwADPqn1TlWhoxPwafnB6rLLOBea jc4WK+oq1l/E7jZmHVHJB/6FcGgxAY5NmsohIGYIom9FifxwiGkQzr47uzaO9+HHyhz1 KLkt3K1GE0FWyohgEc2fhQgAqiX8QTpRlzQ8IbIm2Xxn8Prf8P9kVHT4KMzONVpZ9dtD UbRw== X-Gm-Message-State: APjAAAWz1drG75T/xATn03m7NQSV51bQTt0yEoznNy8W6hLbYAlBlyRD d9F0HBWJcualqKFOowZ9X39A3LMH2pR2SeUDQY4JxQ== X-Google-Smtp-Source: APXvYqwLdmo7/UQzJICTwX7MmW1II8rP/12ROJHu2fbSKBjfNIwSirb55B1kWr5B7bMLEWjTiNO044PrL3t15XUYJ7U= X-Received: by 2002:a2e:1290:: with SMTP id 16mr43089752ljs.88.1560851163194; Tue, 18 Jun 2019 02:46:03 -0700 (PDT) MIME-Version: 1.0 References: <1560783617-5827-1-git-send-email-vincent.guittot@linaro.org> <20190618093453.GN3436@hirez.programming.kicks-ass.net> In-Reply-To: <20190618093453.GN3436@hirez.programming.kicks-ass.net> From: Vincent Guittot Date: Tue, 18 Jun 2019 11:45:52 +0200 Message-ID: Subject: Re: [PATCH] sched/topology: remove unused sd param from arch_scale_cpu_capacity() To: Peter Zijlstra X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190618_024605_052325_75585C13 X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:THERMAL" , "gregkh@linuxfoundation.org" , "Rafael J. Wysocki" , Russell King , linux-kernel , Quentin Perret , Ingo Molnar , viresh kumar , Valentin Schneider , LAK Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 18 Jun 2019 at 11:34, Peter Zijlstra wrote: > > On Mon, Jun 17, 2019 at 06:07:29PM +0100, Valentin Schneider wrote: > > Hi, > > > > On 17/06/2019 16:00, Vincent Guittot wrote: > > > struct sched_domain *sd parameter is not used anymore in > > > arch_scale_cpu_capacity() so we can remove it. > > > > > > > I think it can't hurt to give a bit of background. The *sd parameter used > > to be there for smt_gain, which got snipped out by: > > > > 765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'") > > > > I'd appreciate having that commit mentioned in the log. > > > > > Signed-off-by: Vincent Guittot > > > > Other than that, the changes look fine to me. > > > > Reviewed-by: Valentin Schneider > > The commit log now reads: > > --- > The 'struct sched_domain *sd' argument to arch_scale_cpu_capacity() is > unused since commit: > > 765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'") > > remove it. > --- Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel