Re: [PATCH v3 03/16] arm64: Allow IPIs to be handled as normal interrupts

From: Vincent Guittot <vincent.guittot@linaro.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Sumit Garg <sumit.garg@linaro.org>,
	Android Kernel Team <kernel-team@android.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King <linux@arm.linux.org.uk>,
	Jason Cooper <jason@lakedaemon.net>,
	Saravana Kannan <saravanak@google.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Gregory Clement <gregory.clement@bootlin.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Will Deacon <will@kernel.org>,
	Valentin Schneider <Valentin.Schneider@arm.com>,
	LAK <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 03/16] arm64: Allow IPIs to be handled as normal interrupts
Date: Tue, 27 Oct 2020 11:12:15 +0100	[thread overview]
Message-ID: <CAKfTPtBURraZh8E8p3PmncoDRVV5N42yTyJcpPf0OROciM2+xg@mail.gmail.com> (raw)
In-Reply-To: <CAKfTPtBjw5ay_BcPmEXpHOHbNxNZuYmdCoHQM53u3c+RXnKONg@mail.gmail.com>

HI Marc,

On Mon, 19 Oct 2020 at 17:43, Vincent Guittot
<vincent.guittot@linaro.org> wrote:
>
> On Mon, 19 Oct 2020 at 15:04, Marc Zyngier <maz@kernel.org> wrote:
> >

...

> > >>
> > >> One of the major difference is that we end up, in some cases
> > >> (such as when performing IRQ time accounting on the scheduler
> > >> IPI), end up with nested irq_enter()/irq_exit() pairs.
> > >> Other than the (relatively small) overhead, there should be
> > >> no consequences to it (these pairs are designed to nest
> > >> correctly, and the accounting shouldn't be off).
> > >
> > > While rebasing on mainline, I have faced a performance regression for
> > > the benchmark:
> > > perf bench sched pipe
> > > on my arm64 dual quad core (hikey) and my 2 nodes x 112 CPUS (thx2)
> > >
> > > The regression comes from:
> > > commit: d3afc7f12987 ("arm64: Allow IPIs to be handled as normal
> > > interrupts")
> >
> > That's interesting, as this patch doesn't really change anything (most
> > of the potential overhead comes in later). The only potential overhead
> > I can see is that the scheduler_ipi() call is now wrapped around
> > irq_enter()/irq_exit().
> >
> > >
> > >           v5.9              + this patch
> > > hikey :   48818(+/- 0.31)   37503(+/- 0.15%)  -23.2%
> > > thx2  :  132410(+/- 1.72)  122646(+/- 1.92%)   -7.4%
> > >
> > > By + this patch,  I mean merging branch from this patch. Whereas
> > > merging the previous:
> > > commit: 83cfac95c018 ("genirq: Allow interrupts to be excluded from
> > > /proc/interrupts")
> > >  It doesn't show any regression
> >
> > Since you are running perf, can you spot where the overhead occurs?

Any idea about the root cause of the regression ?
I have faced it on more arm64 platforms in the meantime

>
> hmm... Difficult to say because tracing the bench decreases a lot the
> result. I have pasted the perf reports.
>
> With this patch :
>
> # Samples: 634  of event 'cpu-clock'
> # Event count (approx.): 158500000
> #
> # Overhead  Command     Shared Object       Symbol
> # ........  ..........  ..................  ..................................
> #
>     31.86%  sched-pipe  [kernel.kallsyms]   [k] _raw_spin_unlock_irqrestore
>      8.68%  sched-pipe  [kernel.kallsyms]   [k] _raw_spin_unlock_irq
>      6.31%  sched-pipe  [kernel.kallsyms]   [k] __schedule
>      5.21%  sched-pipe  [kernel.kallsyms]   [k] schedule
>      4.73%  sched-pipe  [kernel.kallsyms]   [k] pipe_read
>      3.31%  sched-pipe  [kernel.kallsyms]   [k] el0_svc_common.constprop.3
>      2.84%  sched-pipe  [kernel.kallsyms]   [k] ww_mutex_lock_interruptible
>      2.52%  sched-pipe  [kernel.kallsyms]   [k] init_wait_entry
>      2.37%  sched-pipe  [kernel.kallsyms]   [k] mutex_unlock
>      2.21%  sched-pipe  [kernel.kallsyms]   [k] new_sync_read
>      1.89%  sched-pipe  [kernel.kallsyms]   [k] new_sync_write
>      1.74%  sched-pipe  [kernel.kallsyms]   [k] security_file_permission
>      1.74%  sched-pipe  [kernel.kallsyms]   [k] vfs_read
>      1.58%  sched-pipe  [kernel.kallsyms]   [k] __my_cpu_offset
>      1.26%  sched-pipe  libpthread-2.24.so  [.] 0x0000000000010a2c
>      1.10%  sched-pipe  [kernel.kallsyms]   [k] mutex_lock
>      1.10%  sched-pipe  [kernel.kallsyms]   [k] vfs_write
>
> After reverting this patch which gives a result similar to v5.9:
>
> # Samples: 659  of event 'cpu-clock'
> # Event count (approx.): 164750000
> #
> # Overhead  Command     Shared Object       Symbol
> # ........  ..........  ..................  ...............................
> #
>     29.29%  sched-pipe  [kernel.kallsyms]   [k] _raw_spin_unlock_irqrestore
>     21.40%  sched-pipe  [kernel.kallsyms]   [k] _raw_spin_unlock_irq
>      4.86%  sched-pipe  [kernel.kallsyms]   [k] pipe_read
>      4.55%  sched-pipe  [kernel.kallsyms]   [k] ww_mutex_lock_interruptible
>      2.88%  sched-pipe  [kernel.kallsyms]   [k] __schedule
>      2.88%  sched-pipe  [kernel.kallsyms]   [k] _raw_spin_lock_irqsave
>      2.88%  sched-pipe  [kernel.kallsyms]   [k] schedule
>      2.12%  sched-pipe  [kernel.kallsyms]   [k] new_sync_read
>      1.82%  sched-pipe  [kernel.kallsyms]   [k] mutex_lock
>      1.67%  sched-pipe  [kernel.kallsyms]   [k] el0_svc_common.constprop.3
>      1.67%  sched-pipe  [kernel.kallsyms]   [k] pipe_write
>      1.21%  sched-pipe  [kernel.kallsyms]   [k] rw_verify_area
>      1.21%  sched-pipe  [kernel.kallsyms]   [k] security_file_permission
>      1.06%  sched-pipe  [kernel.kallsyms]   [k] fsnotify
>
> I have only put symbol with overhead above 1%
>
> so _raw_spin_unlock_irq, schedule and __schedule seem the most
> impacted but i can't get any conclusion
>
> I can sent you perf.data files if you want
>
>
> >
> > Thanks,
> >
> >          M.
> > --
> > Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel