From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EFA6C433FE for ; Tue, 23 Nov 2021 13:31:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eWn4L3zL3lqWQlND2H0QrU25XfjDPs/dKPtKEDz0YMY=; b=TLWf+QBCD7LJVN WY2AIefHlp/tTM/1X9OSN5j3ysymCa8nsshSd8i8kLIrZ9twSAd3DeMbE0eJ6IWTcQncrBAiohny6 wuFSo1BcWotK4Q1PswYjdqPotnJwQPpjwUuR/nhOMYKpWWfJd0ddbIaDK3sWDvkdsoG51nJSOVcgT px0kkjgoTcQbHYEbivfpSQo09xXS0BRKifJh8TBLydpY+K2sAJP+ZoQXyOyNwmqqIkPyYZEW26xv8 lcFLLuFTk6e6piBpNF8MY/B4vwhpflAn6zonPRf2YRzfPsTC6yaHOjISJqB9yPnBoHljprGo/h25s 7de9CwDNgNBN9IQem6FQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpVry-002Nr5-9W; Tue, 23 Nov 2021 13:29:58 +0000 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpVrt-002Nq7-GL for linux-arm-kernel@lists.infradead.org; Tue, 23 Nov 2021 13:29:55 +0000 Received: by mail-io1-xd36.google.com with SMTP id w22so27989440ioa.1 for ; Tue, 23 Nov 2021 05:29:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1mzzQH4LR8E9en0oLHeEKt75OwAJ6GPgE1N3vKIF5Ws=; b=EIo2zpjMsvO81Q+EI8R8OfQZEXUoQwQClX2UVj0GR1MrfeNV9a2+iuM6IKMbfJesVu 5W++R+mfnHKAUBjb2m6wPb6Sfqmep6qhLW5scVdDgAqj3KvBsvWJ9c5XPr6tFEgvtpQV e6nwS00xARewgIe5CpUn3IH9LWwEJ05wjGn8v7yaoRz9h8inoXZiIiq84LNAITBaJQpV 7K3P5Jp7/mXCjZuHeuaujwziT+pycwl9fWiyw5X8zWIxxcE8QOQHQujCuZwBbnVWt64V 7jXjBqcQATkgPpUKl/jNmU4MZRgd1ahChBNZ+dhDBnV44dn8DOUvmWaeGA68tZpWYOuP LgYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1mzzQH4LR8E9en0oLHeEKt75OwAJ6GPgE1N3vKIF5Ws=; b=1yk/uUPcXO+LE/dcREud2PIAqobO1caRP6efOr9xRoFFqxc6sI+szeGocKTaSoJCfZ nCEhXv0XdkqCq2QAWAWLGJ/GNBMImkf7U63NOt7ePZcGt7Ks34r6xm7Ozv9gumSm/LPj U5lThMAKh2+7i4okAxj6ez55Z74reyvP3lMF/ci0BflrZyP2stZHreLAxLLCnXNPflEz QQLP5spi+EF0HoxE+qu1pCtxdXFmlUvyFhVAvzkLH3cvyF+FhbczH1lj0Fpuc0+i2dCi RrVXjx6XCONGhxTWLZU+y0ju89CPG3Lpu3WpEnbrijZybe43naE4LV/2DNcFl0lNEYGm MjUg== X-Gm-Message-State: AOAM533NvVroPN+V/Qngt45hOtYvRNrZSzxdv4+D0fC9dvvbD0QYDu1m MQsxZONbRvcSy48fakeHj0haFWHNxnxCfy79EhE= X-Google-Smtp-Source: ABdhPJwMXgvkb/4JorRGYlbB9RBc9fTrr+yiBWVTdyS2Dguc9dZBlAvAFOrg/Q3ogahTOw2JtEq0LxkF6gaQvD7d6os= X-Received: by 2002:a6b:ea0a:: with SMTP id m10mr5581825ioc.91.1637674192312; Tue, 23 Nov 2021 05:29:52 -0800 (PST) MIME-Version: 1.0 References: <20211110122948.188683-1-alistair@alistair23.me> <20211110122948.188683-2-alistair@alistair23.me> <20211117223950.3a7eaf7a@aktux> In-Reply-To: <20211117223950.3a7eaf7a@aktux> From: Alistair Francis Date: Tue, 23 Nov 2021 23:29:26 +1000 Message-ID: Subject: Re: [PATCH v15 1/8] dt-bindings: mfd: Initial commit of silergy, sy7636a.yaml To: Andreas Kemnade Cc: Alistair Francis , Lee Jones , Mark Brown , Sascha Hauer , lgirdwood@gmail.com, Rob Herring , Linux Kernel Mailing List , rui.zhang@intel.com, devicetree , linux-arm-kernel , Sascha Hauer , linux-hwmon@vger.kernel.org, amitk@kernel.org, linux-pm@vger.kernel.org, dl-linux-imx , Shawn Guo , Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211123_052953_666641_95646F20 X-CRM114-Status: GOOD ( 29.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 18, 2021 at 7:40 AM Andreas Kemnade wrote: > > On Wed, 10 Nov 2021 22:29:41 +1000 > Alistair Francis wrote: > > > Initial support for the Silergy SY7636A Power Management chip > > and regulator. > > > > Signed-off-by: Alistair Francis > > Reviewed-by: Rob Herring > > Acked-for-MFD-by: Lee Jones > > --- > > .../bindings/mfd/silergy,sy7636a.yaml | 79 +++++++++++++++++++ > > 1 file changed, 79 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml > > > > diff --git a/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml > > new file mode 100644 > > index 000000000000..0566f9498e2f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml > [...] > > + regulators: > > + type: object > > + > > + properties: > > + compatible: > > + const: silergy,sy7636a-regulator > > + > > + vcom: > > + type: object > > + $ref: /schemas/regulator/regulator.yaml# > > + properties: > > + regulator-name: > > + const: vcom > > + > hmm, this is what? If I understand it correctly, vcom means some > voltage for compensation. On other comparable pmics (e.g. TPS65185 > which has also a sane public datasheet, MAX17135) I have seen some > methods to measure a voltage while the display is doing something > defined and then program this voltage non-volatile for compensation > during manufacturing. > > If I understand the code correctly all the bunch of voltages are > powered up if this one is enabled. > So at least a description should be suitable. > > The other comparable PMICs have at least regulators named VCOM, DISPLAY > (controls several regulators, started with delays configured via > registers) and V3P3. MAX17135 source can be found in NXP kernels, > TPS65185 in Kobo vendor kernels. > > So I would expect to see something similar here and a description or at > least not such a misleading name as vcom if it is for some reason not > feasible to separate the regulators. This is a vcom in the sense of voltage for compensation. We just currently don't support setting the vcom. I had a look at the Kobo code and this is similar to https://github.com/akemnade/linux/blob/kobo/epdc-pmic-5.15/drivers/regulator/sy7636-regulator.c#L614 So I think that vcom is still the appropriate name for this. Alistair > > Regards, > Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel