From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@linaro.org (Viresh Kumar) Date: Thu, 7 Mar 2013 09:46:16 +0800 Subject: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue In-Reply-To: References: <20130305105251.GL17833@n2100.arm.linux.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 7 March 2013 08:49, Harvey Harrison wrote: > On Wed, Mar 6, 2013 at 4:32 PM, Viresh Kumar wrote: > >> clk[cluster] = clk_get_sys(name, NULL); >> - if (!IS_ERR(clk[cluster])) { >> + if (!IS_ERR_OR_NULL(clk[cluster])) { >> pr_debug("%s: clk: %p & freq table: %p, cluster: %d\n", >> __func__, clk[cluster], freq_table[cluster], >> cluster); > > > You seem pretty attached to IS_ERR_OR_NULL here. Haha. Not really. I just wanted to get more logical conclusion out. Please check the other mail (where i would reply to Russell), which might have more discussion around this.