From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 475F1CA9EB5 for ; Mon, 21 Oct 2019 06:22:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E2DF206C2 for ; Mon, 21 Oct 2019 06:22:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NiKiNH+u"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GjbUSEjv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E2DF206C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=niovUW7GUTnmGb+tpLDc+qXJxV/mzUL6ptnF2z82McE=; b=NiKiNH+u2A8NGI Fsd9AkjMjantvmFXzVQPf50UeZ1u796v0ofmYMd7NItBYQ6nw2IRLmUSSgQUqEKxRV/sEnoMLx2b5 SlQ0Xv53WElgSYEHAvkyEYfiobnbO9VBPf8Z/KPlIm90BgcNDiQqTFdT3F02ke0CA3AAYFIZZEGs6 QTP8nMXGtd+KMx+77Vd7bztmcP9/bhFsSjgC0U0Ii29fxa2ccJELXb+xMKcBrXTntAwyeSD/srUQk O2BzSjIFbIcjYKKB9Y70ewEprT6HLfWfeI+JzQ5vGlSgLH666UGjlN+KL8WYCpG9dBNNbWmXS8NfJ K0NYD4MVW1Ajk92wkO/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMR4t-0004nS-QH; Mon, 21 Oct 2019 06:22:03 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMR4q-0004mu-Uo for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2019 06:22:02 +0000 Received: by mail-wm1-x342.google.com with SMTP id 14so4786381wmu.0 for ; Sun, 20 Oct 2019 23:22:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uyhVv4N2UiJ3EJxpaNQCWc5NdrhC/9AoAL7jZ85/7b8=; b=GjbUSEjvkAF47IsFWgAUnfSwZ9jZeOmpmmzg8L/6guVX38gCMZuouTdMO5Iji6ewM0 ZcqaKKfluXkc0GCek0xGcyop4JHYb97Q/n3Eqc7ah2EKKHr0N7BGDs851PPpZHuHqzCj Az8WGOd2xhVAFxxTDg1R2UqIdUdRXgD25JY9oY8pXU6I6vVvsfZ0aFENdmAVqf4UnUr8 lcQmqiLBmmkWCuTPfA0TxotJre4XtMv52V1BrM2hzvGfc4Miftl70l+50k9K9NVhoe2J xX9Fh2F8N7Dj2Pl0njY0mgUTPdAzdCBXsCb1ksBM0pvjzMtLDB5366phzKtAZjRMiTXL ANmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uyhVv4N2UiJ3EJxpaNQCWc5NdrhC/9AoAL7jZ85/7b8=; b=ekMkQy3y31yQVS609Nr1mG1u5LnrpggmKj/SzTtfBrfbMsT+UOtG/d26rvb6YYflJU gUt7+0oLmbQtt3E6vyHSywALv9jYLuTiv4azmy9ZvPP8tjrm7i47KZhacm1Zr9sPbNdh TlyxugKeyhAg38jVG0iBqQDiAPK83JkOyXl+mIuRoVDbQovZ9D5w/dFvTWgFAVM3o5wu yAE/kiivR1KTo8LAAoR8lDLQiksfxXsuyQyVo3W5rEGmv4kKYAYU18+HPaJvhIADdqn9 dkyddGLsGJ1z5rDFBVZj9q8uNmNJni87MsFe399BdGFejKDFnIxAeDEqP5tbeFT4u9yC 0bTg== X-Gm-Message-State: APjAAAW7rDNTnR2ucXb/hweUG3kVnSXkiahoOpyMpOkgc3O+UWvxOPKX 2HhDvYb29djo9akUmbnLol5umofDRdPTFpnnyOSJTA== X-Google-Smtp-Source: APXvYqx9wfbsml6zIZvtLXulYaMSgitt7ok8Qfrnv+GkD+c5R91Idi9S9ZV+WgZk06tMxv4wXfJaROot0zqVv9/hG5E= X-Received: by 2002:a7b:c925:: with SMTP id h5mr1847720wml.61.1571638919306; Sun, 20 Oct 2019 23:21:59 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-17-samitolvanen@google.com> In-Reply-To: <20191018161033.261971-17-samitolvanen@google.com> From: Ard Biesheuvel Date: Mon, 21 Oct 2019 08:21:48 +0200 Message-ID: Subject: Re: [PATCH 16/18] arm64: kprobes: fix kprobes without CONFIG_KRETPROBES To: Sami Tolvanen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191020_232200_992876_C0AD0A70 X-CRM114-Status: GOOD ( 13.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Kernel Hardening , Catalin Marinas , Nick Desaulniers , Linux Kernel Mailing List , Steven Rostedt , clang-built-linux , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 18 Oct 2019 at 18:11, Sami Tolvanen wrote: > > This allows CONFIG_KRETPROBES to be disabled without disabling > kprobes entirely. > > Signed-off-by: Sami Tolvanen Can we make kretprobes work with the shadow call stack instead? > --- > arch/arm64/kernel/probes/kprobes.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c > index c4452827419b..98230ae979ca 100644 > --- a/arch/arm64/kernel/probes/kprobes.c > +++ b/arch/arm64/kernel/probes/kprobes.c > @@ -551,6 +551,7 @@ void __kprobes __used *trampoline_probe_handler(struct pt_regs *regs) > return (void *)orig_ret_address; > } > > +#ifdef CONFIG_KRETPROBES > void __kprobes arch_prepare_kretprobe(struct kretprobe_instance *ri, > struct pt_regs *regs) > { > @@ -564,6 +565,7 @@ int __kprobes arch_trampoline_kprobe(struct kprobe *p) > { > return 0; > } > +#endif > > int __init arch_init_kprobes(void) > { > -- > 2.23.0.866.gb869b98d4c-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel