From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V17 03/11] cper: add timestamp print to CPER status printing
Date: Tue, 6 Jun 2017 09:25:55 +0000 [thread overview]
Message-ID: <CAKv+Gu8C+8gBA6cvmVjnRKBZnSVDbNghwd62KOAANGvm9PL8iQ@mail.gmail.com> (raw)
In-Reply-To: <1495225933-4410-4-git-send-email-tbaicar@codeaurora.org>
On 19 May 2017 at 21:32, Tyler Baicar <tbaicar@codeaurora.org> wrote:
> The ACPI 6.1 spec added a timestamp to the generic error data
> entry structure. Print the timestamp out when printing out the
> error information.
>
> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
> CC: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> drivers/firmware/efi/cper.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
> index 9024757..229cf92 100644
> --- a/drivers/firmware/efi/cper.c
> +++ b/drivers/firmware/efi/cper.c
> @@ -32,6 +32,8 @@
> #include <linux/acpi.h>
> #include <linux/pci.h>
> #include <linux/aer.h>
> +#include <linux/printk.h>
> +#include <linux/bcd.h>
> #include <acpi/ghes.h>
>
> #define INDENT_SP " "
> @@ -387,6 +389,27 @@ static void cper_print_pcie(const char *pfx, const struct cper_sec_pcie *pcie,
> pfx, pcie->bridge.secondary_status, pcie->bridge.control);
> }
>
> +static void cper_print_tstamp(const char *pfx,
> + struct acpi_hest_generic_data_v300 *gdata)
> +{
> + __u8 hour, min, sec, day, mon, year, century, *timestamp;
> +
> + if (gdata->validation_bits & ACPI_HEST_GEN_VALID_TIMESTAMP) {
> + timestamp = (__u8 *)&(gdata->time_stamp);
> + sec = bcd2bin(timestamp[0]);
> + min = bcd2bin(timestamp[1]);
> + hour = bcd2bin(timestamp[2]);
> + day = bcd2bin(timestamp[4]);
> + mon = bcd2bin(timestamp[5]);
> + year = bcd2bin(timestamp[6]);
> + century = bcd2bin(timestamp[7]);
> +
> + printk("%s%ststamp: %02d%02d-%02d-%02d %02d:%02d:%02d\n", pfx,
> + (timestamp[3] & 0x1 ? "precise " : "imprecise "),
> + century, year, mon, day, hour, min, sec);
> + }
> +}
> +
> static void
> cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdata,
> int sec_no)
> @@ -395,6 +418,9 @@ static void cper_print_pcie(const char *pfx, const struct cper_sec_pcie *pcie,
> __u16 severity;
> char newpfx[64];
>
> + if (acpi_hest_get_version(gdata) >= 3)
> + cper_print_tstamp(pfx, (struct acpi_hest_generic_data_v300 *)gdata);
> +
> severity = gdata->error_severity;
> printk("%s""Error %d, type: %s\n", pfx, sec_no,
> cper_severity_str(severity));
> --
> Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
> Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-efi" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-06 9:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 20:32 [PATCH V17 00/11] Add UEFI 2.6 and ACPI 6.1 updates for RAS on ARM64 Tyler Baicar
2017-05-19 20:32 ` [PATCH V17 01/11] acpi: apei: read ack upon ghes record consumption Tyler Baicar
2017-06-30 10:10 ` Robert Richter
2017-06-30 16:47 ` Baicar, Tyler
2017-05-19 20:32 ` [PATCH V17 02/11] ras: acpi/apei: cper: add support for generic data v3 structure Tyler Baicar
2017-06-02 14:13 ` Will Deacon
2017-06-06 9:22 ` Ard Biesheuvel
2017-05-19 20:32 ` [PATCH V17 03/11] cper: add timestamp print to CPER status printing Tyler Baicar
2017-06-06 9:25 ` Ard Biesheuvel [this message]
2017-05-19 20:32 ` [PATCH V17 04/11] efi: parse ARM processor error Tyler Baicar
2017-05-19 20:32 ` [PATCH V17 05/11] arm64: exception: handle Synchronous External Abort Tyler Baicar
2017-05-19 20:32 ` [PATCH V17 06/11] acpi: apei: handle SEA notification type for ARMv8 Tyler Baicar
2017-05-19 20:32 ` [PATCH V17 07/11] acpi: apei: panic OS with fatal error status block Tyler Baicar
2017-05-19 20:32 ` [PATCH V17 08/11] efi: print unrecognized CPER section Tyler Baicar
2017-06-07 10:08 ` Ard Biesheuvel
2017-05-19 20:32 ` [PATCH V17 09/11] ras: acpi / apei: generate trace event for " Tyler Baicar
2017-05-19 20:32 ` [PATCH V17 10/11] trace, ras: add ARM processor error trace event Tyler Baicar
2017-05-19 20:32 ` [PATCH V17 11/11] arm/arm64: KVM: add guest SEA support Tyler Baicar
2017-05-23 9:30 ` [PATCH V17 00/11] Add UEFI 2.6 and ACPI 6.1 updates for RAS on ARM64 Borislav Petkov
2017-06-07 11:50 ` Will Deacon
2017-06-20 6:34 ` Robert Richter
2017-06-20 8:49 ` Will Deacon
2017-06-21 13:00 ` Robert Richter
2017-06-21 13:10 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu8C+8gBA6cvmVjnRKBZnSVDbNghwd62KOAANGvm9PL8iQ@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).