From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C847C2BCA1 for ; Fri, 7 Jun 2019 11:14:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 020492080C for ; Fri, 7 Jun 2019 11:14:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="okHGiD7J"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MacR0VqP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 020492080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OY+9OH7xNiYmCNVDDmVW7Ib1SBS6mdxnU2Vlkr0UkMw=; b=okHGiD7Jttf1z3 7qVcOqv5MjnPgnUxtQCiUBygkLTWkltKbbmMoIhWPXNlDCxU2QOXiRMwhw9U7/NXCGTYg/BOZ+i8t Pd6+ymemGardng0sR73KuP77s8FJZ0Kiocl94pBxz3+zisqRgViJkve3qSUyDTwPqcDg2Ljrnq7yn ereInecLOkMvHp0reZfG+u94BypswXb6tZv3mRHTiXoWWXkSgyGc/TPDDa61ef8yKEX0P3NneXRIV 1tohm/KlkXKwmXv4ks4ViwS+M/GK8WQyU7ZYaQdkNTh7Oia4hKHPw2DQvqK0clyKCR5GZQnmxWab+ dReQahLq/9/VBffVpyxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hZCpG-0002KL-Uu; Fri, 07 Jun 2019 11:14:26 +0000 Received: from mail-it1-x143.google.com ([2607:f8b0:4864:20::143]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hZCpD-0002Jy-KN for linux-arm-kernel@lists.infradead.org; Fri, 07 Jun 2019 11:14:25 +0000 Received: by mail-it1-x143.google.com with SMTP id m3so2109938itl.1 for ; Fri, 07 Jun 2019 04:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9U1m6mU0o53HGYsINghj1de9Jt3i01TslgdBoF3QrwI=; b=MacR0VqP+e/LNHHHQuou2MHyR6W6QxkTNEnDiK5lI8M7aHLncXKtaoTKYdFCsQX72L qu3tKnlTMSBlHkwbtZTgq5b0jT86j6z7YkfkrMLHw/LSeQj+Omf/ISmbDbNxkKY0MUXT Wd10yqhWQ4BwTiU3ZeJNWzMN52jGtaS7iIsV/kff/CHKc9ikFuiP5vykWc/KPFy/hkLz ptYNF+aGadrnxOU3q/6CK7i0cl+JuOpgYW+55gole9j3014kmyKS4tLPAZjqvFQIBvrA LYannl2TspRoHbjMbvP3/mqGIL2fg9bVimS5aw6V+VPR8huAlX3csYgQGznhDGBP3OS9 cHyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9U1m6mU0o53HGYsINghj1de9Jt3i01TslgdBoF3QrwI=; b=XVMja7MNTNe933qR9ieU+NSQlAHqkhjF+EixCBO4RdoiCxFWcnaqKDyg2ZU2kOnPsT Yapr2pZF3Jut+vRf/pQJSg3bnLRnYy4qIty4MXm2l3jkpmzdcm71J7/JqHZeNfV6IbYO t0xW+s0w5hc0hLlO3Ap15HsTpS4U5EVXzYlytJRktE3TN+SX5xQt1zB3oN9AzfqTtQPu QgXTqUpdvGi1weuNNV+JhXgnFtNex9UKfU6bLq5T1f/iFhuU7q65wkyyrT01JIntJHFM jNOKSUgHNzs8LtHtHIW3e/HHRGH24zDu61Hy3Fg64mYfRQjxnnyYtIYX2/XSGm4yq1HA ohcg== X-Gm-Message-State: APjAAAVgkJF97oVqwszKgv+kIEO0agOf2lbt/Xs6MB6rVRYdRKvm7sL8 whZwMic5LigYN9fMeEUof9DzLJFZmNqBnH9JroMDCg== X-Google-Smtp-Source: APXvYqzENbGZGC/Ro2itSzojufojUt2gHL5BHdEmWJb4hnH6XoyTXJ7GENrRhEovlhdSyuHemD+29fiW8fSjTNkqB7E= X-Received: by 2002:a24:740f:: with SMTP id o15mr3989343itc.76.1559906062309; Fri, 07 Jun 2019 04:14:22 -0700 (PDT) MIME-Version: 1.0 References: <20190607082901.6491-1-lee.jones@linaro.org> <20190607082901.6491-5-lee.jones@linaro.org> In-Reply-To: <20190607082901.6491-5-lee.jones@linaro.org> From: Ard Biesheuvel Date: Fri, 7 Jun 2019 13:14:11 +0200 Message-ID: Subject: Re: [PATCH v2 5/8] soc: qcom: geni: Add support for ACPI To: Lee Jones X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190607_041423_667446_6CC56FA9 X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, wsa+renesas@sang-engineering.com, Greg Kroah-Hartman , Linus Walleij , linux-usb , Linux Kernel Mailing List , Bjorn Andersson , David Brown , alokc@codeaurora.org, linux-i2c , "open list:GPIO SUBSYSTEM" , linux-arm-msm , Andy Gross , Jeffrey Hugo , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 7 Jun 2019 at 10:30, Lee Jones wrote: > > When booting with ACPI as the active set of configuration tables, > all; clocks, regulators, pin functions ect are expected to be at > their ideal values/levels/rates, thus the associated frameworks > are unavailable. Ensure calls to these APIs are shielded when > ACPI is enabled. > > Signed-off-by: Lee Jones > --- > drivers/soc/qcom/qcom-geni-se.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c > index 6b8ef01472e9..cff0a413e59a 100644 > --- a/drivers/soc/qcom/qcom-geni-se.c > +++ b/drivers/soc/qcom/qcom-geni-se.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > // Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. > > +#include > #include > #include > #include > @@ -450,6 +451,9 @@ int geni_se_resources_off(struct geni_se *se) > { > int ret; > > + if (ACPI_HANDLE(se->dev)) Please use has_acpi_companion() here > + return 0; > + > ret = pinctrl_pm_select_sleep_state(se->dev); > if (ret) > return ret; > @@ -487,6 +491,9 @@ int geni_se_resources_on(struct geni_se *se) > { > int ret; > > + if (ACPI_HANDLE(se->dev)) > + return 0; > + Same > ret = geni_se_clks_on(se); > if (ret) > return ret; > @@ -724,12 +731,14 @@ static int geni_se_probe(struct platform_device *pdev) > if (IS_ERR(wrapper->base)) > return PTR_ERR(wrapper->base); > > - wrapper->ahb_clks[0].id = "m-ahb"; > - wrapper->ahb_clks[1].id = "s-ahb"; > - ret = devm_clk_bulk_get(dev, NUM_AHB_CLKS, wrapper->ahb_clks); > - if (ret) { > - dev_err(dev, "Err getting AHB clks %d\n", ret); > - return ret; > + if (!ACPI_HANDLE(&pdev->dev)) { Same > + wrapper->ahb_clks[0].id = "m-ahb"; > + wrapper->ahb_clks[1].id = "s-ahb"; > + ret = devm_clk_bulk_get(dev, NUM_AHB_CLKS, wrapper->ahb_clks); > + if (ret) { > + dev_err(dev, "Err getting AHB clks %d\n", ret); > + return ret; > + } > } > > dev_set_drvdata(dev, wrapper); > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel