From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E5B3C2BB1D for ; Tue, 7 Apr 2020 12:00:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F143A20678 for ; Tue, 7 Apr 2020 12:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UCXRLRjl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="UynEai+I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F143A20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rB82YPym6tISvTVf072mO1wdrQpfmPB9YdERcHBzSwY=; b=UCXRLRjl5BMUuZ fvYLDt608WkH6NYPASUVPLHfQJJziAY5pq44zeYpn92H6TPJueMjADKQIgWXkEtocwScBgoX/uJYH X8BqCMoyESW8934+AwbTF6kPJoL9FOnhRQcjD9NCa9oWqHvISmLtzZNW5mkNGEL7xbAQ5Bx6nldpg hxrocSYfF3h9HOsrhSWoHz7YZTyvqX+hFYGmSwc53rWXdZj9v8X7WAM7R7/13O+hHbC9jZ1q+ENo/ rCMaYH5FJ8x2p8ezgfJMdyIKc46AnAqtyxUhcRJSZM0WvowWH4yZFFY2nA2bK/0wXG6K5Eeq26w20 8ZkyihL3okCV34a4AIfQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLmu7-0008Pu-7h; Tue, 07 Apr 2020 12:00:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLmu3-0008Ms-3j for linux-arm-kernel@lists.infradead.org; Tue, 07 Apr 2020 12:00:28 +0000 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A24832074B for ; Tue, 7 Apr 2020 12:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586260824; bh=Uqf4rhYga9NNaBB0Dvwp58Stj1GsGS4Ihxkd+ju3McQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=UynEai+Iomxc2OG8KYjK/KRD7a/dOOxnhwEmNPEDHEIlfRtBYPIwNjDmN6OEA/9ly cUMpN3ZxirencrZA4IoHgDxg+rqzfXd19T3f45flU3iNT4E+LyD1J4mbP/FVTbsn8V MdVqtkiIove/82erkXHXimJH8ISVg2vzZYIJmCS0= Received: by mail-wr1-f50.google.com with SMTP id k1so3591252wrm.3 for ; Tue, 07 Apr 2020 05:00:24 -0700 (PDT) X-Gm-Message-State: AGi0PuYo4BxeCzGzgD5SrOvyer+M6hnSMS2km5TXHEOzjQH0c1xGVQsR J/1YA5qmXUNW9dGsQ2Go5TdPugiF898t7rcknEZjvw== X-Google-Smtp-Source: APiQypJI+zUUJefqkI1wPoN1P7O6CrZHHpERpheNKfgg8qCaXTmeul5CgCiQbYpjls0Awj/83RzxNXZ+ny+VOSB9RbA= X-Received: by 2002:a05:6000:1002:: with SMTP id a2mr2399545wrx.151.1586260823114; Tue, 07 Apr 2020 05:00:23 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20200406164121.154322-1-samitolvanen@google.com> <20200406164121.154322-13-samitolvanen@google.com> In-Reply-To: <20200406164121.154322-13-samitolvanen@google.com> From: Ard Biesheuvel Date: Tue, 7 Apr 2020 14:00:12 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v10 12/12] efi/libstub: disable SCS To: Sami Tolvanen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200407_050027_172516_4B02D5CD X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Jann Horn , Masahiro Yamada , Catalin Marinas , Kernel Hardening , Nick Desaulniers , Linux Kernel Mailing List , Steven Rostedt , Miguel Ojeda , clang-built-linux , James Morse , Masami Hiramatsu , Marc Zyngier , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 6 Apr 2020 at 18:42, Sami Tolvanen wrote: > > Shadow stacks are not available in the EFI stub, filter out SCS flags. > > Suggested-by: James Morse > Signed-off-by: Sami Tolvanen Acked-by: Ard Biesheuvel > --- > drivers/firmware/efi/libstub/Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile > index 094eabdecfe6..fa0bb64f93d6 100644 > --- a/drivers/firmware/efi/libstub/Makefile > +++ b/drivers/firmware/efi/libstub/Makefile > @@ -32,6 +32,9 @@ KBUILD_CFLAGS := $(cflags-y) -DDISABLE_BRANCH_PROFILING \ > $(call cc-option,-fno-stack-protector) \ > -D__DISABLE_EXPORTS > > +# remove SCS flags from all objects in this directory > +KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) > + > GCOV_PROFILE := n > KASAN_SANITIZE := n > UBSAN_SANITIZE := n > -- > 2.26.0.292.g33ef6b2f38-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel