From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FFDFCA9EA0 for ; Tue, 22 Oct 2019 05:54:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B16B2089E for ; Tue, 22 Oct 2019 05:54:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pHflEsS6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VeZ/77yC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B16B2089E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yQeGi0x1Hb/VhMEIDFpv8KBkGrDgCivLWjG9ZeEpvlc=; b=pHflEsS6+OB3Yq y8FT4uM6mIVBOasJCpU9sg1Wb4yjqp0qWmSurQGFtRxJ2zB/fKLRN9TgeYkRUeuj7ZUHQT2m/Fc0t 7xgVfG2pQYW4AbvpDMhD+JK4D7Nj6H3+GSyl4zOF7kn0PSRJ6dqUf84DrD+MsAkvOKOltrq1Bu/uC /lbKdtT0zU3H3fO+IuRTmz/JBuKr54CWhA0+gOazD+FIbKgX/XYI0cTs050kCJ7HBxcTjAHR17EFd 84dZsfT4F5IDjO5I6Szfv624yL9ptRHEBj/Zbi744/2Z5kvjLa6vGsMNCqVS07dbT1CgA8FMo63rm /DVtSv8xrDjFC4tWvT7Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMn7a-00017Q-17; Tue, 22 Oct 2019 05:54:18 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMn7W-000126-QT for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2019 05:54:16 +0000 Received: by mail-wr1-x441.google.com with SMTP id q13so11485124wrs.12 for ; Mon, 21 Oct 2019 22:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=70+N4pxkreRk5D8qTuATktL5M/ApNQm1mVe3QKo4Ow8=; b=VeZ/77yCO2vkRreTdZF0BmlF3aBW7GYN63ztZ+W9IxGlyzot3aZzQG7XNVjBY7A7oD 5ErFNuJigjHDoajFcUUKer2ZNuRvqeRRkKDFwX0d2Zr1W2J0Sitj3DU47jafk1WpqrB9 RO+JgyMPsgCHPUuHfaLf9mhm0FhMWiroTQMq0AMJS2EyfB2q8y2Uj4BUJeCO2gXI9tCY 6QkWiBS+nVx6fiVGxPNCg3OkhqZK5Cxo3moubEo1LbU3pI9Z3P3SLfQSm8r4r1GEdvXM A3I5Jr0ovB215EmWyJbd+kRIvPhHLcOf8Yw0LDZ75fNBWsAH3Ssp+sYWHP4KD/+V8/GQ /NvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=70+N4pxkreRk5D8qTuATktL5M/ApNQm1mVe3QKo4Ow8=; b=axtccDvH+H4hRHCj8sAAcTv/lrpxGOlcWrSpERgVq5RLrwJlhvlWNP+sVQtq8fZ3qW 5yE3axxq6yq33xduxuK34FqtDYlW/kra881zP9mP1dEXzJcoqjl5v7fVo10GSzsyQsUZ OmokUIrtoM5KS+1uUuBZ1cVPzi6oIDNOo9nYDZ2ROmtAEq+MbJ8oSB/zSAcdhH2zmo4X vxm6RwgVf70/3GdzKoaP3Wxu1hbj0YBJXDN4rqvwpsUKy8RjDtfdyIFLUYJYoBSlLA3q 7vSIzsSG2R+6l+qUnccuqwX0Vl+dDGQLep3pLXoMcNzKfyTMxU5k20V+WMtlRND/LoPh b5VQ== X-Gm-Message-State: APjAAAVUmi+aab16JNDAx67XB8hrTXy+sKQ+RUa1R9BLCiUYVSJFNWnZ T7c1+FniqXeSQD7M2ymZj6kZ3rQ5JNQlNcs9z6rX2w== X-Google-Smtp-Source: APXvYqwrYnGYkoL34VBIT6H+JNjJm/uZwOLCkW8JDJj+1Q/w7n/LWtklQn1YWpTuz0AHRX28UXgTzenaMPN3dF2ZvS4= X-Received: by 2002:adf:9f08:: with SMTP id l8mr1573796wrf.325.1571723652654; Mon, 21 Oct 2019 22:54:12 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-15-samitolvanen@google.com> In-Reply-To: From: Ard Biesheuvel Date: Tue, 22 Oct 2019 07:54:07 +0200 Message-ID: Subject: Re: [PATCH 14/18] arm64: efi: restore x18 if it was corrupted To: Sami Tolvanen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191021_225414_868090_4EB55257 X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Kernel Hardening , Catalin Marinas , Nick Desaulniers , Linux Kernel Mailing List , Steven Rostedt , clang-built-linux , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Archived-At: List-Archive: On Tue, 22 Oct 2019 at 00:40, Sami Tolvanen wrote: > > On Sun, Oct 20, 2019 at 11:20 PM Ard Biesheuvel > wrote: > > You'll have to elaborate a bit here and explain that this is > > sufficient, given that we run EFI runtime services with interrupts > > enabled. > > I can add a note about this in v2. This is called with preemption > disabled and we have a separate interrupt shadow stack, so as far as I > can tell, this should be sufficient. Did you have concerns about this? > No concerns, but we should put the above clarification in the commit log. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel