From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC2E6C433FE for ; Thu, 6 Oct 2022 20:36:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RMFAnOqtKFZ6iCU5OVAR6y7fviqij7qUUiv36VCtlyM=; b=CHNnOAej/a8E4R SsF5l3KWlpDVihcvuXYtqXFBG5x05zQE+NTfCA0GfBQ43w2Y+vciQGb34Qdn2+QsYpBmFiP5CjqZ+ 5bhBe6YmqX51Eqx0+f7NgKdhXa128CxgcXyxP+Pam0TOeJA4wnBw4KeYNZslYNJHwcXMILbebXM/3 LUcIS8gnO6BDOCDDp3fqU3vL32KCnhagdPTWHQZyLNktzgzxei+itNZhyoQp3sRWUTgv+tvQJbdRY 72RD6KFsbweMr7UD+6skqUgyCVu4Btskv9c11vSYiXPtrTcUnhM4DM5i5B/s1SX0YIiOgDexMpVoH gJmd0XDrqniwqcjjMeFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogXaU-0054vM-Gq; Thu, 06 Oct 2022 20:35:22 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogXaR-0054tW-AY for linux-arm-kernel@lists.infradead.org; Thu, 06 Oct 2022 20:35:20 +0000 Received: by mail-pl1-x62c.google.com with SMTP id x1so2743871plv.5 for ; Thu, 06 Oct 2022 13:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=YrAC23faud15zS6eHd6bC3i2jrrjB6ysFBkxCYV0DUg=; b=VnvmXZkP0hhSETFJ7/rWObNvgVlwQNsO9Q6Wr+CY5AhJLWqAxw5ymAu+d5E1rrq4qi xtkMwQ6YDrHzIZayo7ZRhSzrDOrrFPnJhOXk4o7evz5s7x30Hn8I9naaZ0i069dQB/ph cnMQ55FQ011gtIYFCTqyzmJZqzabfBru2us/cJbxwS7Jb7TSyZcJOK7aqO0uOmoTQAcH GYFiGgWnKQU+ZbebJkkLcDLzUIDh8oQka9cmqiqC2XG21Fq/3L0j06kv3/yXoiZzN3Dc NqeD9ebVrKYIEEnneSVmz+ISDsgVMRU1uRoqaUUyEVUz6KnTZG9lz9xnlm/sH0mgGJ4X k7xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=YrAC23faud15zS6eHd6bC3i2jrrjB6ysFBkxCYV0DUg=; b=S2OhCWmDBCqlY+HA3UlETx0Vlnt+zFzio9QXeVJzM3TDxN3yu7CxQdZjIRv9hr0WaH 3pjTSxt0P8Pa43YQsbuLt+q1DMDbtEMrp9AfJFbFeTXsHG/Sqxzx51MhnoVyX3sEUEHv reipn1yuYdEIMuPrp+h2FjgnY2oX8j+aFQHtrq+Mjh/IZW5T6J4Rm3w8Ms9DnHO1VJ23 SyKJzUdr55LHNA8wd95OJhy0GcmUc0n/doju1G7EorFmR3Ck98e2Zn6aEPHkJqKrltBM AohANSxTNYB6zK2fD3M0Vt+kiEYDa+rxERJBWFe4etm8c08umMQ4mzXs5V70b6ac3Fd+ /weQ== X-Gm-Message-State: ACrzQf3Z9aqd5qE7HHpvuE+1QvxO0oBEmR4ncPWKhEKF0WTLDZ756nv6 6mWB3I91Rdy0C6v+wZJMbiJ85KdicxQZLpzUqAHZAQ== X-Google-Smtp-Source: AMsMyM4v3+jebTsx8rta3oTKTPbj+0QFRpgOMqqHaIV7tcXGfBpXOUbUwwIMLxbH/aI5igVtVyqUZJViZkQhI48Gf94= X-Received: by 2002:a17:902:7404:b0:17f:7fe6:7197 with SMTP id g4-20020a170902740400b0017f7fe67197mr1565798pll.94.1665088515406; Thu, 06 Oct 2022 13:35:15 -0700 (PDT) MIME-Version: 1.0 References: <202209291607.0MlscIht-lkp@intel.com> <20220930211505.209939-1-ndesaulniers@google.com> In-Reply-To: <20220930211505.209939-1-ndesaulniers@google.com> From: Nick Desaulniers Date: Thu, 6 Oct 2022 13:35:03 -0700 Message-ID: Subject: Re: [PATCH v3] ARM: kprobes: move __kretprobe_trampoline to out of line assembler To: Chen Zhongjin Cc: "Naveen N . Rao" , Anil S Keshavamurthy , "David S . Miller" , Arnd Bergmann , Nathan Chancellor , Tom Rix , sparkhuang , Ard Biesheuvel , Steven Rostedt , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, llvm@lists.linux.dev, Naresh Kamboju , regressions@lists.linux.dev, lkft-triage@lists.linaro.org, Linux Kernel Functional Testing , Logan Chien , Masami Hiramatsu , Russell King X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221006_133519_380086_07F03582 X-CRM114-Status: GOOD ( 13.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 30, 2022 at 2:15 PM Nick Desaulniers wrote: > > commit 1069c1dd20a3 ("ARM: 9231/1: Recover kretprobes return address for > EABI stack unwinder") > tickled a bug in clang's integrated assembler where the .save and .pad > directives must have corresponding .fnstart directives. The integrated > assembler is unaware that the compiler will be generating the .fnstart > directive. > > arch/arm/probes/kprobes/core.c:409:30: error: .fnstart must precede > .save or .vsave directives > :3:2: note: instantiated into assembly here > .save {sp, lr, pc} > ^ > arch/arm/probes/kprobes/core.c:412:29: error: .fnstart must precede > .pad directive > :6:2: note: instantiated into assembly here > .pad #52 > ^ > Chen, I noticed that your patch was discarded; it's not in linux-next today. https://lore.kernel.org/linux-arm-kernel/YzHPGvhLkdQcDYzx@shell.armlinux.org.uk/ https://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=9231/1 How would you like to proceed here? I think moving this out of line, incorporating Ard's feedback, then putting the UNWIND directives on top might be the way to go. What do you think? -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel