From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B2EC433DB for ; Wed, 20 Jan 2021 18:29:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE88923442 for ; Wed, 20 Jan 2021 18:29:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE88923442 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Dsu2+fuJ1DxWJyhUDmS2tapHRz0BxJ3WunCwq9zdAFA=; b=0Jcufi0wL5sutmK5oYNujIan8 sp8pBXpaBlvl9YDgf6NiufBBtnDDwWJj0DEnOLDGLcJ60j8Oab+vJ6VUp7Af1WhbXyStgEFTyChQN +N1pfRPlahgnJmuHxCFroZ8JNPys1qs65Mu1u8pLBHEOcpM7cUaIUQi9v49exHjLpI8OeoiXcnvE6 w6ZoJQYsh2oI9bOEPCbNJK8m0ZrlVexVnGHKfCay76uZl4igifXcjkZPMISiE8oMH8P+CYOxRFkCo /eBwOJzVJGC8+d4LmeMknh6C18RbycR0v0xV0km1rsRq/CRKB5HViOBC2lA+1cefArmxdbAt0VPty EnEIf04sQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2ICN-0001Rj-99; Wed, 20 Jan 2021 18:27:19 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2ICK-0001RP-W6 for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 18:27:17 +0000 Received: by mail-pj1-x102c.google.com with SMTP id p15so2685239pjv.3 for ; Wed, 20 Jan 2021 10:27:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uiW6R+4OroO7DV/CnGwFhudMKTgvqDzlldk0/NCSxIM=; b=quWaPHodtXoBEM4er9UrGLPUP4C6pIAo1GfMKNEJNcdOz4TFWyZR+oBy9LoOaUlFpl 8zpzY1PKROmbQwEOb7yvm8ggsN9fh0D1uwXu6rYsXh2rrh8Ae7WULfiPMhN/wy/nSRCI bC5+7Z4yH/Gwiini9VCTaujDniBcpQbsPaB6W5srOSFSJAZJq4HUPc9GyKumH2lLxyr3 20iZoVwN++wb61UullUjVK81Uk1yMkOgyxRPZrMBoFPKC/Pif8PM0GebcQCf9fh+YXJ0 VbKja2a8YxlBdC9zs8HV9JhEIVyR7e35k1j86OtY9JFvpJyNFWIHgdArmjw1XwzIwuJ9 x9Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uiW6R+4OroO7DV/CnGwFhudMKTgvqDzlldk0/NCSxIM=; b=XM4w30vhl423S6HQkpmT66tZKMA+xEzylB440Oct/Jq/Wvzxysjg1He1VfKgPwCTBO hiDqk23BdGUQOctGPcuOezRg3ZrROTrRhE2/Cb06JJd6v+XVEPaMyPL4jhHfn69QCZqx BBPxZL4X3jgk38Sw2WHCSxW7ZLG+9okzh2jn8RK/PqBGOdpqeA6TK21K2w3Lxt+gZ2Sb rCdbXDg6F/W8wwu0hhPZBIoPrVVLzzM/IQseiinhQPVm6/ABeNU4p7LB2u4cFNFCkKXa J4zYBDcKxMzyOL09kNsE/SMQGNgMivnCSPkorrvfO4569quMzHTD/G2QybbPLMIrx1yF Mr/g== X-Gm-Message-State: AOAM531a4BjcizSvsiT6L8U90tj8drhb2/hO2Mvt/n0339Wtij/RWBOO Xy8fuKT9uE7gadOCn20yKQR2eexzViguVVaf7882Eg== X-Google-Smtp-Source: ABdhPJztSwBi+iAIwUggUK6+sTeRb+j0bW0Cdtft+/KRMsHKFTPOr75taMb9vlVZxWG24rYXR0mZQzqMPzxZOXgDSK4= X-Received: by 2002:a17:902:26a:b029:da:af47:77c7 with SMTP id 97-20020a170902026ab02900daaf4777c7mr11275754plc.10.1611167234448; Wed, 20 Jan 2021 10:27:14 -0800 (PST) MIME-Version: 1.0 References: <20210120173612.20913-1-will@kernel.org> <20210120173612.20913-9-will@kernel.org> In-Reply-To: <20210120173612.20913-9-will@kernel.org> From: Nick Desaulniers Date: Wed, 20 Jan 2021 10:27:04 -0800 Message-ID: Subject: Re: [PATCH v4 8/8] mm: Mark anonymous struct field of 'struct vm_fault' as 'const' To: Will Deacon X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_132717_075037_C477F717 X-CRM114-Status: GOOD ( 21.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team , Jan Kara , Minchan Kim , Catalin Marinas , Hugh Dickins , LKML , Linux Memory Management List , Vinayak Menon , "Kirill A . Shutemov" , Andrew Morton , Linus Torvalds , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 20, 2021 at 9:36 AM Will Deacon wrote: > > The fields of this struct are only ever read after being initialised, so > mark it 'const' before somebody tries to modify it again. > > Cc: Kirill A. Shutemov > Cc: Linus Torvalds > Signed-off-by: Will Deacon > --- > include/linux/mm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index e0f056753bef..7ff3d9817d38 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -514,7 +514,7 @@ static inline bool fault_flag_allow_retry_first(unsigned int flags) > * pgoff should be used in favour of virtual_address, if possible. > */ > struct vm_fault { > - struct { > + const struct { > struct vm_area_struct *vma; /* Target VMA */ > gfp_t gfp_mask; /* gfp mask to be used for allocations */ > pgoff_t pgoff; /* Logical page offset based on vma */ Is there a difference between: + const struct { + struct vm_area_struct *vma; /* Target VMA */ + gfp_t gfp_mask; /* gfp mask to be used for allocations */ + pgoff_t pgoff; /* Logical page offset based on vma */ + unsigned long address; /* Faulting virtual address */ + }; vs + struct { + struct vm_area_struct * const vma; /* Target VMA */ + const gfp_t gfp_mask; /* gfp mask to be used for allocations */ + const pgoff_t pgoff; /* Logical page offset based on vma */ + const unsigned long address; /* Faulting virtual address */ + }; ie. marking the members const vs the anonymous struct? Does anything need to change in the use of these structures? > -- > 2.30.0.284.gd98b1dd5eaa7-goog > -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel