From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8794FC433DF for ; Mon, 29 Jun 2020 19:55:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 502CE20674 for ; Mon, 29 Jun 2020 19:55:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a2p5ie3+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="bRgfBWJh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 502CE20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PnSZlVcwvcq8LguxssuqsscipS7gGfKf2HO2H/r1VBM=; b=a2p5ie3+ydhVCcBB9JdEChmkB UIibZTDwoSKzNA3kqZwaCNpkvfb/wdQR8ViPWkW6+Vkr8ONDMZaDJm0mErMmZeqrqw1zVG4LHkdze mm9C14LM1qhlDScCeM1qTvW5CV2pIqBGMVu22OygaAoHykx3DNMt3Em6QubAJNMLyedmS/rNDqr1x hVdtxKWVQ8RY7ptCqxqM/u6/v/7uNM2oevuq36b3AtIxmkYtwVHyCsVA/6HlWVXdjTRJt4rbyEU+m 2aVVf9a2hR16lToEZ7aMrDcmlCL/1lARLuhclOhiurYZskTaZ6qAUOKCg6hgEEtFHxr2sZADDUsBa al8k7AGRA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpzqt-0000Fd-Hq; Mon, 29 Jun 2020 19:54:03 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpzqq-0000Eu-PM for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 19:54:01 +0000 Received: by mail-pf1-x442.google.com with SMTP id a127so8324830pfa.12 for ; Mon, 29 Jun 2020 12:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zKRhn9sIaFaGEW3xbHkfNQIj02f8YddLObFXUqnNhu8=; b=bRgfBWJhw3k6vEkg+gGrA7QdNS4rt+ffVIqjxb8+xRH5Hf8e5n3ITha/4r/HQQjG1F Mnp916bSSyiyNJ3mB4Pp24pG+NomV7NtlGrDIbs1/VO6qz2zh+2u4MyKygTW4DWOdEAW h0hJeQ7dnSzCQo+TA8azgjmFV+w1Q1r8AkAQ6kyp/vQDX2e8LTYa1tMbaefxqY2R+gNz opFp+Zy1OQeuKe8JMokYShmECU6iURq7DyQW5616Pz5i3j+aOZhMSWUTT6+QxBbnEYnE 2WnYAveyeIeVpJcFa2nui3COjVCHDpZHxL9us5S2uMZdxLknVjYHLMAByD7JWc3QqKQU /rhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zKRhn9sIaFaGEW3xbHkfNQIj02f8YddLObFXUqnNhu8=; b=NV5/XsqL9M3w3q2iw52y/P24/EOMOaFun0H+z5L1dLqJDnoanm8v+bc7Qo/J4yzjAW iZbtH5Hw/GL6U9DS4X7sgD0wixk0rWqE4dTxJDSvlTQenBA1p9va4mmGqJWMCmvbQ1ry OTC5a0ERvz20DC1VRieKt84sAPFM4Smc4vmbccvHUBKA/bvbfWvGTWkgicC9qCZMHc4q yfrMLLW24i++h/sJg8TugPoCsg/eLSoFQhMqs8kSRtGxxnznEFs8mXQEBsVDW8hSllB3 LKXuxDzfFXGBZvSa5EzcBmwspEYm/6xXPvuYbd2X2z6EdEpoqsnZcefdsEOkXcMnfve9 usuA== X-Gm-Message-State: AOAM530pjcuLqZzmctpQ/gsdZzLE2Pwb5GzGZh0u3MG2d+EN8TJ5yAs5 aHKEuac1NMrSfBR46buWN1VdVEkOOU6FXbdv5TjawA== X-Google-Smtp-Source: ABdhPJx1ZltZC8TxdLF0qs/W70OrjV+LgOyxShhZsT9U/M+Islb1fHf4YkGIw2+d4lhznk2dOuqEiVum9V3YVQvnVAQ= X-Received: by 2002:a63:7e55:: with SMTP id o21mr11995677pgn.263.1593460438609; Mon, 29 Jun 2020 12:53:58 -0700 (PDT) MIME-Version: 1.0 References: <20200629061840.4065483-1-keescook@chromium.org> <20200629061840.4065483-9-keescook@chromium.org> In-Reply-To: <20200629061840.4065483-9-keescook@chromium.org> From: Nick Desaulniers Date: Mon, 29 Jun 2020 12:53:47 -0700 Message-ID: Subject: Re: [PATCH v4 08/17] arm64/mm: Remove needless section quotes To: Kees Cook X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch , linux-efi , Arnd Bergmann , Peter Collingbourne , Catalin Marinas , Masahiro Yamada , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Russell King , LKML , Nathan Chancellor , clang-built-linux , Arvind Sankar , Ingo Molnar , James Morse , Joe Perches , Thomas Gleixner , Borislav Petkov , Will Deacon , Ard Biesheuvel , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jun 28, 2020 at 11:18 PM Kees Cook wrote: > > Fix a case of needless quotes in __section(), which Clang doesn't like. > > Acked-by: Will Deacon > Signed-off-by: Kees Cook Yep, I remember bugs from this. Probably should scan the kernel for other instances of this. +Joe for checkpatch.pl validation. Reviewed-by: Nick Desaulniers > --- > arch/arm64/mm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 1df25f26571d..dce024ea6084 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -42,7 +42,7 @@ > u64 idmap_t0sz = TCR_T0SZ(VA_BITS); > u64 idmap_ptrs_per_pgd = PTRS_PER_PGD; > > -u64 __section(".mmuoff.data.write") vabits_actual; > +u64 __section(.mmuoff.data.write) vabits_actual; > EXPORT_SYMBOL(vabits_actual); > > u64 kimage_voffset __ro_after_init; > -- > 2.25.1 > -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel