From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15742C32753 for ; Wed, 14 Aug 2019 22:20:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D811B2067D for ; Wed, 14 Aug 2019 22:20:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rjtPPGoQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="bIzCRgoq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D811B2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1k+2jGjgSPjx2AiIn6mJicbMb94FBiABZeDa/EDOF2Y=; b=rjtPPGoQqAPUmj p23lKe5VBajVsxU85vaAKmOt5w+P/nB1si9yFPrsVdaQi2uDv4k35CK7NOV6rPqvKAx8W/C/d5nCl io5rGrbokKF3guiheQBWqV4aSDDhwamJxvkvie2Tz3Ron+G3GT4+a4cXYPIK//vKDRXj7BYDd14jH mKmrOPTwYTr1eeJjYlGpLyM1rr5XhxaWT2KRwQQCpRCyBJbGNvoe3LKUZlSLsiz7z0TrTENp1BKTT S1YAAoaHwEB4vcIx5RodWlrrQMlXZWDYlANi3VxNp2U8OiibPGKL5EqGrae25QJqdC1tBQmmQ+5xb yD3stKToV/MERvAXO0nA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hy1dU-0001dA-7V; Wed, 14 Aug 2019 22:20:52 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hy1dR-0001bz-7V for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2019 22:20:50 +0000 Received: by mail-pl1-x644.google.com with SMTP id bj8so238660plb.4 for ; Wed, 14 Aug 2019 15:20:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3k2w+T8PpskZpxccjtIiizfMIZhjmdjjp0d3COyTRJs=; b=bIzCRgoqfzNuUan1EfvB7NRSozZHajM22ukZLoilzYM9sYiJ7YkDvmA7Uj+9V3whQX tVwoUOufC9BTkAMrQC/rHvkb/exsHErFgJVr/8W7KT829V0wEHH9QAxZdmZ/ErITekS6 xrKE/Bq6vysHbTrERMP3oECXC0pPuqF/A4lnVBELZNj6IgYErrd6+O2HP/vitjEgPg/G Vo3XjVH1cvHMNyp/jwUDdyb50ZiaJxDo6aTcH/2RYATRNkXzQBQZglJb7q5MJyn2amFZ e2uUqZNKxy7OtuBUudolHQGGHryuTumSWmufu1hM+Awk5W4Y9ddcKD4aXMaQEHtNXxkv B8Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3k2w+T8PpskZpxccjtIiizfMIZhjmdjjp0d3COyTRJs=; b=Hsp5ULrhIGF9jbgjEXBYatNHwD049Y8hgE11Xf0e32DUUlKXuIEBekkw3Dtl0p4xe3 NtgwbAlQ3bE7+/8Q0jfyEmXUIxJB+hKDa3cRCj4LvQIMJMb/NHP4Ord7eHsvh0R28+6w Hv13scTcvqdaLD/FBGEuko6XeyU8+tTJ1tRXpApW4TZuLT7yOlCm+ZTB2jHYDb25oH80 XAWm0bqGhypBMj0KgomPm1jaUqvsAeiT1gF0fqh/07BrozG03aei/oQ4sqmcsJJ51RjL ZNPELwZMV2/dxNN7GvsVkPS55zZu8l8N/8DTDe3ucO6WAK8WWQA9Dnuvf6wdJdkWTvK9 QauQ== X-Gm-Message-State: APjAAAW8aqKoeKgtSNj0l3B0SJ6LlAv7fpKZ98aPjITSlUiWAnmqmIvw XvSPRyj9m7j1JgsjjbrS6Uao+if8N9pb34sy/Ck16w== X-Google-Smtp-Source: APXvYqxHrSJ2tRfUqC4Ul74AEgggKrkSwf6kd2vyhl5jNkzvxCgzLD0h2XP16ofmSNmQ6rstXRsNaFKQHmMH2KlVrOE= X-Received: by 2002:a17:902:a9c3:: with SMTP id b3mr1454831plr.179.1565821244245; Wed, 14 Aug 2019 15:20:44 -0700 (PDT) MIME-Version: 1.0 References: <20190812215052.71840-1-ndesaulniers@google.com> <20190812215052.71840-12-ndesaulniers@google.com> <20190813082744.xmzmm4j675rqiz47@willie-the-truck> <20190813170829.c3lryb6va3eopxd7@willie-the-truck> In-Reply-To: <20190813170829.c3lryb6va3eopxd7@willie-the-truck> From: Nick Desaulniers Date: Wed, 14 Aug 2019 15:20:33 -0700 Message-ID: Subject: Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h To: Will Deacon , Miguel Ojeda X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190814_152049_300446_C0671899 X-CRM114-Status: GOOD ( 23.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Catalin Marinas , Alexei Starovoitov , Daniel Borkmann , clang-built-linux , Allison Randal , Yonghong Song , Masayoshi Mizuma , Suzuki K Poulose , Andrey Konovalov , Shaokun Zhang , Alexios Zavras , Josh Poimboeuf , Sedat Dilek , Thomas Gleixner , bpf@vger.kernel.org, Linux ARM , Greg Kroah-Hartman , linux-kernel , Network Development , Andrew Morton , Enrico Weigelt , Martin KaFai Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 13, 2019 at 10:08 AM Will Deacon wrote: > > On Tue, Aug 13, 2019 at 02:36:06PM +0200, Miguel Ojeda wrote: > > On Tue, Aug 13, 2019 at 10:27 AM Will Deacon wrote: > > > On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote: > > > > GCC unescapes escaped string section names while Clang does not. Because > > > > __section uses the `#` stringification operator for the section name, it > > > > doesn't need to be escaped. > > > > > > > > This antipattern was found with: > > > > $ grep -e __section\(\" -e __section__\(\" -r > > > > > > > > Reported-by: Sedat Dilek > > > > Suggested-by: Josh Poimboeuf > > > > Signed-off-by: Nick Desaulniers > > > > --- > > > > arch/arm64/include/asm/cache.h | 2 +- > > > > arch/arm64/kernel/smp_spin_table.c | 2 +- > > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > Does this fix a build issue, or is it just cosmetic or do we end up with > > > duplicate sections or something else? > > > > This should be cosmetic -- basically we are trying to move all users > > of current available __attribute__s in compiler_attributes.h to the > > __attr forms. I am also adding (slowly) new attributes that are > > already used but we don't have them yet in __attr form. This lone patch of the series is just cosmetic, but patch 14/16 fixes a real boot issue: https://github.com/ClangBuiltLinux/linux/issues/619 Miguel, I'd like to get that one landed ASAP; the rest are just for consistency. > > > > > Happy to route it via arm64, just having trouble working out whether it's > > > 5.3 material! Thanks! https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?h=for-next/core&id=80d838122643a09a9f99824adea4b4261e4451e6 > > > > As you prefer! Those that are not taken by a maintainer I will pick up > > and send via compiler-attributes. Miguel, how do you want to take the rest of these patches? Will picked up the arm64 one, I think the SuperH one got picked up. There was feedback to add more info to individual commits' commit messages. I kept these tree wide changes separate to improve the likelihood that they'd backport to stable cleanly, but could always squash if you'd prefer to have 1 patch instead of a series. Just let me know. -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel