From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B79A5C49EA5 for ; Thu, 24 Jun 2021 19:38:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 876616120D for ; Thu, 24 Jun 2021 19:38:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 876616120D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NBvscNCvJ3UN3FkRDeES8DLb/v00wQwGRBmvcPs+6GI=; b=paTqwnh4mwXBm8 rzR2oMWmydnDBb65chmvgXeH6eGbLxzs2aQwUdf7F/na3/gg5G7wbxouQUjIGgu1Dsc8BxRSANzUv WIepHvkDidP+nUEkL2dmCQHmH7UqBzgYBHRNH2cClDPd0zWHYpFGqeJ92hKASxvMNlRBMk0hzbqlw n+EcBbhJSgVbuloPEQceq+0VOY3vMlYmg+5Yz9KKCddVr6I6Fegflwa4itx0XLUFLX4puS8+suAk0 i/jzbw9W6sVLVo2Dxquzsc2kAnD578jbNEX1y/WFq8PEnSELVoSRRxAAyGwWj/Ic9Pw+20qnoFPN2 Yrrdc78+cq5nEDHf99tQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwV9P-00G4BX-Iw; Thu, 24 Jun 2021 19:36:35 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwV9L-00G4AY-Ah for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 19:36:32 +0000 Received: by mail-lj1-x236.google.com with SMTP id c11so9255176ljd.6 for ; Thu, 24 Jun 2021 12:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DBxJ+5KzUAKH3jFhz3Iwj54r7FIMmamDMI5BPojMuJc=; b=dYwgZ9h27ndDmBg/0m6WgW1LArwbOWa26M1LqVXc1zXOs48DVQSrbhzbUHQNug9tkZ q3D/blHDOzdEPPo3bUbcejYyoWtIr90hLC1edUbfhTBynk7E/lW8P7SUK5oshAMiOmFX FeRaN/eolsikGjmZPU9y6AUewwJAliXCcfTymEfHi6vZeTmBr6Za33JjUQEKoIma9MIH 60/9CviuXnS+3c4YVp9qGGcMQhNtn2lmtSgyFcUHq31vytlepnUZklgtNq/7dhZtrUUg hpgep8ai+pEDiiw3BFbc+F7+MngfSWxqoXsDHvEwoPx91W+DP0I0ZSb+JRDZjl/qFqfB BW4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DBxJ+5KzUAKH3jFhz3Iwj54r7FIMmamDMI5BPojMuJc=; b=qeIQ9j3pi7mQNwrsCp1kzJKWhWYMiE720cqJHEh/7vCdSI8boH2rBpmva6PksqSbRV xDQ1yw3fKrpOl335o/G9yBDtt5Vd9MbS7ix1tbvpinyhv83yro6vFxM2k73Rp9xulp4w JlyPJ85BoUlBRNYxO75NmIWa4fw5rLXa5t2YoRASf/U62TmuRbSCMbbEYrezTQhrFAhx z/3249b7e8wCvAN+C0rScHCsnGXXWQbYnk10P6OPsfYqjhB1F78b+kDU70HKldibyZkr quta5cmOBD94JROYCR+cwk7skOI6z5SWOEt2VhRgRmK5KCqhDTU0HKVMt8F88IUgOI6E Lw9g== X-Gm-Message-State: AOAM532/cyy0d3lGSKtJ+4GXq3jfCQWnwNja9KjSJkgVuqgTGT0HVLET 7dU9RwEQv/ga9+vdoMRqLWKkOhat6rfA0F9fJrZIcw== X-Google-Smtp-Source: ABdhPJzoUDYNMlMYAnSTK9W/UbT/cdGV/rjMVbZjtFi2SSd63uN2ZxNPWm3CGKEFKMm5AO4RdSLIU6HwJ2an34Rr8QQ= X-Received: by 2002:a2e:92cc:: with SMTP id k12mr5168790ljh.116.1624563389245; Thu, 24 Jun 2021 12:36:29 -0700 (PDT) MIME-Version: 1.0 References: <20210621231822.2848305-1-ndesaulniers@google.com> <162442894704.2888450.8087873021886781652.b4-ty@chromium.org> In-Reply-To: <162442894704.2888450.8087873021886781652.b4-ty@chromium.org> From: Nick Desaulniers Date: Thu, 24 Jun 2021 12:36:18 -0700 Message-ID: Subject: Re: [PATCH v2 0/3] no_profile fn attr and Kconfig for GCOV+PGO To: Kees Cook Cc: Catalin Marinas , Vasily Gorbik , Ard Biesheuvel , Rasmus Villemoes , linux-arm-kernel@lists.infradead.org, Nathan Chancellor , Fangrui Song , linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Peter Oberparleiter , Borislav Petkov , Luc Van Oostenryck , Marco Elver , Christian Borntraeger , Masahiro Yamada , Peter Zijlstra , Heiko Carstens , Andrew Morton , Miguel Ojeda , Dmitry Vyukov , Bill Wendling , Arnd Bergmann , johannes.berg@intel.com, clang-built-linux@googlegroups.com, Jonathan Corbet , Martin Liska , linux-toolchains@vger.kernel.org, x86@kernel.org, Sami Tolvanen , Will Deacon X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_123631_429350_A5EC62FD X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 22, 2021 at 11:17 PM Kees Cook wrote: > > On Mon, 21 Jun 2021 16:18:19 -0700, Nick Desaulniers wrote: > > The kernel has been using noinstr for correctness to politely request > > that the compiler avoid adding various forms of instrumentation to > > certain functions. > > > > GCOV and PGO can both instrument functions, yet the function attribute > > to disable such instrumentation (no_profile_instrument_function) was not > > being used to suppress such implementation. Also, clang only just > > recently gained support for no_profile_instrument_function. GCC has > > supported that since 7.1+. > > > > [...] > > Applied to for-next/clang/features, thanks! > > [1/3] compiler_attributes.h: define __no_profile, add to noinstr > https://git.kernel.org/kees/c/380d53c45ff2 > [2/3] compiler_attributes.h: cleanups for GCC 4.9+ > https://git.kernel.org/kees/c/ae4d682dfd33 > [3/3] Kconfig: add ARCH_WANTS_NO_INSTR+CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO > https://git.kernel.org/kees/c/51c2ee6d121c > > Note that I've tweaked the series slightly to move the PGO Kconfig change into > the PGO patch. Ok, LGTM. -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel