From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB28C433DF for ; Wed, 24 Jun 2020 21:15:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C2AE20768 for ; Wed, 24 Jun 2020 21:15:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="prd04rHT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="ogyMpgi9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C2AE20768 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uCZhot0W9YdUm/zIj5mUQzGTgNjt0kZzod76Y7n3S10=; b=prd04rHTlYmoAKCVya5TCLMfz t7AiunRLf07Ld9OHkw10qfRUoEnSO7L/SosDa7eP0+XhAUq72hlvhkQhPc5NkUofNUHAfW8JvBkUg syn0CxInFHTiI+flZdX4YmaevS2Fao0xXrn5ygO7OnH+gON+CfTp4Fu5mBbsHM3t2FGSONvRcP9rt V4LyNmgGpRreVjZZ0PE9j5+/0+/xjTXlWK9ULM8XZC2E0ZwdUBZPA83mNRvgZ1CZWf5pqArHmbZxx s8+WTLbA3Sqc8rMJy7VBPaMKO4yKZhY9bp8COWlE4Dx+WguT/IF9SFNL0kNBxx4MEOW/frYYGTJWJ Bp7fbEobg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joCia-0001x2-4F; Wed, 24 Jun 2020 21:14:04 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joCiW-0001vO-PS for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 21:14:01 +0000 Received: by mail-pl1-x642.google.com with SMTP id f2so1633021plr.8 for ; Wed, 24 Jun 2020 14:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=omCkUcZNHVXP0sWRywzjOwxTXZ4YyisMAxm749WU5GU=; b=ogyMpgi9tPFXqD3+b4TskFtzlAE3qRSfSFlhxLkMzfZQl068z8vqJlL5I/k1hQA4j2 8+KaTuQNKpStTyBjn2ssQsUKa/GWq7f607kaEaeXU2o8/Ft2sUgUsqmcJHltC+KgIKVl o3jZ4P3X6AywcFpecW/k8P5ZOrqPI9Z99iVivwkxvFoyUq4G2KcudRcYQ4mOacJiN+sQ WfzuwRbr7it+GIQZRqsNndeZ4kbhXyBxzlSPEB5SEo0dkcZcdM6751ifbYi1L0YxNGzl zLZYU7QD65uDvjwEcqlKMDaY6jKyUjhUxCFnXE3C+lzv6bRpSkWGLHXOkAgDh/7Se2CC j7Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=omCkUcZNHVXP0sWRywzjOwxTXZ4YyisMAxm749WU5GU=; b=Y9q7DPnmyd/M+iKrrdHojnX4AVXnWfdRHntD2mgRFd3i2Zt8E9eU4KHRQZowaUj12u 2lRg1GoQbKQEzHx3UkPifN+OH8pYrGbtjkYDFIPjlkTc0SJOFDl6IJ3gVXxxaUjj5uFj C96iQsXb/KE06jt37f78ongtp2ywkiZlDnHtiGbM8bhKW4XRzIC9QfraUEZq74IhpHUR o+nShxuFMtAYpLDd1SpIX73MyZux8MNU1aqdrGfw9AQ+HMNqN+rEv4uSrfCosBAg1QfA 6b64VZKEYIq464s+x5cWR47xerqASBLOVGKrNJIwO5ICjm3Xvvd7ItvqleX/prq+ebjG Mg4A== X-Gm-Message-State: AOAM533FswDLFs4EQqA+tCIGqhUPPLYSF6PB2m9PEZ//KjVC+WxG/WcR p7+IYK6j+0f8pcRikeC8iiStOxS5txWYSidcd5OQ+g== X-Google-Smtp-Source: ABdhPJyvmG5uGb8Lyk5i53Q9bt53kqBtuDjO8DoRXX4pnhndW+Y4vnp4+GK0S4oFxok0KRSkaflUBQ+yOxnxS3G2Ct0= X-Received: by 2002:a17:902:b698:: with SMTP id c24mr29536869pls.223.1593033238474; Wed, 24 Jun 2020 14:13:58 -0700 (PDT) MIME-Version: 1.0 References: <20200624203200.78870-1-samitolvanen@google.com> <20200624203200.78870-9-samitolvanen@google.com> In-Reply-To: <20200624203200.78870-9-samitolvanen@google.com> From: Nick Desaulniers Date: Wed, 24 Jun 2020 14:13:46 -0700 Message-ID: Subject: Re: [PATCH 08/22] kbuild: lto: remove duplicate dependencies from .mod files To: Sami Tolvanen X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Kees Cook , "Paul E. McKenney" , Kernel Hardening , Greg Kroah-Hartman , Masahiro Yamada , Linux Kbuild mailing list , LKML , clang-built-linux , linux-pci@vger.kernel.org, Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2020 at 1:33 PM Sami Tolvanen wrote: > > With LTO, llvm-nm prints out symbols for each archive member > separately, which results in a lot of duplicate dependencies in the > .mod file when CONFIG_TRIM_UNUSED_SYMS is enabled. When a module > consists of several compilation units, the output can exceed the > default xargs command size limit and split the dependency list to > multiple lines, which results in used symbols getting trimmed. > > This change removes duplicate dependencies, which will reduce the > probability of this happening and makes .mod files smaller and > easier to read. > > Signed-off-by: Sami Tolvanen Reviewed-by: Nick Desaulniers > --- > scripts/Makefile.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index 82977350f5a6..82b465ce3ca0 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -291,7 +291,7 @@ endef > > # List module undefined symbols (or empty line if not enabled) > ifdef CONFIG_TRIM_UNUSED_KSYMS > -cmd_undef_syms = $(NM) $< | sed -n 's/^ *U //p' | xargs echo > +cmd_undef_syms = $(NM) $< | sed -n 's/^ *U //p' | sort -u | xargs echo > else > cmd_undef_syms = echo > endif > -- > 2.27.0.212.ge8ba1cc988-goog > -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel