From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86305C433DF for ; Wed, 24 Jun 2020 21:02:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55C82207FC for ; Wed, 24 Jun 2020 21:02:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kP9pap/P"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="pd1+e0uX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55C82207FC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k0Tz8f3CG63k4ghnZyCbUr42SRuAa/umUP5dQ9Z/70U=; b=kP9pap/PavSoPJthgXaTbSunv YOKD5FdmU3BVr7RCbCoutcrXVvorpzfVSjWO4ZwSDRznZzvFUuvn4cNv+wqSEU8JMpv8wRJN9H/V2 dyG2OnaW+hZvU1W9Cs6D4XZVwOAafDCTlhoEfncqRsS4fljWIVWXum4iRbFtoQDRF8E+vahS5yIga bHzj+w9w4TWMDGgJYy2c9Zkmj2EB5jQvwAE6pUCMFMx44Mnz5JLaboGCMfabaJtoY/0g6VQBuV3Lb 2afrKYgKR8Z0sLBL/qiErjMBU+x6fsyMNIJnT+L1UIX36Q569Jdt6e6lM/6t5Fr7P8xUYiCFxZXX5 5eRiJxgdA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joCVA-00034u-1R; Wed, 24 Jun 2020 21:00:12 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joCUC-0002Tf-Cv for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 20:59:13 +0000 Received: by mail-pl1-x644.google.com with SMTP id s14so1612139plq.6 for ; Wed, 24 Jun 2020 13:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zWM/30Wl1IsQgoPaDiN0rPEEBtrHBKt/BJnnp0eLWds=; b=pd1+e0uXRIvGNNQgZ7G0+2YkwsDFhSclmocO1GbaT5UM3c6xBTX7UYJjCsai0aiyT7 fIoijSJoU+eUl8voyiO0IOyBsavQt6eREqkk3whDlDlHejxDQRKECAFiVGUe/CKDHaTc EpZ2md8ULTkAVVBJ6O72PRwIcg/GiVClV1rha8JNSiYzT4/v2ecYsi++FLxwW19Hw/Gd Fr/Z+ikfp69sRAivcJnbajJT1/5/Qn2W6vWHskjofe5p2ZJr6Cthm+UKTVG2rZslsDkG xO7mHbrOSScz4BsI8HgHuMYhqH42CQPx5Ip80xrwiQdph3TwAg+m578XBSL3rfWRIGQZ ATEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zWM/30Wl1IsQgoPaDiN0rPEEBtrHBKt/BJnnp0eLWds=; b=cNzgGx1+05Rgn+Z+C77sSNe7HUTYoBQ5ENKrRBTiw3aYKoCdTpKZGjV+lrY4FV8Rpr RVU7CsZSB6kesCyuGke49VkPbDYwEqQyyZNdVrP/vWvqD6jMGSznT9ouAaY4NP7YUHAH RGNb3Hk5RSfO0Ht6Y5axvVWZ9qrvL4xbURwC4oKJ46Y74TOwmQXyy0d3l+ah/wB1Aqpl T0rFO1PSs6N/hMhVxzgoTw2gZVf/tVvCbQlzHHPzmsj4jgPGhlDRylPEXRu60WU+0lsE XqAFqJr2lOhf19UdQpiDTC8TritO81hXHS0bTmPZ1bWF9ziE9Vj0/FLMjgNOUvfWwWaz wJMA== X-Gm-Message-State: AOAM5327cKLHqJEizD2GEoEHrhCskqg57qvSBzPM/2TjfIlD6RlPvImm HNT4fGHXCqCeRnf+8iefxUnvO0/gC5z2E+5P9WJoeA== X-Google-Smtp-Source: ABdhPJxCHHL5VXpLPing5E72KwPslmx5t7evOEk09T9ji09mKT6bSRCDPTi/AxhdrzEhszh9gGm6vbYGZSEoMtti7/U= X-Received: by 2002:a17:90a:21ef:: with SMTP id q102mr5252324pjc.101.1593032350091; Wed, 24 Jun 2020 13:59:10 -0700 (PDT) MIME-Version: 1.0 References: <20200624203200.78870-1-samitolvanen@google.com> <20200624203200.78870-18-samitolvanen@google.com> In-Reply-To: <20200624203200.78870-18-samitolvanen@google.com> From: Nick Desaulniers Date: Wed, 24 Jun 2020 13:58:57 -0700 Message-ID: Subject: Re: [PATCH 17/22] arm64: vdso: disable LTO To: Sami Tolvanen X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Kees Cook , "Paul E. McKenney" , Kernel Hardening , Greg Kroah-Hartman , Masahiro Yamada , Linux Kbuild mailing list , LKML , clang-built-linux , linux-pci@vger.kernel.org, Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2020 at 1:33 PM Sami Tolvanen wrote: > > Filter out CC_FLAGS_LTO for the vDSO. Just curious about this patch (and the following one for x86's vdso), do you happen to recall specifically what the issues with the vdso's are? > > Signed-off-by: Sami Tolvanen > --- > arch/arm64/kernel/vdso/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile > index 556d424c6f52..cfad4c296ca1 100644 > --- a/arch/arm64/kernel/vdso/Makefile > +++ b/arch/arm64/kernel/vdso/Makefile > @@ -29,8 +29,8 @@ ldflags-y := -shared -nostdlib -soname=linux-vdso.so.1 --hash-style=sysv \ > ccflags-y := -fno-common -fno-builtin -fno-stack-protector -ffixed-x18 > ccflags-y += -DDISABLE_BRANCH_PROFILING > > -CFLAGS_REMOVE_vgettimeofday.o = $(CC_FLAGS_FTRACE) -Os $(CC_FLAGS_SCS) > -KBUILD_CFLAGS += $(DISABLE_LTO) > +CFLAGS_REMOVE_vgettimeofday.o = $(CC_FLAGS_FTRACE) -Os $(CC_FLAGS_SCS) \ > + $(CC_FLAGS_LTO) > KASAN_SANITIZE := n > UBSAN_SANITIZE := n > OBJECT_FILES_NON_STANDARD := y > -- > 2.27.0.212.ge8ba1cc988-goog > -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel