From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC171C4360C for ; Fri, 27 Sep 2019 21:12:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BACAF205F4 for ; Fri, 27 Sep 2019 21:12:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ApMKaIrC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="HWrjXwmy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BACAF205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YOyBXaFXNviqJQdrfpJisCzifHj4Caozn4zrILlh9lg=; b=ApMKaIrC1ZILMN w77mk1RHqjar6SUMYzKMP3qrDl7LuiB7eO28xzpRoIvh3YQHsiIFdXfGI2v816utQZe4Q6dhKYPVb mp+lkvE7wSEjM5JjMO6WWV0kDS0Smfeum4qsxb1ZQ5Y6CRdAIZXMlZIr3XhXEZ2os3fX58lYT35az DvbKuVJgJLXU+L0pBPJ4/jWWyyB4E0FQYv0Gh0C80TEsKZUGO5mfPRfFoLwsBEgRAuKBaE8n2enIz ZVB3ZjDcRWEhfux+/rY0jwy8Dm157VmajGCLGQnJHFhkPsfIXYkTiidFG1Mj3W87wDowQf+TJPJE5 frcq1QWjWuZAMPUwJ27g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDxXd-0000iu-J3; Fri, 27 Sep 2019 21:12:41 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iDxXa-0000i4-E9 for linux-arm-kernel@lists.infradead.org; Fri, 27 Sep 2019 21:12:39 +0000 Received: by mail-pg1-x543.google.com with SMTP id a3so4074290pgm.13 for ; Fri, 27 Sep 2019 14:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MT3rEIfaJgpzvHmFM2pWeqN2XOEfjsN3Ht7YF+hthq8=; b=HWrjXwmyGQrWIktNn2lCfS/WWNp3jM0GJkqLaICHIq/FPWxfdSodtSpyQmZZZSqYKl gLWJ5uiWHrbfp7XRrlbm5tcLBi0mF8wxUQGVBvHdC+YrHRlTUWjnN/4obhqljgrPTG3A RZtBAyLun1kMIfwj+XzanCaE7pfz5X+1U1DEEWl4a0HFqU4UC+8fia7u1zVDsy87zqmM aCnZO4WYMlXyBvwTDY5YzycIIMk8vbQav6mKwEUaLZN6qC6Wase6y5kT8waFE/KYHjR2 sI+xNuy9ZVIQOG/d3gqTWFx/1AYoGsrnH4KQyKPBRTWgKQPqX7caUSWi/ZiuXFXkwHDR u2xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MT3rEIfaJgpzvHmFM2pWeqN2XOEfjsN3Ht7YF+hthq8=; b=OId+X99opxaTy4wnXXX5jvJOQTjMooI1tt6Nok9AwVQQkk4lSseuqyRrUfWYsSEOVD 07n1/QEyv9ebjkjnaoXC7UT2A25GUK21zLmVXpiF/jVdM+hKMlHqfwILEETrFErChPge kr5llmFRAEo84Oer1GiGI6LF6B2C/rBp/Xc2DNNEjwwCbUIjuuZpxGWKShdg/SqjdVyW Fvf+TSAAvE9Hp8lesWLWUnL8bMWKPNyTG+jlxUXviW3h2pzLXTQVk+WQPRq8TRmvOlUz 7nALVvHaHsKi7QAhOvoeqifUy1Olkay9Zg5b2Ar2pMYrbffKkvX7Jyv8aUratC+RXKI8 jS7Q== X-Gm-Message-State: APjAAAUFFotjCGP9jDthJtGYrlT7rZLvicfENRdYG3f/hdw6h3oVIvyF oahEUZP04tbN3wkqlLGU06E/1hzktPb3YzyrBykbrA== X-Google-Smtp-Source: APXvYqy8O3KoXcSTxHqiytQM1iXWb+WWT9oKskcwqzyLQpgWA96K2vO/7MEIdTwZ75zGDyeYqjyajaWRaH5XxPonWcc= X-Received: by 2002:a62:798e:: with SMTP id u136mr6912504pfc.3.1569618754157; Fri, 27 Sep 2019 14:12:34 -0700 (PDT) MIME-Version: 1.0 References: <80dd26ecf7fc82c88dc378d78210df5dd4138812.1569569778.git.Jose.Abreu@synopsys.com> In-Reply-To: <80dd26ecf7fc82c88dc378d78210df5dd4138812.1569569778.git.Jose.Abreu@synopsys.com> From: Nick Desaulniers Date: Fri, 27 Sep 2019 14:12:23 -0700 Message-ID: Subject: Re: [PATCH net 8/8] net: stmmac: xgmac: Fix RSS not writing all Keys to HW To: Jose Abreu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190927_141238_479467_E4434CA1 X-CRM114-Status: GOOD ( 16.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joao Pinto , Alexandre Torgue , Network Development , LKML , linux-stm32@st-md-mailman.stormreply.com, clang-built-linux , Maxime Coquelin , Giuseppe Cavallaro , "David S. Miller" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 27, 2019 at 12:49 AM Jose Abreu wrote: > > The sizeof(cfg->key) is != ARRAY_SIZE(cfg->key). Fix it. I think the warning was from -Wsizeof-array-div. > > Reported-by: kbuild test robot > Reported-by: Nick Desaulniers I may have reported the kbuild link, but scanning my email, there's also a report from Reported-by: Nathan Chancellor > Fixes: 76067459c686 ("net: stmmac: Implement RSS and enable it in XGMAC core") > Signed-off-by: Jose Abreu > > --- > Cc: Giuseppe Cavallaro > Cc: Alexandre Torgue > Cc: Jose Abreu > Cc: "David S. Miller" > Cc: Maxime Coquelin > Cc: netdev@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: Nick Desaulniers > --- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > index 6d8ac2ef4fc2..4a1f52474dbc 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > @@ -533,7 +533,7 @@ static int dwxgmac2_rss_configure(struct mac_device_info *hw, > return 0; > } > > - for (i = 0; i < (sizeof(cfg->key) / sizeof(u32)); i++) { > + for (i = 0; i < (ARRAY_SIZE(cfg->key) / sizeof(u32)); i++) { cfg is an instance of struct stmmac_rss, which looks like: 125 struct stmmac_rss { 126 int enable; 127 u8 key[STMMAC_RSS_HASH_KEY_SIZE]; 128 u32 table[STMMAC_RSS_MAX_TABLE_SIZE]; 129 }; yep, LGTM. Thanks for the patch. Reviewed-by: Nick Desaulniers > ret = dwxgmac2_rss_write_reg(ioaddr, true, i, cfg->key[i]); > if (ret) > return ret; > -- > 2.7.4 > -- Thanks, ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel