From: Evan Benn <evanbenn@chromium.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Rob Herring" <robh@kernel.org>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org,
"Anson Huang" <Anson.Huang@nxp.com>,
"Dinh Nguyen" <dinguyen@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
"Olof Johansson" <olof@lixom.net>,
"Clément Péron" <peron.clem@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
"Julius Werner" <jwerner@chromium.org>,
"Leonard Crestez" <leonard.crestez@nxp.com>,
"Will Deacon" <will@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] watchdog: Add new arm_smc_wdt watchdog driver
Date: Thu, 20 Feb 2020 17:50:03 +1100 [thread overview]
Message-ID: <CAKz_xw0fHgVBLdEoEoQ7OSAgBcvYBAowV0obWLsDUGNPotP55Q@mail.gmail.com> (raw)
In-Reply-To: <804d3cc5-688d-7025-cb87-10b9616f4d9b@roeck-us.net>
> > + if ((int)res->a0 == PSCI_RET_NOT_SUPPORTED)
> > + return -ENOTSUPP;
>
> -ENODEV would be better here.
>
> > + if ((int)res->a0 == PSCI_RET_INVALID_PARAMS)
> > + return -EINVAL;
> > + if ((int)res->a0 < 0)
> > + return -EIO;
In fixing this I found drivers/firmware/psci/psci.c:145
Which also translates psci codes to errno codes, but uses EOPNOTSUPP:
switch (errno) {
case PSCI_RET_SUCCESS:
return 0;
case PSCI_RET_NOT_SUPPORTED:
return -EOPNOTSUPP;
case PSCI_RET_INVALID_PARAMS:
case PSCI_RET_INVALID_ADDRESS:
return -EINVAL;
case PSCI_RET_DENIED:
return -EPERM;
};
return -EINVAL;
Are these more appropriate?
Evan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-20 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 6:26 [PATCH 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls Evan Benn
2020-02-14 6:26 ` [PATCH 2/2] watchdog: Add new arm_smc_wdt watchdog driver Evan Benn
2020-02-14 9:35 ` Enric Balletbo Serra
2020-02-14 14:10 ` Guenter Roeck
2020-02-14 21:32 ` Julius Werner
2020-02-15 1:39 ` Evan Benn
2020-02-20 6:50 ` Evan Benn [this message]
2020-02-20 15:52 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKz_xw0fHgVBLdEoEoQ7OSAgBcvYBAowV0obWLsDUGNPotP55Q@mail.gmail.com \
--to=evanbenn@chromium.org \
--cc=Anson.Huang@nxp.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dinguyen@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marcin.juszkiewicz@linaro.org \
--cc=mchehab+samsung@kernel.org \
--cc=olof@lixom.net \
--cc=peron.clem@gmail.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).