From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC0CC83004 for ; Tue, 28 Apr 2020 04:43:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 667A8206BF for ; Tue, 28 Apr 2020 04:43:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ULjtnnS0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WD0Vdo9P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 667A8206BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bOI9Rfeva/SAWeFeUrvjZvL8+zT2IkZMUaeimH16VHg=; b=ULjtnnS0G78tl/ I7mtywyTRkIjq/XDjJtjk4G+toRyF+lqmEAMHbYfPaCGeWS7V0p4GwqOCZ6sjiNVgrFHQnreXRH9/ o6ZdZbpRghURM2jzyGd1Q+gWGiq/Ds22/ftQZzOj5OJ+vOFAo8ri5uLXYwqYZgKJ1WL/4f2byYB55 FDdrCxk+UBBP/TXRF11FGOAd6N3R123xgUg+DUOQblbbjyLaSGrciPxoQPfyDNsf7/Is20pciCnfa ImjiYYJbHxJtD0bYpaYWDGIz7ZRdHzV2E8N9XBQ9U5X0s6YtsjCK0TYuloIb2HmStICsvZITzia84 pfngTjyImi4FEJLrbweg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTI5e-00076m-9m; Tue, 28 Apr 2020 04:43:26 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTI5a-000757-OV for linux-arm-kernel@lists.infradead.org; Tue, 28 Apr 2020 04:43:24 +0000 Received: by mail-pg1-x541.google.com with SMTP id p8so9719260pgi.5 for ; Mon, 27 Apr 2020 21:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6MzIVWZpSVCHDb5pf6WQNcJ/ckZ7Y5e/ESVb+fFzIZA=; b=WD0Vdo9P4/N4GSEpKAhopNTQVyTrPiPKK3hWvrtsiHMzebOMrruO2aJX9wZe95BGHj XGk8c62wFBqDPwNbo61yYZGaWDExozBcGqaTvzvhgue/6PH25ZdF3jIcE9D0iv7XULGu hc0qeug7S/R/21XHC27bLSFzxUVEnjHArDV38= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6MzIVWZpSVCHDb5pf6WQNcJ/ckZ7Y5e/ESVb+fFzIZA=; b=dbDFEyBmbNbrM5eFwlArODLGzxwQTnmMhcGLZP79TTtpncwW2MAJId4v7jAyT/cqRl j0oh7hgMUJbZnN5J4x/uccd6kgMTS/gWaCMIFF8mmyattp1tvyBsVmfgjdZlTIKPozog ZD7esi5wF5B70LzWaVKInA6pDVmMdRpPskfUPQOzk9IGSDV23zy0KU31+JeTnIFj0aRd BDXPVkfl++Y75gqzR+bGWtengCaP+/alIsDppUmkKG1JWhyxC7Y8W7B/LVgXCQgEqX8t SdoGbL34LpcStHtCVzC5gzpbl3iK6364WnMdA8WlPjOwMpmuwnivNsv3wmMdTRAXouxj xwag== X-Gm-Message-State: AGi0Pubd5Etu7y/MPGYQwNr35JubXHyZRTasDMu27I+EsA53FqU54ecM lleCTIKLg3sqXRnhJ5cQbv9tlcdBQ4Q= X-Google-Smtp-Source: APiQypLiAWSh9x1cKOkSEnOT0Rh2bsz2ms33Ntt0PX7rXyZiSfynHHXqCsiqJOuHfKYE9SEmUhLY0Q== X-Received: by 2002:a63:7f1a:: with SMTP id a26mr14090125pgd.252.1588048999941; Mon, 27 Apr 2020 21:43:19 -0700 (PDT) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com. [209.85.214.177]) by smtp.gmail.com with ESMTPSA id mn1sm815085pjb.24.2020.04.27.21.43.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2020 21:43:19 -0700 (PDT) Received: by mail-pl1-f177.google.com with SMTP id k18so7858364pll.6 for ; Mon, 27 Apr 2020 21:43:18 -0700 (PDT) X-Received: by 2002:a67:f9d0:: with SMTP id c16mr19912596vsq.53.1588048997072; Mon, 27 Apr 2020 21:43:17 -0700 (PDT) MIME-Version: 1.0 References: <20200423044036.234578-1-evanbenn@chromium.org> <20200423143945.v5.2.Ia92bb4d4ce84bcefeba1d00aaa1c1e919b6164ef@changeid> In-Reply-To: From: Evan Benn Date: Tue, 28 Apr 2020 14:42:50 +1000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 2/2] watchdog: Add new arm_smc_wdt watchdog driver To: Julius Werner X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_214322_822000_D1E94192 X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Catalin Marinas , Bjorn Andersson , Leonard Crestez , Will Deacon , Xingyu Chen , Rob Herring , Anson Huang , Mauro Carvalho Chehab , Marcin Juszkiewicz , Valentin Schneider , Guenter Roeck , LINUX-WATCHDOG , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Wim Van Sebroeck , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Greg Kroah-Hartman , LKML , Li Yang , Olof Johansson , Shawn Guo , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 24, 2020 at 8:17 AM Julius Werner wrote: > > > + err = of_property_read_u32(pdev->dev.of_node, "arm,smc-id", > > + &smc_func_id); > > + if (err < 0) > > + return err; > > + watchdog_set_drvdata(wdd, (void *)(uintptr_t)smc_func_id); > > Your device tree binding says there's a default and this is optional. > I think you need to change the code so that that's actually true. I think I have misunderstood the device tree json-schema spec. My intention was for the device tree to fill in a default value in the dtb for arm,smc-id if it was omitted in the dts. But now I see that does not seem to happen, I cannot really find any documentation of `default`, so I will just put a documentation string in instead and force the default in the driver. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel