From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7BC8C433DF for ; Mon, 29 Jun 2020 07:39:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A586823159 for ; Mon, 29 Jun 2020 07:39:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yWDkqN6K"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hO7YgCFE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A586823159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fFkKalCpDLGcp92G+TZA2TzcBa+UOeLgapTMLG0HRtQ=; b=yWDkqN6KSffVT1C9Z0HPszYvm /qH4EnDaRWd8O3Dj/aSbqa0EEkCMeo/wBlvnHiD/dKZxakwZe3195me25/kdCeTbzW36CzrOwrgY2 98jLAXeBxK8Bjfe79H7n3zkrh9hYPzR16YMM4wt0JiwtJ92unzh8ISB0d1o29dHxQTRFb0IdgnU8m sSwCk6P4LsEta0fDDOlvC/VMJ0tEhJ0r38xjxTS/OltAYKzmmfaOD47VqJ7rpmeUSVSrgCkIygTVH OntKYOjWom4rCUHxhHTu96+bCDZDP/mYcl8eQcaG9+yJPZcE7HwNDmatPBptGL7WAzgLU/v5zqc8b TgXxHgLYw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpoMn-0004FA-Eu; Mon, 29 Jun 2020 07:38:13 +0000 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpoMk-0004ES-SI; Mon, 29 Jun 2020 07:38:11 +0000 Received: by mail-il1-x142.google.com with SMTP id e18so2929508ilr.7; Mon, 29 Jun 2020 00:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zTLnTytmqwPo2QrVotAhwjgdIikFCW3Y9V9c+Ul628k=; b=hO7YgCFEdPYQrvp3kFZV2OXX7bnz/HWxL/I8M9F3srON/2EpwrjADVZaSmO3wpR10e xShjxgypbemlvSD4Bz2KZS86mWY4elE17aaWa4OOf7VRrcaMFZDnWR2kmmozvactxe8V vM+6Leu3iiG3sATYROu72hMLLm2MvJ+916wUcSNvcmS/VTVDrNw4lnWf+BAIOfmSaLzi 0DWQpAEbhPYF8NHE2JoIR9A36MthArCCdlrbViQbFS8mqlUIyyL6FA3raDQc22IukKk8 hRi7ulSD+AEVcXSzY1xkQF/eQcZYVfkoF4U4jwu4IMEjvmBXghP0hrkbuxAD1I/tQvV6 mi2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zTLnTytmqwPo2QrVotAhwjgdIikFCW3Y9V9c+Ul628k=; b=RpWNAtBZbylYwc2dyMXwhx3kmclYKuhx0/0wC/BtLarYwsVgUwiUoFgYmxHc/V9AVj FMXbqpjhesNqpSNxvLgUr7H/cFBIybw0v0Wz6nLdmBEGm4V3lHEAmvaGLACAxsGAkDbb C9wZeLrVgS/h/mWu6aGyG2lMU4zgzd1sOUJMuZBcMN/3eHSbQrwP6xmpZYvLdvOsu8Lg t2Y49bePuFfOlSSH0w8i/GjfLpBEiK12Wjg/dDCRn52kJ5Jcihl5PY/TRnkDGh84Juk5 BDTHyrp4CPAfjOKas62VB+w+b0RyhM6skzM1YboeOHbXPgFGam4Nn/uHWXSflhqo6794 nVBg== X-Gm-Message-State: AOAM532vvMawtKTFzM5yK7KxBpzUcdBJD1TR0wwpnfKpxBTgBSfjgTi/ 2p3Jf5SjDWqpsmikK6m+ML71Dy48zFOhJYEE6Fo= X-Google-Smtp-Source: ABdhPJzyfEuSvsvqAyieDmK4mMBIE5np8Cjw7UhIz6L0NfvR0InXzI9MesOfgOM7McMyA0mnJHM4y1HqDRacRIX8BDg= X-Received: by 2002:a92:940f:: with SMTP id c15mr15673200ili.204.1593416287611; Mon, 29 Jun 2020 00:38:07 -0700 (PDT) MIME-Version: 1.0 References: <1593410434-19406-1-git-send-email-chunfeng.yun@mediatek.com> In-Reply-To: <1593410434-19406-1-git-send-email-chunfeng.yun@mediatek.com> From: Peter Chen Date: Mon, 29 Jun 2020 15:37:54 +0800 Message-ID: Subject: Re: [PATCH 1/2] usb: mtu3: disable USB2 LPM To: Chunfeng Yun X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Greg Kroah-Hartman , USB list , lkml , linux-mediatek@lists.infradead.org, Matthias Brugger , Markus Elfring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 2:04 PM Chunfeng Yun wrote: > > A SuperSpeed device shall include the USB 2.0 extension descriptor > and shall support LPM when operating in USB 2.0 HS mode(see usb3.2 > spec9.6.2.1). But we always don't support it, so disable it by > default, otherwise device will enter LPM suspend mode when > connected to Win10 system. Linux also supports USB2 LPM. Besides, USB-IF CH9 test will check LPM support if the device is USB 2.1, how could you deal with it? Peter > > Signed-off-by: Chunfeng Yun > --- > drivers/usb/mtu3/mtu3_core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c > index 9dd0216..50d6a40 100644 > --- a/drivers/usb/mtu3/mtu3_core.c > +++ b/drivers/usb/mtu3/mtu3_core.c > @@ -604,6 +604,8 @@ static void mtu3_regs_init(struct mtu3 *mtu) > mtu3_clrbits(mbase, U3D_MISC_CTRL, VBUS_FRC_EN | VBUS_ON); > /* enable automatical HWRW from L1 */ > mtu3_setbits(mbase, U3D_POWER_MANAGEMENT, LPM_HRWE); > + /* always reject LPM request */ > + mtu3_setbits(mbase, U3D_POWER_MANAGEMENT, LPM_MODE(1)); > > /* use new QMU format when HW version >= 0x1003 */ > if (mtu->gen2cp) > -- > 1.9.1 > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel