From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BF1FC43460 for ; Wed, 21 Apr 2021 03:43:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0972613F0 for ; Wed, 21 Apr 2021 03:43:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0972613F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0RbbJW3/EXP9Nvzxm0K+cWX9lFKWOwgvkrIsjmf1kxk=; b=FivcIm5f6ItTMjQUZ/SqbsYxV GDwywFfhClmLj8s4VlJs5o8ODVHcCL2Q6vgz3at/othycTdcCLHe3N1kBXH/iof1WrKXBHJd0TKER owvvt8ZxHdJSGNSJYklXDerItK5WxLcFKWnXBhqIU1WhLFRkieHRuF4u7ezCQhRD7FHTFvvrm55gz zKrw6gF/J53xELJ7rttPdXgrYbFsuL/PVFgjqLgcg3A2xwHuByJaXTPH5/A7TlF+iklvXgkhMJq0p yUVBev2dHK/ejaIML6sx55YFYYarejbL84RwUne3iT+U9JCNwcq25+3KFmOMcNS0D+gC1m0E5kF+3 gC4Jcis1A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZ3jk-00DZ3Z-NE; Wed, 21 Apr 2021 03:41:13 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZ3jh-00DZ3T-4U for linux-arm-kernel@desiato.infradead.org; Wed, 21 Apr 2021 03:41:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HUL5iOZc28qAX3PsDJ0khNs1c1kb23x81GpeZXPZHr0=; b=Z/Wnldm/0nPNxq77da1PTyg+H5 UB3+QZxbyc5m8J53ESzBQqyybt8s2Cq7PBqVGYX+0YWMP4ncMVAdg+RVByfngEQb29NgqdHdVLIds q+Aou7R4wuOovfUlTotBCQS2gAz19TR1PFGmufyGPdp7ToeA13dgSOtuGXjlohyEeOtaH9k83d7/K ssKHl4t+sL2lo/wK0l5pL9TtKjuwslANjtBi3tojpF9YkbafxEKGRdWjCU6HDhQAniG1sGxayeqWp LqBF2/EyvZ3QkB49ctBTRJ+rOU7en/uEKtAPjBeWyD+L6hN7uXkYP7cryoBegG9LJIYCMOlCoM7ti rjuAyTiw==; Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZ3jd-00CZHZ-V4 for linux-arm-kernel@lists.infradead.org; Wed, 21 Apr 2021 03:41:07 +0000 Received: by mail-io1-xd32.google.com with SMTP id h141so32324831iof.2 for ; Tue, 20 Apr 2021 20:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HUL5iOZc28qAX3PsDJ0khNs1c1kb23x81GpeZXPZHr0=; b=WQl3BZB24dee0+iczS32i6ta8dIDUsrzhFvhRoKrmzXendrjWQ6+ymVePQXQ8eK+7J XuICOmjrS/ieQeiC7EDSYpkXk644BJZ7cWliU1vFMgqgxs5mjb5f/ElzehsFDgC/y4pV Qg9q/mFXhRQDOdZaJW+PSsQACanIHQ1OajWj2SP3/Z5Ov8t5F3PHq3rfk0rlBUgk13If OIPD96AJuZDFgx/SSYOF+pU09mna2FvEXliI0AosI8ZcRVnQHr8/ce7mxX/WzTJceFeB 8Vv8oDU2X7YKHI3K5D8PJv1eVloXMJxjzDEbjZyor553CzD9YXs4qsYkF8RJd8bckK+M H2eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HUL5iOZc28qAX3PsDJ0khNs1c1kb23x81GpeZXPZHr0=; b=aVBvH978QtaVJMh+4iRAs92ileWMzVCo4Jqm6gVHS1IpU8/dgusL6xjWmETMTf9WIr JQiF38CAHpvHIBZF5dvp/ojP4hsV4GYJ8qZOInw9OIIgUED4R3/bvOiFX46g9wfnudH1 aCFYmNQfz4K1gReOUGWIQEoWmP1dHcY9DMBt503MBKk84YV7by4CyhVkQ3wKrVQwexsM neysWpjjCfdZWT6t2Dn2h+sxe3anBH4Bu9F9+bFovVSXTt6hmJHCScVeD6U93RMZgJgz 04jxnk5TI36dckyu5GQUZw8gM9osV6QA8wXGB1ur6ezwJHAehUv+D1EwQ2jbwv3nKSH0 mizA== X-Gm-Message-State: AOAM530VhWhP0I4cGWGyd/B3bJAVDLboqaEk6XWlU+S1dGPHUPxHqZBY GFoY+xt+41KsmGoQ8Ix0G0NVurrdPAXbRFOnoWk= X-Google-Smtp-Source: ABdhPJzNC46+JNBKZghlVn6QayNw6kik/i4m+Dj7Rwp0R3QmmJrMXqgLvPgwT6+epZB2PlQbrhVzal7ScxXq3V5NSNs= X-Received: by 2002:a05:6638:34a0:: with SMTP id t32mr24067421jal.10.1618976462773; Tue, 20 Apr 2021 20:41:02 -0700 (PDT) MIME-Version: 1.0 References: <1618459535-8141-1-git-send-email-dillon.minfei@gmail.com> <1618459535-8141-4-git-send-email-dillon.minfei@gmail.com> In-Reply-To: From: dillon min Date: Wed, 21 Apr 2021 11:40:26 +0800 Message-ID: Subject: Re: [PATCH v3 3/4] arm: dts: imx: Add i.mx6q DaSheng COM-9XX SBC board support To: Fabio Estevam Cc: Krzysztof Kozlowski , Rob Herring , Shawn Guo , Krzysztof Kozlowski , Oleksij Rempel , Stefan Riedmueller , Matthias Schiffer , leoyang.li@nxp.com, arnd@arndb.de, olof@lixom.net, Sascha Hauer , kernel@pengutronix.de, prabhakar.csengg@gmail.com, mchehab@kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux ARM , linux-imx@nxp.com, linux-media@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_204106_007973_FA98A021 X-CRM114-Status: GOOD ( 19.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabio, Thanks for quick reply. On Tue, Apr 20, 2021 at 10:27 PM Fabio Estevam wrote: > > Hi Dillon, > > On Thu, Apr 15, 2021 at 1:05 AM wrote: > > > + green { > > + gpios = <&gpio4 8 0>; > > Please use GPIO_ACTIVE_HIGH label instead: > gpios = <&gpio4 8 GPIO_ACTIVE_HIGH>; > > > +&clks { > > + assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>, > > + <&clks IMX6QDL_CLK_LDB_DI1_SEL>; > > + assigned-clock-parents = <&clks IMX6QDL_CLK_PLL3_USB_OTG>, > > + <&clks IMX6QDL_CLK_PLL3_USB_OTG>; > > +}; > > You are setting the LDB clock parent, but you don't use LDB in this > devicetree. You could simply remove this. Agree, thanks. > > > +&ecspi1 { > > + cs-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_ecspi1>; > > + status = "okay"; > > + > > + flash: m25p80@0 { > > Node names should be generic: > > m25p80: flash@0 Agree, thanks. > > > +&iomuxc { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_hog>; > > + > > + imx6qdl-ds { > > + pinctrl_hog: hoggrp { > > + fsl,pins = < > > + MX6QDL_PAD_NANDF_D0__GPIO2_IO00 0x1b0b0 > > + MX6QDL_PAD_NANDF_D1__GPIO2_IO01 0x1b0b0 > > + MX6QDL_PAD_GPIO_0__CCM_CLKO1 0x130b0 > > This could be part of the pinctrl_ov2659 group as it provides the > clock for the camera. > > Please try to keep in the hoggrp only the pins that cannot be > controlled by any other node. Agree, after moving these pinctrl to corresponding component's group, the hoggrp is useless. so, I removed it in v4. > > > +&wdog1 { > > + status = "okay"; > > +}; > > + > > +&wdog2 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_wdog>; > > + fsl,ext-reset-output; > > + status = "disabled"; > > Wouldn't it be better to enable wdog2 and disable wdog1 instead? wdog2 > provides a POR, which is preferred. Agree, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel