From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7178CC2B9F4 for ; Thu, 17 Jun 2021 10:42:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A3FE613B9 for ; Thu, 17 Jun 2021 10:42:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A3FE613B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fLkZAjZX7mH3bCPScVSGSCtFVRgPbBUaDSirBL/Sh9k=; b=jFU3f/7O9TMyYn nhD9+pziwA8TNPmQwa2pXnMFILtFL5llK4q/8A62gqg6fGZl3ees2jpkk2zplYxy5UDIyajZNkLNC L7MvYMnpSpy+V+LXHc122XM0I9pi/mQfn8LrU0IZpsLYUhoKrvlPndhlEviSq3O/FkRedXdWHa6je DTjLyLP4Gv2l7imkO13bsSkf/qSuTr/NFHPbeJp+IFOmG1NW/FDBWbIiOgiPdo9q4+mH/sDbtfbXG U/X+S3sNINfJCUoHTxDStaQETfwnIZyDFNkUPFbnesFTIpSrvdxFvEQdT0crM6XSJAgg9l9Lj9q2V aWlPR7VSIhtX87SI0VEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltpSZ-009t2N-SU; Thu, 17 Jun 2021 10:41:20 +0000 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltpSU-009t17-MZ for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 10:41:16 +0000 Received: by mail-io1-xd29.google.com with SMTP id s26so2576647ioe.9 for ; Thu, 17 Jun 2021 03:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k5h9lWFEFZiq9DqBhAFZW6ZADMIHfKPewEhboCoUBeo=; b=CjIntfsRB0lb653kwHywX8oaCwH0zs8tOBtV6/dZ12Oj961cifq9XFJgvD7XrX8M+M VO8rcRQLYMugTvc6aakzNYSPbvxFiwyT+sPElt3yIdubRyYDG7wzGmlGQdl8Ey2WzquR Tst426PXr4YHGK7Y7WuSs+DJKcp53ylGeRK1nV8Buo6NvmI0b0Vo6B3l4SWCeM3z7aZK 4LmlfYONs01M7vKWrSU6bLRGDxj3qP4lw4f0WJKAbCMMDnHsHCjQyzP9cSQYnHbUNukx kkVpr5I3ftvMHoH8fJA1elFhZPMaXrT1jmg17+IPIoJ4mL8PaXJokTHADO8MSHfqUxRg kurw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k5h9lWFEFZiq9DqBhAFZW6ZADMIHfKPewEhboCoUBeo=; b=OMihPSFnvyR1y62AlVEusnyyqscqy2BUB1Beh3DkVOjCruDylZ9DwkevQfEWqw/Xtn Rn3v0u2Zf8jonhDbtE1xVjO2bv7tnp+57+XZ0xM4dtUW6m1CW+9EBkED1+3mzPjzUzIr SlFqbzp11qSRbJwvEWpk019MYO3OuNtgC3dsR9rHN6Epb9qWqR+L9Knl/5BrexW2+ul4 jUiTqoPqTY4VVy/yU2zt3DdjW/dbQRPc5bNlJw3cTsMPkRW+bfqgWVI6orwLdVXnKohn O6Z1wjSJh4bp6wiXtJxDzDpH89SGD8DfcEELi7IFCl2rXdas9Zs4ITOoOsGBl8eSqtMA +pYA== X-Gm-Message-State: AOAM532Acm479yQ1/Ukj8k8ezliZ0rqF2hNK7XoD6qQZ4NYuLLZVBMfD y3lKG+lUb7MUV22vO3s4R4b5tO3DMHzUNIe2tqc= X-Google-Smtp-Source: ABdhPJzZW0Z79Zpvy5uBSOey3RVZxO7W8bRda487KKxHuBlK5Y8u3PSSKBjE1BKY3xvz5YBo4H+uN60Cz8Q1GbjoFBU= X-Received: by 2002:a6b:6205:: with SMTP id f5mr3248085iog.60.1623926473727; Thu, 17 Jun 2021 03:41:13 -0700 (PDT) MIME-Version: 1.0 References: <1621508727-24486-1-git-send-email-dillon.minfei@gmail.com> <1621508727-24486-7-git-send-email-dillon.minfei@gmail.com> In-Reply-To: From: Dillon Min Date: Thu, 17 Jun 2021 18:40:37 +0800 Message-ID: Subject: Re: [PATCH 6/7] media: v4l2-mem2mem: add v4l2_m2m_get_unmapped_area for no-mmu platform To: Hans Verkuil Cc: Mauro Carvalho Chehab , mchehab+huawei@kernel.org, ezequiel@collabora.com, gnurou@gmail.com, Pi-Hsun Shih , Maxime Coquelin , Alexandre TORGUE , Michael Turquette , Stephen Boyd , Rob Herring , Patrice CHOTARD , hugues.fruchet@foss.st.com, linux-media , Linux Kernel Mailing List , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_034114_802007_B6885D28 X-CRM114-Status: GOOD ( 23.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Hans, On Thu, Jun 17, 2021 at 5:58 PM Hans Verkuil wrote: > > On 20/05/2021 13:05, dillon.minfei@gmail.com wrote: > > From: Dillon Min > > > > For platforms without MMU the m2m provides a helper method > > v4l2_m2m_get_unmapped_area(), The mmap() routines will call > > this to get a proposed address for the mapping. > > > > More detailed information about get_unmapped_area can be found in > > Documentation/nommu-mmap.txt > > I'm getting checkpatch.pl --strict warnings: > > CHECK: Alignment should match open parenthesis > #31: FILE: drivers/media/v4l2-core/v4l2-mem2mem.c:971: > +unsigned long v4l2_m2m_get_unmapped_area(struct file *file, unsigned long addr, > + unsigned long len, unsigned long pgoff, unsigned long flags) > > CHECK: Alignment should match open parenthesis > #62: FILE: include/media/v4l2-mem2mem.h:500: > +unsigned long v4l2_m2m_get_unmapped_area(struct file *file, unsigned long addr, > + unsigned long len, unsigned long pgoff, unsigned long flags); Okay, I will add the "--strict" check to my regular patch submission. Thanks for the reminder. Best Regards Dillon > > Regards, > > Hans > > > > > Signed-off-by: Dillon Min > > --- > > drivers/media/v4l2-core/v4l2-mem2mem.c | 20 ++++++++++++++++++++ > > include/media/v4l2-mem2mem.h | 4 ++++ > > 2 files changed, 24 insertions(+) > > > > diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c > > index e7f4bf5bc8dd..f82a18ecab2f 100644 > > --- a/drivers/media/v4l2-core/v4l2-mem2mem.c > > +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c > > @@ -966,6 +966,26 @@ int v4l2_m2m_mmap(struct file *file, struct v4l2_m2m_ctx *m2m_ctx, > > } > > EXPORT_SYMBOL(v4l2_m2m_mmap); > > > > +#ifndef CONFIG_MMU > > +unsigned long v4l2_m2m_get_unmapped_area(struct file *file, unsigned long addr, > > + unsigned long len, unsigned long pgoff, unsigned long flags) > > +{ > > + struct v4l2_fh *fh = file->private_data; > > + unsigned long offset = pgoff << PAGE_SHIFT; > > + struct vb2_queue *vq; > > + > > + if (offset < DST_QUEUE_OFF_BASE) { > > + vq = v4l2_m2m_get_src_vq(fh->m2m_ctx); > > + } else { > > + vq = v4l2_m2m_get_dst_vq(fh->m2m_ctx); > > + pgoff -= (DST_QUEUE_OFF_BASE >> PAGE_SHIFT); > > + } > > + > > + return vb2_get_unmapped_area(vq, addr, len, pgoff, flags); > > +} > > +EXPORT_SYMBOL_GPL(v4l2_m2m_get_unmapped_area); > > +#endif > > + > > #if defined(CONFIG_MEDIA_CONTROLLER) > > void v4l2_m2m_unregister_media_controller(struct v4l2_m2m_dev *m2m_dev) > > { > > diff --git a/include/media/v4l2-mem2mem.h b/include/media/v4l2-mem2mem.h > > index 5a91b548ecc0..91269227c265 100644 > > --- a/include/media/v4l2-mem2mem.h > > +++ b/include/media/v4l2-mem2mem.h > > @@ -495,6 +495,10 @@ __poll_t v4l2_m2m_poll(struct file *file, struct v4l2_m2m_ctx *m2m_ctx, > > int v4l2_m2m_mmap(struct file *file, struct v4l2_m2m_ctx *m2m_ctx, > > struct vm_area_struct *vma); > > > > +#ifndef CONFIG_MMU > > +unsigned long v4l2_m2m_get_unmapped_area(struct file *file, unsigned long addr, > > + unsigned long len, unsigned long pgoff, unsigned long flags); > > +#endif > > /** > > * v4l2_m2m_init() - initialize per-driver m2m data > > * > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel